[Payment due @hoangzinh] Fix: Wrong codice fiscale field name - #96331
puneetlath merged 6 commits into
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd8faa2542
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I don't know which C+ is the right one here because Melvin double-assigned. I assume it's @sobitneupane because he was assigned first. You can start reviewing this because backend changes are on staging. You should toggle |
|
yeah. @sobitneupane go ahead. But if you're busy, I’m here to back you up ;) |
|
Bump @sobitneupane. This is blocking real customers |
…-codice-fiscale-field-name
|
Thanks for the ping. I am currently tied up with other issues and haven't been able to reviet it yet.. @hoangzinh could you please take a look if you are available. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-23.at.07.12.08.mp4 |
|
🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@puneetlath All yours |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.44-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against the help site articles under Why: This PR is a purely internal fix. It corrects the backend API parameter/field-name keys the App sends to Corpay for the Italian bank-account onboarding flow:
These are field identifiers exchanged with the backend, not user-facing feature names, tab names, labels, or buttons. The change restores the intended behavior of an existing flow (adding a global-reimbursement bank account for Italy) rather than adding or altering any documented workflow. The relevant help articles already describe this flow at the correct altitude and remain accurate:
Since the user-facing steps and labels are unchanged, there is nothing to update on the help site, so I have not created a draft docs PR. @dominictb, please confirm you agree no help-site changes are needed here. If you'd like a docs PR created anyway (e.g., to expand the Italy-specific requirements in the Global Reimbursement article), let me know and I'll open one. |
|
🤖 Payment issue created: #97136 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Updates the correct field names for Italian tax ID:
codiceFisclaleTaxIDcodiceFiscaleTaxIDcodiceFiscaleTaxIDsignerCodiceFiscaleTaxIDThis mismatch is a real customer-facing issue that blocks them from adding their bank account.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/636563
PROPOSAL:
Tests
Confirm business bank account currency and country, select ItalyBeneficial owner:
Do you own 25% or more of, select NoDo any individuals own 25% or more, select YesUpload additional documentation, upload all required documentsAre there more individuals who own 25% or more of, select No > ConfirmDirector:
Are you a director at, select YesUpload additional documentation, upload all required documentsOffline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Beneficial owner step:
Screen.Recording.2026-07-17.at.01.24.43.mov
Director step:
Screen.Recording.2026-07-17.at.01.28.07.mov