Skip to content

[Payment due @hoangzinh] Fix: Wrong codice fiscale field name - #96331

Merged
puneetlath merged 6 commits into
Expensify:mainfrom
dominictb:fix/wrong-signer-codice-fiscale-field-name
Jul 23, 2026
Merged

puneetlath merged 6 commits into
Expensify:mainfrom
dominictb:fix/wrong-signer-codice-fiscale-field-name

Conversation

@dominictb

@dominictb dominictb commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the correct field names for Italian tax ID:

Field Field name Correct field name Reference
Beneficial owner's tax ID codiceFisclaleTaxID codiceFiscaleTaxID ref
Director's (signer's) tax ID codiceFiscaleTaxID signerCodiceFiscaleTaxID ref

This mismatch is a real customer-facing issue that blocks them from adding their bank account.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/636563
PROPOSAL:

Tests

  1. Set workspace currency to EUR
  2. Add a business bank account to workspace
  3. In Confirm business bank account currency and country, select Italy

Beneficial owner:

  1. In Do you own 25% or more of, select No
  2. In Do any individuals own 25% or more, select Yes
  3. In Upload additional documentation, upload all required documents
  4. In Are there more individuals who own 25% or more of, select No > Confirm
  5. Verify the step succeeds and moves to next step

Director:

  1. In Are you a director at, select Yes
  2. In Upload additional documentation, upload all required documents
  3. Verify the step succeeds and moves to the next step
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Beneficial owner step:

Screen.Recording.2026-07-17.at.01.24.43.mov

Director step:

Screen.Recording.2026-07-17.at.01.28.07.mov

@dominictb
dominictb requested review from a team as code owners July 16, 2026 16:55
@melvin-bot
melvin-bot Bot requested review from a team, sobitneupane and trjExpensify and removed request for a team July 16, 2026 16:55
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from hoangzinh and removed request for a team July 16, 2026 16:55
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dominictb
dominictb marked this pull request as draft July 16, 2026 16:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd8faa2542

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/types/form/EnterSignerInfoForm.ts
@dominictb dominictb changed the title Fix: Wrong signer codice fiscale field name [HOLD PHP #54597] Fix: Wrong signer codice fiscale field name Jul 16, 2026
@dominictb dominictb changed the title [HOLD PHP #54597] Fix: Wrong signer codice fiscale field name [HOLD PHP #54597] Fix: Wrong codice fiscale field name Jul 16, 2026
@dominictb
dominictb requested review from a team and puneetlath and removed request for a team July 16, 2026 18:34
@dominictb
dominictb marked this pull request as ready for review July 16, 2026 18:35
@dominictb dominictb changed the title [HOLD PHP #54597] Fix: Wrong codice fiscale field name Fix: Wrong codice fiscale field name Jul 17, 2026
@dominictb

dominictb commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

I don't know which C+ is the right one here because Melvin double-assigned. I assume it's @sobitneupane because he was assigned first. You can start reviewing this because backend changes are on staging. You should toggle Use Staging Server in troubleshoot modal.

@hoangzinh

Copy link
Copy Markdown
Contributor

yeah. @sobitneupane go ahead. But if you're busy, I’m here to back you up ;)

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@dominictb

dominictb commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Bump @sobitneupane. This is blocking real customers

@sobitneupane

Copy link
Copy Markdown
Contributor

Thanks for the ping. I am currently tied up with other issues and haven't been able to reviet it yet.. @hoangzinh could you please take a look if you are available.

@dominictb
dominictb requested review from hoangzinh and removed request for hoangzinh and sobitneupane July 21, 2026 08:43
@hoangzinh

hoangzinh commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-23.at.07.12.08.mp4

@melvin-bot melvin-bot Bot changed the title Fix: Wrong codice fiscale field name [Payment due @hoangzinh] Fix: Wrong codice fiscale field name Jul 23, 2026
@melvin-bot

melvin-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/636563.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@dominictb

Copy link
Copy Markdown
Contributor Author

@puneetlath All yours

@puneetlath
puneetlath merged commit ea855a7 into Expensify:main Jul 23, 2026
38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.44-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no changes required

I reviewed the changes in this PR against the help site articles under docs/articles, and no documentation updates are needed.

Why: This PR is a purely internal fix. It corrects the backend API parameter/field-name keys the App sends to Corpay for the Italian bank-account onboarding flow:

  • codiceFisclaleTaxIDcodiceFiscaleTaxID (beneficial owner's tax ID)
  • signerCodiceFiscalesignerCodiceFiscaleTaxID (director's/signer's tax ID)

These are field identifiers exchanged with the backend, not user-facing feature names, tab names, labels, or buttons. The change restores the intended behavior of an existing flow (adding a global-reimbursement bank account for Italy) rather than adding or altering any documented workflow.

The relevant help articles already describe this flow at the correct altitude and remain accurate:

  • Global-Reimbursement-Europe.md (New Expensify) — describes the beneficial owner and director steps generically, without referencing internal field names.
  • Global-Reimbursement-EU.md (Expensify Classic) — notes that Italy requires a "Codice Fiscale" (Tax ID), which is still correct.

Since the user-facing steps and labels are unchanged, there is nothing to update on the help site, so I have not created a draft docs PR.

@dominictb, please confirm you agree no help-site changes are needed here. If you'd like a docs PR created anyway (e.g., to expand the Italy-specific requirements in the Global Reimbursement article), let me know and I'll open one.

@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #97136

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants