Skip to content

[CP staging] Revert "Allow negative response to be reprompted after 30 days" - #96229

Closed
jasperhuangg wants to merge 1 commit into
mainfrom
revert-94936-reapply-94163
Closed

jasperhuangg wants to merge 1 commit into
mainfrom
revert-94936-reapply-94163

Conversation

@jasperhuangg

Copy link
Copy Markdown
Contributor

Reverts #94936

@jasperhuangg
jasperhuangg requested review from a team as code owners July 16, 2026 01:35
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 16, 2026 01:35
@melvin-bot
melvin-bot Bot requested a review from deetergp July 16, 2026 01:35
@melvin-bot

melvin-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 16, 2026 01:35
@github-actions

Copy link
Copy Markdown
Contributor

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@jasperhuangg jasperhuangg changed the title Revert "Allow negative response to be reprompted after 30 days" [CP staging] Revert "Allow negative response to be reprompted after 30 days" Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96229.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://96229.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@hungvu193

Copy link
Copy Markdown
Contributor

I thought @roryabraham raises another PR here to fix the issue: #96231

Are we going to revert this PR?

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/ProactiveAppReviewModalManager.tsx 100.00% <ø> (ø)
src/libs/actions/User.ts 36.65% <100.00%> (ø)
src/hooks/useProactiveAppReview.ts 35.29% <0.00%> (ø)
... and 12 files with indirect coverage changes

@roryabraham

Copy link
Copy Markdown
Contributor

fixed forward instead

@roryabraham
roryabraham deleted the revert-94936-reapply-94163 branch July 16, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants