Spend-Hybrid-Tap on checkbox does not select the group by lorretheboy · Pull Request #96208 · Expensify/App

lorretheboy · 2026-07-15T19:18:14Z

Explanation of Change

Fixed Issues

$ #95369
PROPOSAL: #95369 (comment)

Tests

Preconditions:
Account that has many expenses

Open app
Tap on Search icon on top right
Enter the query: "type:expense group-by:category"
Search the query
Trigger selection mode
Tap on checkbox
Verify that User can select the group by tapping on the checkbox

Verify that no errors appear in the JS console

Offline tests

QA Steps

Preconditions:
Account that has many expenses

Open app
Tap on Search icon on top right
Enter the query: "type:expense group-by:category"
Search the query
Trigger selection mode
Tap on checkbox
Verify that User can select the group by tapping on the checkbox

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-website.mov

Android: mWeb Chrome

Screen.Recording.2026-07-15.at.14.30.01.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-website.mov

MacOS: Chrome / Safari

website.mov

melvin-bot · 2026-07-15T19:31:22Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2562ee5207

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-07-15T20:26:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...c/components/Search/SearchWriteActionsProvider.tsx	`45.67% <100.00%> (+45.67%)`	⬆️
...h/SearchList/ListItem/TransactionGroupListItem.tsx	`76.92% <75.00%> (+2.24%)`	⬆️
... and 16 files with indirect coverage changes

ZhenjaHorbach · 2026-07-20T08:13:18Z

@lorretheboy
We have lint issues

lorretheboy · 2026-07-20T12:01:40Z

@ZhenjaHorbach Pipelines are all green now

lorretheboy · 2026-07-24T12:34:16Z

@ZhenjaHorbach Friendly bump

ZhenjaHorbach · 2026-07-24T15:35:31Z

Sorry for the delay
Will check today or tomorrow!

ZhenjaHorbach · 2026-07-27T13:05:05Z

+    const isEmpty = transactions.length === 0 && groupItem.transactions.length === 0 && !groupItem.transactionsQueryJSON;

-    const isEmptyReportSelected = isEmpty && item?.keyForList && selectedTransactions[item.keyForList]?.isSelected;
+    const isEmptyReportSelected = transactions.length === 0 && isGroupSelected;


Should we use isEmpty instead transactions.length === 0 here?

I think isEmpty is intentionally false for a lazy group, while this line needs to be true in exactly that case so the checkbox stays checked before the children load. Using isEmpty here would bring back the original bug @ZhenjaHorbach

Okay then
Makes sense!

ZhenjaHorbach · 2026-07-28T08:07:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-07-28.10.33.47.mov

Android: mWeb Chrome

2026-07-28.10.44.18.mov

iOS: HybridApp

2026-07-28.10.33.47.mov

iOS: mWeb Safari

2026-07-28.10.24.49.mov

MacOS: Chrome / Safari

2026-07-28.10.23.07.mov

OSBotify · 2026-07-28T11:46:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-28T11:48:48Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-28T11:54:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96208.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1cbf7a3034f-38e8a32-713b5bcc1ccaf913d85f6bd763c3b03fbf101ca3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1cbf7a3-38e8a32-cae76280d03bbede296ef6cb99a8df1eaf3c35d6/index.html

Web 🕸️
https://96208.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-29T21:18:22Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.46-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-29T21:21:00Z

🤖 Help site review: no changes required

I reviewed the changes in this PR and no updates to the help site files under App/docs/articles are needed, so I have not created a draft docs PR.

Why: This is an internal bug fix. It restores the intended interaction — tapping a checkbox to select a group-by group in Search selection mode before the group's children have been fetched — by fixing the selection logic in TransactionGroupListItem.tsx and SearchWriteActionsProvider.tsx (plus unit tests). It does not:

Add or rename any feature, tab, setting, or button
Change any search operator (the group-by: operators in Use-Search-Operators-to-Filter-and-Analyze.md are unchanged)
Alter any user-facing workflow that the help site documents

The existing help articles already describe the expected behavior; this fix simply makes the UI match it. Checkbox/selection-mode mechanics aren't documented on the help site, and no article needs to change to reflect this fix.

If you believe a specific article should be updated regardless, let me know which one and I'll draft it.

OSBotify · 2026-07-31T07:34:02Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

lorretheboy added 2 commits July 15, 2026 13:50

Merge branch 'main' of https://github.com/Expensify/App

cab0cb0

Spend-Hybrid-Tap on checkbox does not select the group

2562ee5

melvin-bot Bot assigned lorretheboy Jul 15, 2026

lorretheboy changed the title ~~Fix/95369~~ Spend-Hybrid-Tap on checkbox does not select the group Jul 15, 2026

lorretheboy marked this pull request as ready for review July 15, 2026 19:31

lorretheboy requested review from a team as code owners July 15, 2026 19:31

melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria and removed request for a team and flaviadefaria July 15, 2026 19:31

melvin-bot Bot removed the request for review from a team July 15, 2026 19:31

chatgpt-codex-connector Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx Outdated

lorretheboy mentioned this pull request Jul 15, 2026

[Due for payment 2026-08-07] [$250] Spend-Hybrid-Tap on checkbox does not select the group #95369

Closed

2 of 7 tasks

fix: lazy load

fef6a32

lorretheboy added 2 commits July 20, 2026 18:46

Merge branch 'main' of https://github.com/Expensify/App into fix/95369

35296e0

fix: lint issues

6e1063d

lorretheboy added 2 commits July 26, 2026 22:45

Merge branch 'main' of https://github.com/Expensify/App into fix/95369

756ab65

rerun workflows

9ac154f

ZhenjaHorbach reviewed Jul 27, 2026

View reviewed changes

ZhenjaHorbach approved these changes Jul 28, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 July 28, 2026 08:45

JS00001 approved these changes Jul 28, 2026

View reviewed changes

JS00001 merged commit 1cbf7a3 into Expensify:main Jul 28, 2026
35 of 38 checks passed

OSBotify mentioned this pull request Jul 29, 2026

Deploy Checklist: New Expensify 2026-07-29 #97375

Closed

yusufdeveloper2903 mentioned this pull request Aug 28, 2026

Spend - Only "Current View" option is visible when selecting group row before expanding it. #99089

Closed

2 of 7 tasks

Conversation

lorretheboy commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jul 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach commented Jul 20, 2026

Uh oh!

lorretheboy commented Jul 20, 2026

Uh oh!

lorretheboy commented Jul 24, 2026

Uh oh!

ZhenjaHorbach commented Jul 24, 2026

Uh oh!

ZhenjaHorbach Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

lorretheboy Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

MelvinBot commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lorretheboy commented Jul 15, 2026 •

edited

Loading

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jul 28, 2026 •

edited

Loading