Skip to content

[CP staging] Fix FlashList max-update-depth crashes from OXC React Compiler bailouts #96168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 11 commits into from
Jul 15, 2026
Merged

[CP staging] Fix FlashList max-update-depth crashes from OXC React Compiler bailouts #96168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ef10c7e
fix: work around OXC React Compiler silent bailout on generic casts i…
roryabraham Jul 15, 2026
c86d3f7
fix: restore memoization dropped by SVG-memoization fix in useLazyAsset
roryabraham Jul 15, 2026
e44cf0a
fix: remove manual memoization now that OXC and Babel compile these f…
roryabraham Jul 15, 2026
dd7da8b
fix: make lazy asset hooks compile under OXC React Compiler
roryabraham Jul 15, 2026
ad5738c
fix: work around OXC generic hoisting bailouts
roryabraham Jul 15, 2026
cdaeeba
fix: hoist HOC Impls for OXC auto-memo
roryabraham Jul 15, 2026
6dc63e3
chore: seatbelt OXC Impl unsafe casts
roryabraham Jul 15, 2026
dfe7521
fix: restore worklet SM payload types + lazy asset test
roryabraham Jul 15, 2026
a40ad07
fix: dual-compile platform stack navigators
roryabraham Jul 15, 2026
783123e
fix: remount OutcomeScreen when illustration changes
roryabraham Jul 15, 2026
4cc9ef1
fix: wrap OXC-memoized SVG elements instead of blanking them
roryabraham Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions config/eslint/eslint.seatbelt.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@
"../../src/components/AnchorForAttachmentsOnly/index.tsx" "no-restricted-syntax" 1
"../../src/components/AnchorForCommentsOnly/index.tsx" "no-restricted-syntax" 1
"../../src/components/AnimatedFlatListWithCellRenderer.tsx" "@typescript-eslint/no-deprecated/Animated.createAnimatedComponent" 1
"../../src/components/AnimatedFlatListWithCellRenderer.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/AnimatedFlatListWithCellRenderer.tsx" "react-hooks/refs" 2
"../../src/components/AnimatedFlatListWithCellRenderer.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/AnimatedSubmitButton/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/AnimatedSubmitButton/index.tsx" "no-restricted-imports" 1
"../../src/components/AnimatedSubmitButton/index.tsx" "react-hooks/refs" 6
Expand All @@ -101,6 +100,7 @@
"../../src/components/Attachments/AttachmentView/index.tsx" "no-restricted-imports" 1
"../../src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/TransparentOverlay/TransparentOverlay.tsx" "no-restricted-syntax" 1
"../../src/components/AutoCompleteSuggestions/AutoCompleteSuggestionsPortal/TransparentOverlay/TransparentOverlay.tsx" "react-hooks/refs" 1
"../../src/components/AutoCompleteSuggestions/BaseAutoCompleteSuggestions.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/AutoCompleteSuggestions/index.tsx" "react-hooks/set-state-in-effect" 1
"../../src/components/AutoSubmitModal.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/Avatar.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
Expand Down Expand Up @@ -179,7 +179,7 @@
"../../src/components/FlatList/FlatList/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 4
"../../src/components/FlatList/FlatList/index.tsx" "react-hooks/refs" 1
"../../src/components/FlatList/hooks/useFlatListHandle.ts" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/FlatList/hooks/useFlatListScrollKey.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/FlatList/hooks/useFlatListScrollKey.ts" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/FloatingGPSButton/index.native.tsx" "no-restricted-imports" 1
"../../src/components/FocusModeNotification.tsx" "@typescript-eslint/no-deprecated/ConfirmModal" 1
"../../src/components/FocusTrap/FocusTrapContainerElement/index.web.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
Expand Down Expand Up @@ -322,7 +322,7 @@
"../../src/components/PDFView/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/PDFView/index.tsx" "react-hooks/set-state-in-effect" 1
"../../src/components/ParentNavigationSubtitle.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Picker/BasePicker.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/Picker/BasePicker.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/Picker/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/PlanTypeSelector.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/PopoverMenu/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
Expand Down Expand Up @@ -379,6 +379,7 @@
"../../src/components/Search/FilterComponents/DateFilterBase.tsx" "react-hooks/set-state-in-effect" 1
"../../src/components/Search/FilterComponents/DatePresetFilterBase.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/Search/FilterComponents/ReportField/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Search/FilterComponents/SingleSelect.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Search/FilterComponents/TypeSelector.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Search/FilterDropdowns/ActionButtons.tsx" "no-restricted-imports" 1
"../../src/components/Search/FilterDropdowns/CardSelectPopup.tsx" "react-hooks/set-state-in-effect" 1
Expand Down Expand Up @@ -443,13 +444,14 @@
"../../src/components/Search/index.tsx" "react-hooks/refs" 5
"../../src/components/Search/index.tsx" "react-hooks/set-state-in-effect" 1
"../../src/components/SelectionButton.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SelectionList/BaseSelectionList.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SelectionList/ListItem/BaseListItem.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SelectionList/ListItem/SpendRuleListItem.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SelectionList/ListItem/SplitListItem.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/SelectionList/SelectionListWithSections/BaseSelectionListWithSections.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SelectionList/components/Footer.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SelectionList/components/Footer.tsx" "no-restricted-imports" 1
"../../src/components/SelectionList/hooks/useFlattenedSections.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/SelectionList/hooks/useFlattenedSections.ts" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/SelectionList/utils/getListboxRole/index.web.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SettlementButton/AnimatedSettlementButton.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SettlementButton/AnimatedSettlementButton.tsx" "no-restricted-imports" 1
Expand All @@ -466,22 +468,23 @@
"../../src/components/StatePicker/StateSelectorModal.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/StatePicker/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/StatusBadge.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/SubStepForms/AddressStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/SubStepForms/AddressStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/SubStepForms/AgreementsFullStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 8
"../../src/components/SubStepForms/ConfirmationStep.tsx" "no-restricted-imports" 1
"../../src/components/SubStepForms/CountryFullStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SubStepForms/DateOfBirthStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/SubStepForms/DocusignFullStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/SubStepForms/DocusignFullStep.tsx" "no-restricted-imports" 1
"../../src/components/SubStepForms/FullNameStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 4
"../../src/components/SubStepForms/PushRowFieldsStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/SubStepForms/PushRowFieldsStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/SubStepForms/RegistrationNumberStep.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/SwipeableView/index.native.tsx" "react-hooks/refs" 2
"../../src/components/SymbolButton.tsx" "no-restricted-syntax" 1
"../../src/components/TabSelector/getBackground.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Table/Table.tsx" "@typescript-eslint/no-unsafe-type-assertion" 4
"../../src/components/Table/TableContext.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/Table/middlewares/filtering.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Tables/WorkspaceCategoryRulesTable/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Tables/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableRow.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/Tables/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableRow.tsx" "no-restricted-imports" 1
"../../src/components/Tables/WorkspaceCompanyCardsTable/index.tsx" "no-restricted-imports" 1
Expand Down Expand Up @@ -524,6 +527,7 @@
"../../src/components/Tooltip/PopoverAnchorTooltip.tsx" "react-hooks/refs" 7
"../../src/components/TransactionItemRow/DataCells/ChatBubbleCell.tsx" "rulesdir/no-useOnyx-dependencies-arg" 1
"../../src/components/TransactionItemRow/DataCells/MerchantCell.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/TransactionItemRow/EditableCell/usePopoverEditState.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/UpdateAppModal.tsx" "@typescript-eslint/no-deprecated/ConfirmModal" 1
"../../src/components/UploadFile.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx" "no-restricted-imports" 1
Expand All @@ -539,7 +543,8 @@
"../../src/components/ZeroWidthView/index.tsx" "no-restricted-syntax" 2
"../../src/components/createOnyxContext.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/components/withCurrentUserPersonalDetails.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/withNavigationFallback.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/withNavigationFallback.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/components/withNavigationTransitionEnd.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/withToggleVisibilityView.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/components/withViewportOffsetTop.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useAccountIndicatorChecks.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
Expand Down Expand Up @@ -581,6 +586,7 @@
"../../src/hooks/useHtmlPaste/index.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/hooks/useImportSpreadsheetConfirmModal.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useInitial.ts" "react-hooks/refs" 4
"../../src/hooks/useInitialSelection.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useIsBlockedToAddFeed.ts" "react-hooks/set-state-in-effect" 1
"../../src/hooks/useIsOwnWorkspaceChatRef.ts" "react-hooks/refs" 2
"../../src/hooks/useIsPaidPolicyAdmin.ts" "no-restricted-imports" 1
Expand Down Expand Up @@ -636,9 +642,9 @@
"../../src/hooks/useSingleExecution/index.native.ts" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 1
"../../src/hooks/useSingleExecution/index.native.ts" "react-hooks/refs" 1
"../../src/hooks/useSplitEffectivePolicy.ts" "rulesdir/no-useOnyx-dependencies-arg" 1
"../../src/hooks/useStepFormSubmit.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useStableIndexedHandler.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useStepFormSubmit.ts" "no-restricted-syntax" 1
"../../src/hooks/useSubPage/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useSubPage/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/hooks/useSubStep/index.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useSubStep/index.ts" "react-hooks/refs" 2
"../../src/hooks/useTackInputFocus/index.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
Expand All @@ -652,6 +658,7 @@
"../../src/hooks/useTripTransactions.ts" "rulesdir/no-useOnyx-dependencies-arg" 1
"../../src/hooks/useViolations.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/hooks/useWindowDimensions/index.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/hooks/useWorkletStateMachine/index.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/languages/flattenObject.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/libs/API/index.ts" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/libs/Accessibility/moveAccessibilityFocus/types.ts" "@typescript-eslint/no-deprecated/ElementRef" 1
Expand Down Expand Up @@ -739,6 +746,8 @@
"../../src/libs/Navigation/OnyxTabNavigator.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/libs/Navigation/PlatformStackNavigation/ScreenLayout.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/libs/Navigation/PlatformStackNavigation/createPlatformStackNavigatorComponent/ScreenFreezeWrapper/index.native.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/libs/Navigation/PlatformStackNavigation/createPlatformStackNavigatorComponent/index.native.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/libs/Navigation/PlatformStackNavigation/createPlatformStackNavigatorComponent/index.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/libs/Navigation/PlatformStackNavigation/navigationOptions/animation/withAnimation.ts" "@typescript-eslint/no-unsafe-type-assertion" 6
"../../src/libs/Navigation/guards/AIFeaturesPromoGuard.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
Expand Down Expand Up @@ -1304,7 +1313,9 @@
"../../src/pages/inbox/report/actionContents/ReimbursementQueuedContent.tsx" "rulesdir/no-useOnyx-dependencies-arg" 1
"../../src/pages/inbox/report/shouldUseEmojiPickerSelection/index.web.ts" "no-restricted-syntax" 1
"../../src/pages/inbox/report/useActiveDraftReportAction.ts" "rulesdir/no-useOnyx-dependencies-arg" 2
"../../src/pages/inbox/report/useDebouncedSaveDraft.ts" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/inbox/report/withReportAndPrivateNotesOrNotFound.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/inbox/report/withReportAndReportActionOrNotFound.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/inbox/report/withReportOrNotFound.tsx" "react-hooks/refs" 3
"../../src/pages/inbox/sidebar/FABPopoverContent/FABFocusableMenuItem.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/inbox/sidebar/FABPopoverContent/menuItems/CreateReportMenuItem.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
Expand Down Expand Up @@ -1714,6 +1725,7 @@
"../../src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx" "no-restricted-imports" 1
"../../src/pages/workspace/withPolicy.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
"../../src/pages/workspace/withPolicyAndFullscreenLoading.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/workspace/withPolicyConnections.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx" "@typescript-eslint/no-unsafe-type-assertion" 2
"../../src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx" "@typescript-eslint/no-unsafe-type-assertion" 1
"../../src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx" "@typescript-eslint/no-unsafe-type-assertion" 3
Expand Down
Loading
Loading