Keep the background expense receipt visible when a wide RHP opens by KJ21-ENG · Pull Request #96142 · Expensify/App

KJ21-ENG · 2026-07-14T22:49:13Z

Explanation of Change

MoneyRequestView hides its inline receipt while a wide RHP is open so the receipt is not duplicated next to the wide RHP's left receipt panel. That condition checked wideRHPRouteKeys.length === 0, which is global: once any wide RHP registers, every mounted MoneyRequestView hides its receipt — including instances on screens behind the RHP. After #95131, report hyperlinks can open a wide RHP over a central-pane expense view, so the background expense view loses its receipt box and its content shifts up (the regression from #95131 reported in the linked issue).

This PR scopes the condition to the view's own screen: the receipt is hidden only when the view's route.key is registered in wideRHPRouteKeys (!wideRHPRouteKeys.includes(route.key) instead of wideRHPRouteKeys.length === 0). The MoneyRequestView inside the wide RHP keeps hiding its inline receipt (the wide RHP's left panel shows it), while instances mounted on other screens — such as the central report pane behind the RHP — keep their inline receipt. The small-screen, review-duplicates, and merge-transaction short-circuits are unchanged.

A unit test (tests/ui/MoneyRequestViewReceiptTest.tsx) locks the behavior: it asserts the inline receipt stays visible on a background report screen while another screen owns the wide RHP (this assertion fails against the pre-fix global check), and that the view owning the wide RHP still hides its inline receipt.

cc @blimpich

Fixed Issues

$ #96118
PROPOSAL: #96118 (comment)

Tests

Verify that no errors appear in the JS console.
On a wide layout, go to a workspace chat and create a manual expense.
Open the expense and click Report > Remove from report.
Go to the self DM and open the (now unreported) expense so its details page shows in the central pane with the receipt box at the top.
Click the report hyperlink in the "moved this expense from …" system message. The linked report opens in the wide expense-report RHP.
Verify the expense details page in the background keeps its receipt box and does not shift up while the RHP is open, and still has it after closing the RHP.
From the Search tab, open a single-transaction expense report row (wide RHP) and click the expense to open the transaction thread in the RHP. Verify the receipt appears only once — in the RHP's left receipt panel — and the thread body does not show a duplicate inline receipt box, including during the drill-in transition. Then press the RHP back button and verify the revealed report view does not flash a duplicate inline receipt next to its left receipt panel.
From Search, open a multi-transaction report (super-wide RHP, table view) and drill into one transaction (opens a wide thread stacked on top). Verify the super-wide report table behind is unaffected — no missing/duplicated receipt and no upward content shift — and returns to normal on back.
Open the Review duplicates confirmation page and the Merge expenses confirmation page for a transaction with a receipt. Verify the receipt still renders on each (these paths force-show it), with no wide-RHP interaction removing it.
On a narrow layout, open an expense's details page and verify the inline receipt box shows as before.

Verify that no errors appear in the JS console

Offline tests

This is a render-only condition fix in MoneyRequestView; it does not alter optimistic data, queued requests, or API behavior. Offline check: with the network off, create/scan an expense so its transaction carries a pending receipt, then open a wide RHP over an unrelated report showing that pending receipt on a background screen. Verify the pending receipt stays visible on the background view with the correct grayed offline styling, and going back online settles without the receipt flashing or disappearing.

QA Steps

Verify that no errors appear in the JS console.
On a wide layout: workspace chat → create an expense → open it → Report > Remove from report → go to self DM → open the expense → click the report hyperlink in the "moved this expense from …" message.
Verify the expense details page in the background keeps its receipt box and does not move up when the report RHP opens (regression check for this issue's repro).
From Search, open an expense report and click into one of its expenses. Verify the receipt shows once in the RHP's left panel with no duplicate inline receipt in the thread view.
From Search, open a multi-transaction report (super-wide RHP) and drill into a transaction; verify the super-wide report table behind is unaffected (no missing/duplicate receipt, no content shift).
Open the Review duplicates and Merge expenses confirmation pages for a transaction with a receipt and verify the receipt still renders on each.
On a narrow layout, open an expense's details page and verify the receipt box renders as before.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-15.at.1.19.39.PM-compressed.mp4

The receipt was hidden on every MoneyRequestView whenever any wide RHP was open, so a report hyperlink opening a wide RHP over a central-pane expense view (since Expensify#95131) dropped the background receipt and shifted content up. Scope the check to the view's own route key so only the MoneyRequestView inside the wide RHP hides its inline receipt.

codecov · 2026-07-15T07:39:08Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...c/components/ReportActionItem/MoneyRequestView.tsx	`74.13% <100.00%> (+0.12%)`	⬆️
... and 71 files with indirect coverage changes

melvin-bot · 2026-07-15T07:53:57Z

@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2026-07-15T16:26:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-19.at.01.47.22.mov

Android: mWeb Chrome

Screen.Recording.2026-07-19.at.01.41.50.mov

iOS: HybridApp

Screen.Recording.2026-07-19.at.01.45.21.mov

iOS: mWeb Safari

Screen.Recording.2026-07-19.at.01.41.05.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-19.at.01.39.11.mov

joekaufmanexpensify

Good for product

github-actions · 2026-07-21T12:22:20Z

🚧 Valforte has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-21T12:27:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-21T12:28:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96142.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8b795c88999-a8a121b-adaaeeaa576ac937e519912557f83f3aab3ca421/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8b795c8-a8a121b-66cd3baaeeddf54e1df80ba9bfb62d5189c5938b/index.html

Web 🕸️
https://96142.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-22T06:31:32Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.42-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-22T06:33:33Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site articles under docs/articles.

This is a render-only UI bug fix in MoneyRequestView: it scopes the inline-receipt hide condition to the view's own screen (!wideRHPRouteKeys.includes(route.key)) so a background expense view keeps its receipt when another screen opens a wide RHP. It does not introduce or rename any feature, tab, setting, or button, and does not change any user-facing workflow that the help site documents — it only corrects an internal rendering regression (receipt disappearing / content shifting behind a wide RHP).

The only receipt-related help articles (Travel-receipt-integrations.md) cover the Travel receipt integration and are unrelated to this fix.

No draft docs PR was created.

@KJ21-ENG, since no help site changes were required, there is no linked help site PR to review. If you believe this fix does change documented behavior, let me know and I'll draft the corresponding docs update.

OSBotify · 2026-07-22T21:21:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.42-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned KJ21-ENG Jul 14, 2026

Reword test comment to satisfy CSpell (assertable)

5ea0357

KJ21-ENG marked this pull request as ready for review July 15, 2026 07:53

KJ21-ENG requested review from a team as code owners July 15, 2026 07:53

melvin-bot Bot requested a review from cretadn22 July 15, 2026 07:53

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 15, 2026 07:53

KJ21-ENG mentioned this pull request Jul 15, 2026

[Due for payment 2026-07-29] Expense - Expense details page in the background moves up after opening report RHP #96118

Closed

7 tasks

joekaufmanexpensify approved these changes Jul 15, 2026

View reviewed changes

cretadn22 approved these changes Jul 18, 2026

View reviewed changes

melvin-bot Bot requested a review from Valforte July 18, 2026 18:48

Valforte approved these changes Jul 21, 2026

View reviewed changes

Valforte merged commit 8b795c8 into Expensify:main Jul 21, 2026
38 of 41 checks passed

OSBotify mentioned this pull request Jul 22, 2026

Deploy Checklist: New Expensify 2026-07-22 #96704

Closed

49 tasks

Navigation Menu

Keep the background expense receipt visible when a wide RHP opens - #96142

Keep the background expense receipt visible when a wide RHP opens#96142
Valforte merged 2 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/96118-receipt-hidden-wide-rhp

KJ21-ENG commented Jul 14, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

cretadn22 commented Jul 15, 2026 •

edited

Loading

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

OSBotify commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

OSBotify commented Jul 22, 2026

Uh oh!

MelvinBot commented Jul 22, 2026

Uh oh!

OSBotify commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

KJ21-ENG commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

cretadn22 commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

OSBotify commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

OSBotify commented Jul 22, 2026

Uh oh!

MelvinBot commented Jul 22, 2026

Uh oh!

OSBotify commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

KJ21-ENG commented Jul 14, 2026 •

edited

Loading

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading

cretadn22 commented Jul 15, 2026 •

edited

Loading