Repository navigation
[Payment due @thelullabyy] Fix mixed group export selection - #96133
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…oup-export-643662
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc3151f5ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-29.at.02.30.29.mov |
|
Marking as draft for now, Web-E changes need to be merged again. |
|
Web-E changes are on staging, this can be reviewed now. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d294947afa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ShridharGoel Test was failed |
|
@ShridharGoel Besides, could you please re-upload the recordings. It is broken now |
…ed-group-export-643662
|
Are you able to see the screenshot now? |
|
Yes, all good now @ShridharGoel |
|
🎯 @thelullabyy, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@ShridharGoel Code LGTM, however, let's update the test steps, it is confusing now |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.46-0 🚀
|
Help site review — docs update created ✅I reviewed the changes in this PR against the help site articles under What this PR changes: it fixes mixed group export selection so a fully selected group and individually selected expenses from another group can be exported together correctly (selected expenses go through Docs impact: The Export Expenses and Reports article's "Export grouped expenses" section previously framed group selection vs. individual-expense selection as an either/or choice. That framing no longer reflects current behavior — you can now mix both. This is the only user-facing behavior that maps to existing help content; no other articles were affected (this PR is otherwise internal export-selection logic). Draft help site PR: #97386 — adds a short note documenting that mixed selections export every expense from fully selected groups plus only the specific expenses chosen from an expanded group. It follows @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #97431 was identified to be related to this PR. |
|
@ShridharGoel In offline test step 4, the export process doesn’t succeed once the user back online. Does this means after going back online, we should redo the export process again (step 2-5 in test section) or the expense should be auto exported after back online? Thank you ScreenRecording_07-30-2026.16-14-01_1.MP4 |
|
The export will need to be done again, updated the offline steps. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #97538 |
Explanation of Change
Fixes mixed group exports so the App sends collapsed groups and individually selected expenses separately.
The grouped query now contains only groups that were selected as groups. Individually selected expenses are sent through
transactionIDList, together withisGroupExport: true, so Auth can combine both selections without exporting the individual expense's full group.This depends on:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/643662
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
This is the result after selecting the full group "Benefits" and a single expense from the group "Advertising":