fix: Block raw HEIC upload when conversion fails by annaweber830 · Pull Request #96024 · Expensify/App

annaweber830 · 2026-07-14T04:49:10Z

Explanation of Change

Fixed Issues

Tests

Pre-requisite: download test.zip — a HEIC that triggers conversion failure.

Note: HEIC conversion failure is intermittent — it may take multiple attempts. When it fails, verify the error modal appears and the upload is blocked (no raw .heic is uploaded).

Go to FAB -> Create expense -> Scan.
Select the attached large HEIC image .
Verify either the conversion fails and an Attachment error modal appears with We couldn't process this image. Please try again, or upload the photo in a different format. or you will be able to create the expense if conversion succeeds (which will mean you will not see error submiting expense error from the server)
Open any chat and FAB -> add attachment
Select the HEIC img above
Verify either the conversion fails and an Attachment error modal appears with We couldn't process this image. Please try again, or upload the photo in a different format. or you will be able to add the attachment if conversion succeeds (which will mean you will not see an error from the server on the attachment)

Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

Pre-requisite: download test.zip — a HEIC that triggers conversion failure.

Note: HEIC conversion failure is intermittent — it may take multiple attempts. When it fails, verify the error modal appears and the upload is blocked (no raw .heic is uploaded).

Go to FAB -> Create expense -> Scan.
Select the attached large HEIC image .
Verify either the conversion fails and an Attachment error modal appears with We couldn't process this image. Please try again, or upload the photo in a different format. or you will be able to create the expense if conversion succeeds (which will mean you will not see error submiting expense error from the server)
Open any chat and FAB -> add attachment
Select the HEIC img above
Verify either the conversion fails and an Attachment error modal appears with We couldn't process this image. Please try again, or upload the photo in a different format. or you will be able to add the attachment if conversion succeeds (which will mean you will not see an error from the server on the attachment)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

issue-95825-fixed-compressed.mp4

Android: mWeb Chrome

expensify-recording-2-compressed.mp4

iOS: Native

Screen.Recording.2026-07-15.at.8.23.32.AM.mov

iOS: mWeb Safari

Screen_Recording_2026-07-16_at_9.06.45.PM.mp4

MacOS: Chrome / Safari

Screen_Recording_2026-07-16_at_8.27.27.PM.mp4

melvin-bot · 2026-07-14T04:49:15Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-07-14T04:52:39Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.81% <ø> (ø)`
...rc/libs/fileDownload/heicConverter/index.native.ts	`80.76% <100.00%> (+76.68%)`	⬆️
src/components/AttachmentPicker/index.native.tsx	`19.40% <0.00%> (+0.08%)`	⬆️
src/libs/fileDownload/FileUtils.ts	`37.25% <0.00%> (-0.18%)`	⬇️
src/hooks/useFilesValidation.tsx	`34.59% <0.00%> (+0.21%)`	⬆️
... and 83 files with indirect coverage changes

mountiny · 2026-07-14T13:39:40Z

@annaweber830 how is it looking?

annaweber830 · 2026-07-14T16:22:12Z

@annaweber830 how is it looking?

I am preparing PR and I will prepare today or tomorrow.

melvin-bot · 2026-07-15T04:10:04Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2026-07-15T12:30:15Z

@annaweber830 where is the case of heic upload failure in the test steps. For me when I try to upload a 15MB heic it fails which you can use in the test step.

Also record screenshots pls.

annaweber830 · 2026-07-15T14:27:34Z

Hi @FitseTLT, thanks! Could you please share a 15 MB HEIC image?

FitseTLT · 2026-07-15T14:29:37Z

Hi @FitseTLT, thanks! Could you please share a 15 MB HEIC image?

You will have to download large img and online convert it to heic on your emulators web browser that's how you can make the file available on the emulators.

annaweber830 · 2026-07-15T15:26:34Z

Hi @FitseTLT I updated PR.

FitseTLT · 2026-07-15T15:30:47Z

Ok also add android native snapshots and also update the test steps accordingly

FitseTLT · 2026-07-15T15:31:44Z

@joekaufmanexpensify @mountiny can you guys confirm the text that is displayed in the modal is? U can see the ios native snapshot in the OP for reference.

annaweber830 · 2026-07-15T16:14:58Z

Hi @FitseTLT I updated PR.

FitseTLT · 2026-07-15T16:17:11Z

Hi @FitseTLT I updated PR.

Why don't you update the test steps accordingly for the case that shows the modal? I am asking it for the third time

annaweber830 · 2026-07-15T16:22:32Z

Hi @FitseTLT Sorry I confused. I updated PR.

FitseTLT · 2026-07-15T16:24:49Z

Hi @FitseTLT Sorry I confused. I updated PR.

It would be nice if you add the exact heic img that caused the modal to appear in the steps otherwise large file can be ambigious.

joekaufmanexpensify

Good for Product

FitseTLT · 2026-07-15T17:08:22Z

@joekaufmanexpensify can you confirm the text in the modal is correct when the heic file conversion fails ?

annaweber830 · 2026-07-15T19:52:02Z

Hi @FitseTLT
I don’t think this is specifically a large-image bug. Large images may increase the chance of conversion failure, but smaller images can also fail, while large images can succeed.
The actual bug is the fallback: when conversion fails, the original HEIC is uploaded. The fix should retry once, then block the HEIC and show an error. No file-size limit is needed.

FitseTLT · 2026-07-15T20:02:12Z

Hi @FitseTLT I don’t think this is specifically a large-image bug. Large images may increase the chance of conversion failure, but smaller images can also fail, while large images can succeed. The actual bug is the fallback: when conversion fails, the original HEIC is uploaded. The fix should retry once, then block the HEIC and show an error. No file-size limit is needed.

Yeah but for me a 15 MB heic img always fails and my recommendation worked for you (I suppose you are also using a large file) What I am saying is it would be easy for the QA to give them a clear step and otherwise they can't test this case of heic conversion failure. Can u attach the img you are using for testing?

annaweber830 · 2026-07-15T20:14:43Z

Hi @FitseTLT thanks for response.
The large HEIC I tested converted successfully on my device, so it is not a reliable QA fixture. Could you please attach the 15 MB HEIC that consistently fails for you? I can use that exact file in the test steps.

annaweber830 · 2026-08-04T21:09:10Z

Hi @FitseTLT I updated test steps.

annaweber830 · 2026-08-06T04:28:51Z

Hi @FitseTLT @mountiny what should I do?

FitseTLT · 2026-08-06T14:23:11Z

@annaweber830
Pre-requisite: download test.zip — a HEIC that triggers conversion failure.

Note: HEIC conversion failure is intermittent — it may take multiple attempts. When it fails, verify the error modal appears and the upload is blocked (no raw .heic is uploaded).

Go to FAB -> Create expense -> Scan.
Select the attached large HEIC image .
Verify either the conversion fails and an Attachment error modal appears with We couldn't process this image. Please try again, or upload the photo in a different format. or you will be able to create the expense if conversion succeeds (which will mean you will not see error submiting expense error from the server)
Open any chat and FAB -> add attachment
select the HEIC img above
Verify either the conversion fails and an Attachment error modal appears with We couldn't process this image. Please try again, or upload the photo in a different format. or you will be able to add the attachment if conversion succeeds (which will mean you will not see an error from the server on the attachment)

annaweber830 · 2026-08-06T14:35:07Z

Hi @FitseTLT I udpated my PR.

FitseTLT

LGTM. Except the copy we are using looks a bit weird when a file fails for multiselecting files I pointed here Let me know your opinion on that. cc @mountiny

mountiny · 2026-08-06T20:15:48Z

That is fair, do we have a way to know it was just one/some from those uploaded that failed when showing the error?

annaweber830 · 2026-08-06T20:19:24Z

That is fair, do we have a way to know it was just one/some from those uploaded that failed when showing the error?

Hi @mountiny I'll check and see if we can identify which of the uploaded files failed when the error is shown.

FitseTLT · 2026-08-06T20:30:45Z

That is fair, do we have a way to know it was just one/some from those uploaded that failed when showing the error?

It is a gap in the current main that it displays error modals then it will navigate you to the next page if there are successful files. So it is not a gap our pr introduced but I only have a doubt that our error text is a bit misleading. I want to know your direction on that @mountiny
Or we can optionally extend the scope here and fix the existing problem too

annaweber830 · 2026-08-06T20:42:12Z

That is fair, do we have a way to know it was just one/some from those uploaded that failed when showing the error?

Yes, we can. The conversion callback knows which file failed; we just need to pass that filename into the error state and display it in the modal.

FitseTLT · 2026-08-06T20:53:27Z

That is fair, do we have a way to know it was just one/some from those uploaded that failed when showing the error?

Yes, we can. The conversion callback knows which file failed; we just need to pass that filename into the error state and display it in the modal.

btw there can be multiple files failing and also the other error copies also can be displayed which have the same problems. But at least we can make our error text to not seem like there is only one img failing by making it more general.

mountiny

I think we can handle that separately

OSBotify · 2026-08-07T18:32:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-07T18:49:43Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-08-07T18:55:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96024.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ec69ea65b8e-7e8bfd0-c7a16bab45f5cc55513f6c37f194e9365cc92357/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ec69ea6-7e8bfd0-6d73d14aa9efa1b241912a03403c475761feb4e2/index.html

Web 🕸️
https://96024.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-10T22:06:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-08-10T22:09:20Z

🤖 I reviewed this PR against Expensify's help site files under App/docs/articles and no docs updates are required, so I did not open a draft PR.

Why: This is an internal error-handling fix. When a HEIC image fails to convert, the app now blocks the raw .heic upload and shows an error modal (We couldn't process this image. Please try again, or upload the photo in a different format.) instead of silently falling back to uploading the unconverted file. It doesn't add, remove, or change any user-facing feature, workflow, or setting that the help site describes.

What I checked

Searched docs/articles for heic/heif → no matches. HEIC/HEIF conversion behavior is not documented anywhere on the help site.
Reviewed the two articles that document upload formats and image guidance:
- Create-an-Expense.md lists supported file formats (JPG, PNG, GIF, PDF, TIFF, HTML, RTF, DOCX, XML) — HEIC is not listed, and this PR doesn't change that list.
- Troubleshoot-SmartScan-Issues.md mentions common image formats (JPG, PNG) and PDF for best results — unchanged by this PR.
The only user-facing addition is a new error string (errorWhileConvertingHeic) shown on conversion failure, which is transient UI copy, not documented help-site behavior.

Since HEIC support is not a documented feature and the change is limited to failure-path error handling, there is no help-site content that becomes inaccurate as a result of this PR.

If you'd still like a proactive doc note added (e.g. calling out image-format guidance for receipt uploads), let me know and I'll draft one.

IuliiaHerets · 2026-08-11T19:54:56Z

Hi @annaweber830. QA team failed this PR for iOS with the original issue; the HEIC image was uploaded without a modal error being shown

1786460263363.GALLERY.mp4

cc @mountiny @joekaufmanexpensify @carlosmiceli

FitseTLT · 2026-08-11T20:12:17Z

Hi @annaweber830. QA team failed this PR for iOS with the original issue; the HEIC image was uploaded without a modal error being shown

1786460263363.GALLERY.mp4
cc @mountiny @joekaufmanexpensify @carlosmiceli

Nope @IuliiaHerets we clearly stated on the steps that the failing only happens intermittently and if it doesn't fail it should create a successful expense. that's the change 👍

OSBotify · 2026-08-12T18:15:55Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

fix: Block raw HEIC upload when conversion fails

b27cb74

melvin-bot Bot assigned annaweber830 Jul 14, 2026

annaweber830 marked this pull request as ready for review July 15, 2026 04:09

annaweber830 requested review from a team as code owners July 15, 2026 04:09

melvin-bot Bot requested review from FitseTLT and joekaufmanexpensify and removed request for a team July 15, 2026 04:10

melvin-bot Bot removed the request for review from a team July 15, 2026 04:10

github-actions Bot reviewed Jul 15, 2026

View reviewed changes

Comment thread src/hooks/useFilesValidation.tsx

joekaufmanexpensify previously approved these changes Jul 15, 2026

View reviewed changes

FitseTLT approved these changes Aug 6, 2026

View reviewed changes

melvin-bot Bot requested a review from carlosmiceli August 6, 2026 15:12

mountiny approved these changes Aug 7, 2026

View reviewed changes

mountiny closed this Aug 7, 2026

mountiny reopened this Aug 7, 2026

mountiny merged commit ec69ea6 into Expensify:main Aug 7, 2026
47 checks passed

OSBotify mentioned this pull request Aug 10, 2026

Deploy Checklist: New Expensify 2026-08-10 #98179

Closed

quinthar added the #quality label Aug 11, 2026

melvin-bot Bot mentioned this pull request Aug 12, 2026

[Due for payment 2026-08-19] [$250] iOS/Android - HEIC conversion failure falls back to raw HEIC upload, causing receipt upload failure #95825

Closed

7 tasks

This was referenced Aug 18, 2026

Fix - heic context lost #85231

Merged

[Due for payment 2026-03-30] "Calling the register Async. Function has failed caused by image context has been lost.” when attempting to take a photo of receipt from in app or via Safari Website. #81702

Closed

MelvinBot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-23] iOS - Scan - HEIF images from iPhone fail to upload intermittently (HEIC→JPEG conversion failure) #100133

Open

7 tasks

chrispader mentioned this pull request Sep 9, 2026

fix: show the correct error for folder attachments #100706

Merged

40 tasks

Conversation

annaweber830 commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 14, 2026

Uh oh!

codecov Bot commented Jul 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annaweber830 commented Jul 14, 2026

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

annaweber830 commented Jul 15, 2026

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

annaweber830 commented Jul 15, 2026

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

annaweber830 commented Jul 15, 2026

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

annaweber830 commented Jul 15, 2026

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

annaweber830 commented Jul 15, 2026

Uh oh!

FitseTLT commented Jul 15, 2026

Uh oh!

annaweber830 commented Jul 15, 2026

Uh oh!

annaweber830 commented Aug 4, 2026

Uh oh!

annaweber830 commented Aug 6, 2026

Uh oh!

FitseTLT commented Aug 6, 2026

Uh oh!

annaweber830 commented Aug 6, 2026

Uh oh!

FitseTLT left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Aug 6, 2026

Uh oh!

annaweber830 commented Aug 6, 2026

Uh oh!

FitseTLT commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annaweber830 commented Aug 6, 2026

Uh oh!

FitseTLT commented Aug 6, 2026

Uh oh!

mountiny left a comment

annaweber830 commented Jul 14, 2026 •

edited

Loading

codecov Bot commented Jul 14, 2026 •

edited by github-actions Bot

Loading

mountiny commented Jul 14, 2026 •

edited

Loading

FitseTLT left a comment •

edited

Loading

FitseTLT commented Aug 6, 2026 •

edited

Loading