Skip to content

[No QA] fix: run rsbuild dev server with Node instead of Bun - #96023

Merged
roryabraham merged 1 commit into
mainfrom
rory-rsbuild-dev-server-node
Jul 14, 2026
Merged

roryabraham merged 1 commit into
mainfrom
rory-rsbuild-dev-server-node

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Explanation of Change

Reverts the web-server script to run Rsbuild's dev server under Node instead of Bun. PR #95890 switched it to Bun, but Bun's node:http2 implementation throws when http-proxy-middleware reads req.socket?.server on the HTTPS dev server (used when server.https and server.proxy are both enabled). That crashes npm run web for devs with the web proxy enabled (the default when USE_WEB_PROXY is not set to false).

Bun remains in use for web-proxy, production/staging/adhoc builds, and other scripts — only the long-running Rsbuild dev server moves back to Node.

Fixed Issues

$
PROPOSAL:

Tests

  1. Ensure USE_WEB_PROXY is not set to false in .env (or unset it).
  2. Run npm run web-proxy in one terminal and confirm it listens on port 9000.
  3. Run npm run web-server in another terminal and wait for ready built.
  4. Open https://dev.new.expensify.com:8082/ and confirm the app loads.
  5. Confirm a proxied API request succeeds (e.g. sign in or check the network tab for /api/ calls returning 200).
  6. Confirm the dev server process stays running and does not exit with a Bun crash.
  • Verify that no errors appear in the JS console

Offline tests

N/A — dev-server startup tooling only; no app runtime or offline behavior changes.

QA Steps

N/A — [No QA] tooling change; no app-facing behavior change.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — no UI change.

Bun's node:http2 implementation throws when http-proxy-middleware reads
req.socket.server on the HTTPS dev server, crashing npm run web for devs
with USE_WEB_PROXY enabled.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham
roryabraham requested a review from a team as a code owner July 14, 2026 04:11
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@melvin-bot
melvin-bot Bot requested review from pecanoro and removed request for a team July 14, 2026 04:11
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chuckdries chuckdries left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch

@roryabraham
roryabraham merged commit 0b1e74f into main Jul 14, 2026
50 checks passed
@roryabraham
roryabraham deleted the rory-rsbuild-dev-server-node branch July 14, 2026 04:24
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants