Skip to content

[No QA] fix(rsbuild): lazy-import Sentry plugin to silence webpack deprecation warnings - #96021

Merged
chuckdries merged 1 commit into
mainfrom
rory-lazy-import-sentry-webpack-plugin
Jul 14, 2026
Merged

[No QA] fix(rsbuild): lazy-import Sentry plugin to silence webpack deprecation warnings#96021
chuckdries merged 1 commit into
mainfrom
rory-lazy-import-sentry-webpack-plugin

Conversation

@roryabraham

@roryabraham roryabraham commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

@sentry/webpack-plugin was statically imported in rsbuild.common.ts, so it loaded during local npm run web even though the Sentry plugin is only used for production/staging builds. Under Bun, that plugin's import * as webpack from "webpack" touches webpack 5.108's deprecated compat exports and prints four DEP_WEBPACK_* warnings on every dev server start. These are harmless but noisy

This change dynamically imports @sentry/webpack-plugin only for non-development builds and makes getCommonConfiguration async so the import stays ESM.

Fixed Issues

$

Tests

  1. Run npm run web from the App repo root.
  2. Confirm the Rsbuild startup output no longer includes DEP_WEBPACK_JAVASCRIPT_MODULES_PLUGIN, DEP_WEBPACK_LIBRARY_TEMPLATE_PLUGIN, DEP_WEBPACK_SINGLE_ENTRY_PLUGIN, or DEP_WEBPACK_OPTIONS_DEFAULTER warnings.
  3. Confirm the dev server starts and the app loads at https://dev.new.expensify.com:8082/.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

@roryabraham @cursoragent
fix(rsbuild): lazy-import Sentry plugin in dev config
a1f98c1 
Avoid loading @sentry/webpack-plugin during local web dev so Bun does not
trigger webpack 5.108 deprecation warnings from the plugin's namespace
import of webpack.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham
roryabraham requested a review from a team as a code owner July 14, 2026 03:51
@melvin-bot
melvin-bot Bot requested a review from tylerkaraszewski July 14, 2026 03:52
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 14, 2026 03:52
@roryabraham
roryabraham requested a review from chuckdries July 14, 2026 03:52
@chuckdries
chuckdries merged commit 78116cd into main Jul 14, 2026
43 checks passed
@chuckdries
chuckdries deleted the rory-lazy-import-sentry-webpack-plugin branch July 14, 2026 04:06
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96021.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-78116cd1b74-7dfffa0-64dc10bfeaafe96c28f24daa134b26521388c9f8/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-78116cd-7dfffa0-7eecb49f9a62d8eb6e0d721e0fafc19b2bd0b5bb/index.html
Android iOS
Web 🕸️
https://96021.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Jul 14, 2026
Closed
@OSBotify

OSBotify commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.4.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chuckdries chuckdries chuckdries approved these changes
@tylerkaraszewski tylerkaraszewski Awaiting requested review from tylerkaraszewski

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roryabraham @OSBotify @chuckdries