Skip to content

[No QA] Fix ExportOnyxStateTest: bucket areAgentsLoaded and arePolicyRoomsLoaded keys - #96007

Merged
roryabraham merged 1 commit into
mainfrom
fix-onyx-export-agents-rooms-keys
Jul 13, 2026
Merged

roryabraham merged 1 commit into
mainfrom
fix-onyx-export-agents-rooms-keys

Conversation

@jasperhuangg

Copy link
Copy Markdown
Contributor

Explanation of Change

tests/unit/ExportOnyxStateTest.ts is failing on main. The test requires every ONYXKEYS value to sit in exactly one export bucket, and two keys were added without being placed in one:

  • areAgentsLoaded (ARE_AGENTS_LOADED)
  • arePolicyRoomsLoaded (ARE_POLICY_ROOMS_LOADED)

They came in with App #95809 but were never added to a bucket, so uncoveredTopLevel is non-empty and the suite goes red for every PR.

What changed:

  • Add both keys to safeOnyxKeys in src/libs/ExportOnyxState/common.ts, next to the other loading flags (IS_LOADING_APP, etc.). They're plain loading booleans with no PII, so they're safe to export.
  • Placed alphabetically by key name (after ACTIVE_CLIENTS, before BETAS) to satisfy the bucket-ordering test.

Fixed Issues

$ Fixes the red ExportOnyxStateTest on main introduced by #95809

Tests

  1. Run npx jest tests/unit/ExportOnyxStateTest.ts.
  2. Verify all cases pass, including "every ONYXKEYS value must be in one of the four buckets" and "safeOnyxKeys should list its keys alphabetically".
  • Verify that no errors appear in the JS console

Offline tests

N/A - unit-test-only fix.

QA Steps

N/A - unit-test-only fix, no user-facing behavior change.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
  • I verified there are no console errors
  • I followed the guidelines as stated in the Review Guidelines

Screenshots/Videos

MacOS: Chrome / Safari

N/A - unit-test-only fix.

@jasperhuangg
jasperhuangg requested review from a team as code owners July 13, 2026 23:25
@melvin-bot
melvin-bot Bot requested review from heyjennahay and mjasikowski and removed request for a team July 13, 2026 23:25
@melvin-bot

melvin-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 13, 2026 23:25
@roryabraham roryabraham changed the title Fix ExportOnyxStateTest: bucket areAgentsLoaded and arePolicyRoomsLoaded keys [No QA] Fix ExportOnyxStateTest: bucket areAgentsLoaded and arePolicyRoomsLoaded keys Jul 13, 2026
@roryabraham
roryabraham merged commit a076c27 into main Jul 13, 2026
43 of 45 checks passed
@roryabraham
roryabraham deleted the fix-onyx-export-agents-rooms-keys branch July 13, 2026 23:44
@github-actions

Copy link
Copy Markdown
Contributor

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR and no help site changes are required under App/docs/articles, so I did not create a draft docs PR.

Why: This is a unit-test-only fix. It adds two internal Onyx keys (ARE_AGENTS_LOADED / areAgentsLoaded and ARE_POLICY_ROOMS_LOADED / arePolicyRoomsLoaded) to the safeOnyxKeys export bucket in src/libs/ExportOnyxState/common.ts so ExportOnyxStateTest passes on main. There is no user-facing behavior, UI, feature, tab, setting, or workflow change — nothing that any customer-facing help article documents. The PR itself notes N/A for QA steps and no behavior change.

Since there are no docs to update, there is nothing for you to review on the docs side.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants