You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tests/unit/ExportOnyxStateTest.ts is failing on main. The test requires every ONYXKEYS value to sit in exactly one export bucket, and two keys were added without being placed in one:
areAgentsLoaded (ARE_AGENTS_LOADED)
arePolicyRoomsLoaded (ARE_POLICY_ROOMS_LOADED)
They came in with App #95809 but were never added to a bucket, so uncoveredTopLevel is non-empty and the suite goes red for every PR.
What changed:
Add both keys to safeOnyxKeys in src/libs/ExportOnyxState/common.ts, next to the other loading flags (IS_LOADING_APP, etc.). They're plain loading booleans with no PII, so they're safe to export.
Placed alphabetically by key name (after ACTIVE_CLIENTS, before BETAS) to satisfy the bucket-ordering test.
Fixed Issues
$ Fixes the red ExportOnyxStateTest on main introduced by #95809
Tests
Run npx jest tests/unit/ExportOnyxStateTest.ts.
Verify all cases pass, including "every ONYXKEYS value must be in one of the four buckets" and "safeOnyxKeys should list its keys alphabetically".
Verify that no errors appear in the JS console
Offline tests
N/A - unit-test-only fix.
QA Steps
N/A - unit-test-only fix, no user-facing behavior change.
Verify that no errors appear in the JS console
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I verified there are no console errors
I followed the guidelines as stated in the Review Guidelines
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
🤖 I reviewed the changes in this PR and no help site changes are required under App/docs/articles, so I did not create a draft docs PR.
Why: This is a unit-test-only fix. It adds two internal Onyx keys (ARE_AGENTS_LOADED / areAgentsLoaded and ARE_POLICY_ROOMS_LOADED / arePolicyRoomsLoaded) to the safeOnyxKeys export bucket in src/libs/ExportOnyxState/common.ts so ExportOnyxStateTest passes on main. There is no user-facing behavior, UI, feature, tab, setting, or workflow change — nothing that any customer-facing help article documents. The PR itself notes N/A for QA steps and no behavior change.
Since there are no docs to update, there is nothing for you to review on the docs side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
tests/unit/ExportOnyxStateTest.tsis failing on main. The test requires every ONYXKEYS value to sit in exactly one export bucket, and two keys were added without being placed in one:areAgentsLoaded(ARE_AGENTS_LOADED)arePolicyRoomsLoaded(ARE_POLICY_ROOMS_LOADED)They came in with App #95809 but were never added to a bucket, so
uncoveredTopLevelis non-empty and the suite goes red for every PR.What changed:
safeOnyxKeysinsrc/libs/ExportOnyxState/common.ts, next to the other loading flags (IS_LOADING_APP, etc.). They're plain loading booleans with no PII, so they're safe to export.ACTIVE_CLIENTS, beforeBETAS) to satisfy the bucket-ordering test.Fixed Issues
$ Fixes the red
ExportOnyxStateTeston main introduced by #95809Tests
npx jest tests/unit/ExportOnyxStateTest.ts.Offline tests
N/A - unit-test-only fix.
QA Steps
N/A - unit-test-only fix, no user-facing behavior change.
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
MacOS: Chrome / Safari
N/A - unit-test-only fix.