Repository navigation
[Payment due @brunovjk] Add Consolidated Travel Billing press release to Home tab Announcements - #95998
Conversation
|
🤖 I looked into the failing check — there's nothing to fix in the code, so I have no changes to push. The only failing check is
This isn't a code problem — it fails because the Every actual code check passes: typecheck ✅, all 8 To get this green: fill out the |
|
🤖 I fixed the structural cause of the What was wrong: When I created this PR, the What I did: I restored the full canonical PR Author Checklist to the PR description (your existing content, Tests, and QA Steps are untouched). What's left for you ( Everything else passes: typecheck ✅, all |
|
🤖 Re-checked the PR — all checks are now passing, so there's nothing to fix or push. The previously-failing |
|
🤖 All checks are green now — there's nothing failing to fix. The No push needed. ✅ |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
brunovjk
left a comment
There was a problem hiding this comment.
Should we add [NO A] to the title? Thanks.
|
🎯 @brunovjk, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@brunovjk I have QA steps up top! |
|
@MelvinBot can you resolve the conflicts? Thanks. |
|
Hi I can only make code changes when directed by the PR author, an assignee, or an existing co-author. This PR was opened by To have me resolve them, |
@jamesdeanexpensify could you ask Melvin to resolve the conflicts here? What else is needed to merge this PR? Thanks a lot. |
|
@MelvinBot can you please resolve the conflicts here? |
|
@brunovjk sorry, I'm not an engineer, nor on the bug zero team. I'm not sure what else remains. Maybe @flaviadefaria knows? Thanks! |
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Resolved the conflict and pushed the merge — the PR is no longer conflicting. ✅ The conflict was in
The two trailing entries were identical on both sides. To honor the 3-item cap while keeping this PR's new entry and
Since Please re-run/re-review as needed — and if you'd rather keep a different set of three announcements, let me know and I'll adjust. |
|
The only failing check ( Failure: Why it's unrelated: this PR only edits the static Recommended action: re-run the failed job — it should pass on retry. I attempted the re-run but it requires interactive approval I can't grant from here, so an assignee will need to click Re-run failed jobs on the run (or push any trivial update to retrigger). No code fix is warranted. |
|
Looks like we're all good now, can I go ahead and merge it? |
Yes :D |
|
🚧 flaviadefaria has triggered a test Expensify/App build. You can view the workflow run here. |
|
@flaviadefaria looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
I removed the |
|
Should I re-run the failed test? |
|
Great. I'm not sure, but I don't think so—let me double-check with someone on Slack. |
|
Asked here. |
|
🚀 Deployed to staging by https://github.com/flaviadefaria in version: 9.4.46-0 🚀
|
No help site changes requiredI reviewed this PR against the help site files under Why: This PR only swaps one entry in the Home tab's The only article that covers this section, Expensify Home Overview, describes the Announcements section generically — "shows recent Expensify product updates" — and does not list the individual press releases or newsletter links. Since the specific announcement entries aren't documented, adding or rotating one doesn't change anything the help site describes. No feature names, tabs, settings labels, or workflows were changed by this PR, so there's nothing to reconcile against the live UI. @jamesdeanexpensify, if you'd still like a docs PR (e.g. if the intent is to start listing individual announcements on the help site), let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #97534 |


Explanation of Change
Adds the newly-published Consolidated Travel Billing press release to the
Announcementssection of the Home tab (CONST.HOME.ANNOUNCEMENTSinsrc/CONST/index.ts).The
Announcementssection is capped at three items, so per the request the oldest entry (the2026-06-24"AI agents, Concierge upgrades, and smarter card controls" product update) was removed. The section still renders exactly three items, and sinceAnnouncementSectionsorts bypublishedDatedescending, the new2026-07-13press release appears at the top.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/658501
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari