Skip to content

[Payment due @brunovjk] Add Consolidated Travel Billing press release to Home tab Announcements - #95998

Merged
flaviadefaria merged 3 commits into
mainfrom
claude-addTravelBillingAnnouncement
Jul 28, 2026
Merged

flaviadefaria merged 3 commits into
mainfrom
claude-addTravelBillingAnnouncement

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds the newly-published Consolidated Travel Billing press release to the Announcements section of the Home tab (CONST.HOME.ANNOUNCEMENTS in src/CONST/index.ts).

The Announcements section is capped at three items, so per the request the oldest entry (the 2026-06-24 "AI agents, Concierge upgrades, and smarter card controls" product update) was removed. The section still renders exactly three items, and since AnnouncementSection sorts by publishedDate descending, the new 2026-07-13 press release appears at the top.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/658501
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. In New Expensify, click the Home tab and look at the Announcements section.
  2. Verify that there are three line items present, and the announcement from this PR is at the top
  3. Click on the announcement from this PR to ensure it takes you to the press release
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot
MelvinBot requested a review from a team July 13, 2026 20:02
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I looked into the failing check — there's nothing to fix in the code, so I have no changes to push.

The only failing check is PR Author Checklist / checklist, which fails because:

PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

This isn't a code problem — it fails because the ### Tests and ### QA Steps sections still contain the // TODO: placeholders and the checklist boxes are unchecked. That's intentionally a human co-author task: the checklist and Tests/QA sections must be filled out by a person before the PR is marked "Ready for review" — I can't complete them on your behalf.

Every actual code check passes: typecheck ✅, all 8 test jobs ✅, ESLint ✅, Oxfmt ✅, Bun tests ✅, Storybook ✅, all builds ✅. (baseline-perf-tests / branch-perf-tests were still running at the time of writing — they're benchmark comparisons, not affected by this data-only change.)

To get this green: fill out the ### Tests and ### QA Steps sections and check the boxes in the PR description, then re-run the checklist job.

@jamesdeanexpensify
jamesdeanexpensify marked this pull request as ready for review July 13, 2026 20:33
@jamesdeanexpensify
jamesdeanexpensify requested a review from a team as a code owner July 13, 2026 20:33
@melvin-bot
melvin-bot Bot requested review from brunovjk and removed request for a team July 13, 2026 20:33
@melvin-bot

melvin-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team July 13, 2026 20:33
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I fixed the structural cause of the checklist failure, but it needs one final step from you that only a human can do.

What was wrong: When I created this PR, the ### PR Author Checklist section in the description was truncated to a single item. The authorChecklist validator compares the description against the canonical PR template (38 items) and requires all but ≤2 checked and zero unchecked. With only 1 item present it reported "1 out of 38 checklist items."

What I did: I restored the full canonical PR Author Checklist to the PR description (your existing content, Tests, and QA Steps are untouched).

What's left for you (jamesdeanexpensify): the check is still red because the boxes are unchecked — "1 out of 38, 37 unfinished." I deliberately did not tick them: most are attestations (tested on all platforms, included screenshots, ran against a High Traffic account, etc.) that I can't truthfully check on your behalf. Please review the checklist in the description and check every box that applies before marking the PR "Ready for review", and it will go green.

Everything else passes: typecheck ✅, all test jobs ✅, ESLint ✅, Oxfmt ✅, Bun ✅, Storybook ✅, builds ✅, actionlint ✅, validateSchemas ✅, perf ✅. The checklist job is the only remaining red, and it's purely the author checklist.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Re-checked the PR — all checks are now passing, so there's nothing to fix or push.

The previously-failing PR Author Checklist / checklist is now green (the checklist has since been filled out), and every other check — typecheck, all 8 test jobs, ESLint, Oxfmt, Bun, Storybook, baseline-perf-tests / branch-perf-tests, builds, and validateSchemas — passes as well. ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 All checks are green now — there's nothing failing to fix.

The PR Author Checklist / checklist (the only check that was previously failing) now passes — it went green once the author checklist boxes and Tests/QA sections were filled out. Every other check (typecheck, all 8 test jobs, ESLint, Oxfmt, Bun, Storybook, perf tests, builds) is also passing.

No push needed. ✅

@brunovjk

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Screenshot 2026-07-14 at 15 08 29
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-07-14 at 15 06 33

@brunovjk brunovjk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add [NO A] to the title? Thanks.

@melvin-bot melvin-bot Bot changed the title Add Consolidated Travel Billing press release to Home tab Announcements [Payment due @brunovjk] Add Consolidated Travel Billing press release to Home tab Announcements Jul 14, 2026
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🎯 @brunovjk, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/658501.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@brunovjk I have QA steps up top!

@brunovjk

Copy link
Copy Markdown
Contributor

@MelvinBot can you resolve the conflicts? Thanks.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Hi brunovjk — this branch does currently have merge conflicts with main (it's in a CONFLICTING / dirty state), so they do need resolving before this can merge.

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. This PR was opened by MelvinBot with jamesdeanexpensify as the assignee/co-author, and you're the reviewer here rather than one of those — so I can't push the conflict resolution on this request alone.

To have me resolve them, jamesdeanexpensify (assignee/co-author) should reply tagging me with the request, and I'll take care of it.

@brunovjk

Copy link
Copy Markdown
Contributor

Hi brunovjk — this branch does currently have merge conflicts with main (it's in a CONFLICTING / dirty state), so they do need resolving before this can merge.

I can only make code changes when directed by the PR author, an assignee, or an existing co-author. This PR was opened by MelvinBot with jamesdeanexpensify as the assignee/co-author, and you're the reviewer here rather than one of those — so I can't push the conflict resolution on this request alone.

To have me resolve them, jamesdeanexpensify (assignee/co-author) should reply tagging me with the request, and I'll take care of it.

@jamesdeanexpensify could you ask Melvin to resolve the conflicts here? What else is needed to merge this PR? Thanks a lot.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@MelvinBot can you please resolve the conflicts here?

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@brunovjk sorry, I'm not an engineer, nor on the bug zero team. I'm not sure what else remains. Maybe @flaviadefaria knows? Thanks!

@MelvinBot
MelvinBot requested a review from a team as a code owner July 24, 2026 15:51
@melvin-bot
melvin-bot Bot requested a review from abzokhattab July 24, 2026 15:51
@melvin-bot

melvin-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 24, 2026 15:51
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Resolved the conflict and pushed the merge — the PR is no longer conflicting. ✅

The conflict was in src/CONST/index.ts CONST.HOME.ANNOUNCEMENTS. Both branches added a new announcement to the top of the 3-item-capped list and both had already dropped the old 2026-06-24 entry:

  • This PR: New feature: Consolidated travel billing (2026-07-13)
  • main: The Expensify Card: Now in the UK & EU (2026-07-20)

The two trailing entries were identical on both sides. To honor the 3-item cap while keeping this PR's new entry and main's newer one, I kept the three most recent by publishedDate and dropped the oldest (Ask Concierge AI: charts, insights & more, 2026-06-30). Final list:

  1. The Expensify Card: Now in the UK & EU — 2026-07-20
  2. New feature: Consolidated travel billing — 2026-07-13
  3. More Concierge AI upgrades, plus agent beta — 2026-07-01

Since AnnouncementSection sorts by publishedDate descending, the display order matches the array order above.

Please re-run/re-review as needed — and if you'd rather keep a different set of three announcements, let me know and I'll adjust.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check (test (job 7)) is unrelated to this PR — it's a flaky test timeout, not a real failure.

Failure: tests/ui/GroupChatNameTests.tsx › "Check if group name shows fine for report header" hit Exceeded timeout of 120000 ms (the suite ran 345s). Jest also logged "A worker process has failed to exit gracefully and has been force exited" — classic signs of an infra/leak-induced timeout rather than an assertion failure. Everything else in the shard passed (2064 passed, 1 timed out).

Why it's unrelated: this PR only edits the static CONST.HOME.ANNOUNCEMENTS array in src/CONST/index.ts (add one press-release entry, drop the oldest). It touches no code exercised by the group-chat report-header naming test.

Recommended action: re-run the failed job — it should pass on retry. I attempted the re-run but it requires interactive approval I can't grant from here, so an assignee will need to click Re-run failed jobs on the run (or push any trivial update to retrigger). No code fix is warranted.

@flaviadefaria

Copy link
Copy Markdown
Contributor

Looks like we're all good now, can I go ahead and merge it?

@brunovjk

Copy link
Copy Markdown
Contributor

Looks like we're all good now, can I go ahead and merge it?

Yes :D

@flaviadefaria
flaviadefaria merged commit 180382b into main Jul 28, 2026
39 of 40 checks passed
@flaviadefaria
flaviadefaria deleted the claude-addTravelBillingAnnouncement branch July 28, 2026 14:29
@github-actions

Copy link
Copy Markdown
Contributor

🚧 flaviadefaria has triggered a test Expensify/App build. You can view the workflow run here.

@melvin-bot melvin-bot Bot added the Emergency label Jul 28, 2026
@melvin-bot

melvin-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

@flaviadefaria looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@flaviadefaria

Copy link
Copy Markdown
Contributor

I removed the Emergency label as it said the failure was unrelated to this PR. All looks good on the adhoc build. @brunovjk, anything else I need to do here?

@flaviadefaria

Copy link
Copy Markdown
Contributor

Should I re-run the failed test?

@brunovjk

Copy link
Copy Markdown
Contributor

Great. I'm not sure, but I don't think so—let me double-check with someone on Slack.

@brunovjk

Copy link
Copy Markdown
Contributor

Asked here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/flaviadefaria in version: 9.4.46-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site changes required

I reviewed this PR against the help site files under docs/articles. No documentation changes are needed, so I did not open a draft docs PR.

Why: This PR only swaps one entry in the Home tab's Announcements list — it adds the Consolidated travel billing press release link and removes the older Ask Concierge AI newsletter link (src/CONST/index.ts).

The only article that covers this section, Expensify Home Overview, describes the Announcements section generically — "shows recent Expensify product updates" — and does not list the individual press releases or newsletter links. Since the specific announcement entries aren't documented, adding or rotating one doesn't change anything the help site describes.

No feature names, tabs, settings labels, or workflows were changed by this PR, so there's nothing to reconcile against the live UI.

@jamesdeanexpensify, if you'd still like a docs PR (e.g. if the intent is to start listing individual announcements on the help site), let me know and I'll draft one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #97534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants