Remove getPersonalDetailsByIDs usage from OptionsListUtils by bernhardoj · Pull Request #95888 · Expensify/App

bernhardoj · 2026-07-11T07:54:59Z

Explanation of Change

Fixed Issues

$ #66391
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open a workspace chat
Mention a nonexistent user email (e.g., @unexistingperson@gmail.com)
Go to Account > Troubleshoot > Clear cache and restart
Go offline
Re-open the chat
Verify that the last message of the LHN of the workspace chat shows @hidden and the mention also shows @hidden

(You can use Inspect element to see the text in case the subtitle is too long)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-07-11T07:55:05Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-07-11T08:03:43Z

-    // When the last report action has unknown mentions (@Hidden), we want to consistently show @Hidden in LHN and report screen
-    // so we reconstruct the last message text of the report from the last report action.
-    if (!lastMessageTextFromReport && lastReportAction && hasHiddenDisplayNames(getMentionedAccountIDsFromAction(lastReportAction), translate)) {
-        lastMessageTextFromReport = Parser.htmlToText(getReportActionHtml(lastReportAction));


This was added by this PR: #59551

It's to fix an issue where the last message of the LHN shows the mentioned email, but the report action message shows Hidden.

This is because for the report action message, we render the message.html, which is a mention tag with an accountID attribute. And because after we do "Clear cache & restart", the personal details for that accountID is not available yet.

But for the LHN last message, we render the report.lastMessageText, which is plain text. But that's not the case anymore. Now, we first get the message from the last action html by parsing the html.

App/src/libs/OptionsListUtils/index.ts

Lines 1086 to 1089 in e6cc804

// Fallback: use the action's own message text if not handled above.

if (!lastMessageTextFromReport && lastReportAction) {

lastMessageTextFromReport = lastVisibleMessage?.lastMessageText ?? '';

}

getLastVisibleMessage

App/src/libs/ReportActionsUtils.ts

Line 1530 in e6cc804

let messageText = getReportActionMessageText(lastVisibleAction) ?? '';

App/src/libs/ReportActionsUtils.ts

Line 2598 in e6cc804

return reportAction?.message?.reduce((acc, curr) => `${acc}${getTextFromHtml(curr?.html || curr?.text)}`, '') ?? '';

App/src/libs/ReportActionsUtils.ts

Lines 2104 to 2106 in e6cc804

function getTextFromHtml(html?: string): string {

return html ? Parser.htmlToText(html) : '';

}

The problem is that the accountIDToNameMap keeps the removed personal details. So, when we do Clear cache & restart, all personal details are removed, but accountIDToNameMap keeps it. That causes the inconsistency.

App/src/libs/Parser.ts

Lines 61 to 64 in e6cc804

htmlToText(htmlString: string, extras?: Extras): string {

return super.htmlToText(htmlString, {

reportIDToName: extras?.reportIDToName ?? reportIDToNameMap,

accountIDToName: extras?.accountIDToName ?? accountIDToNameMap,

App/src/libs/Parser.ts

Line 9 in e6cc804

const accountIDToNameMap: Record<string, string> = {};

App/src/libs/Parser.ts

Lines 32 to 43 in e6cc804

Onyx.connect({

key: ONYXKEYS.PERSONAL_DETAILS_LIST,

callback: (personalDetailsList) => {

for (const personalDetails of Object.values(personalDetailsList ?? {})) {

if (!personalDetails) {

continue;

}

accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? personalDetails.displayName ?? '';

}

},

});

So, I cleared it following the same pattern we already had for reportIDToNameMap.

App/src/libs/Parser.ts

Lines 11 to 17 in e6cc804

let reportIDToNameMap: Record<string, string> = {};

Onyx.connect({

key: ONYXKEYS.COLLECTION.REPORT,

waitForCollectionCallback: true,

callback: (value) => {

// Clear the map so removed reports don’t linger

reportIDToNameMap = {};

shubham1206agra · 2026-07-12T02:45:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-12.at.8.13.45.AM.mov

JmillsExpensify

No product review required.

github-actions · 2026-07-13T19:14:11Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-13T19:22:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95888.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-258112b1584-3fececf-cf20453f4f8d49e391bade9488d84b8e9080c819/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-258112b-3fececf-339c3c260792fc150a49b3004e21a2f5f2edcb36/index.html

Web 🕸️
https://95888.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-14T11:39:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-14T11:41:18Z

🤖 I reviewed the changes in this PR against Expensify's help site files under docs/articles.

No help site changes are required.

This PR is an internal refactor — part of deprecating Onyx.connect() for ONYXKEYS.PERSONAL_DETAILS_LIST (#66391). It removes getPersonalDetailsByIDs usage from OptionsListUtils, moves the accountIDToNameMap cache into an Onyx callback in Parser.ts (clearing it on update so removed personal details don't linger), and adds/adjusts unit tests.

The only behavioral effect — a mention of a nonexistent user consistently rendering as @Hidden in the LHN and report screen — is an implementation-level display detail. It is not a customer-facing feature, setting, or workflow, and there is no existing help article documenting mention/@Hidden behavior. So no draft docs PR was created.

If you believe this behavior should be documented somewhere specific, let me know which article and I'll draft the update.

OSBotify · 2026-07-16T05:15:38Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:06:31Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

bernhardoj added 3 commits July 11, 2026 15:46

fix personal detail lingering

d26339a

simplify

cf303a2

add test

f06c0c2

bernhardoj requested review from a team as code owners July 11, 2026 07:55

melvin-bot Bot assigned bernhardoj Jul 11, 2026

melvin-bot Bot requested review from JmillsExpensify and shubham1206agra and removed request for a team July 11, 2026 07:55

bernhardoj commented Jul 11, 2026

View reviewed changes

bernhardoj added 3 commits July 11, 2026 16:30

remove unused import

16c86b9

fix test

d7136c9

remove unused export

7745502

shubham1206agra approved these changes Jul 12, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 12, 2026 02:45

JmillsExpensify reviewed Jul 12, 2026

View reviewed changes

mountiny approved these changes Jul 13, 2026

View reviewed changes

mountiny merged commit 258112b into Expensify:main Jul 13, 2026
36 checks passed

OSBotify mentioned this pull request Jul 14, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

melvin-bot Bot mentioned this pull request Jul 16, 2026

Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/PersonalDetailsUtils.ts #66391

Open

Navigation Menu

Uh oh!

Remove getPersonalDetailsByIDs usage from OptionsListUtils - #95888

Remove getPersonalDetailsByIDs usage from OptionsListUtils#95888
mountiny merged 6 commits into
Expensify:mainfrom
bernhardoj:chore/66391-refactor-personal-details-to-use-useonyx-15

bernhardoj commented Jul 11, 2026

Uh oh!

melvin-bot Bot commented Jul 11, 2026

Uh oh!

bernhardoj Jul 11, 2026

Uh oh!

shubham1206agra commented Jul 12, 2026

Uh oh!

JmillsExpensify left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	// Fallback: use the action's own message text if not handled above.
	if (!lastMessageTextFromReport && lastReportAction) {
	lastMessageTextFromReport = lastVisibleMessage?.lastMessageText ?? '';
	}

	function getTextFromHtml(html?: string): string {
	return html ? Parser.htmlToText(html) : '';
	}

	htmlToText(htmlString: string, extras?: Extras): string {
	return super.htmlToText(htmlString, {
	reportIDToName: extras?.reportIDToName ?? reportIDToNameMap,
	accountIDToName: extras?.accountIDToName ?? accountIDToNameMap,

	Onyx.connect({
	key: ONYXKEYS.PERSONAL_DETAILS_LIST,
	callback: (personalDetailsList) => {
	for (const personalDetails of Object.values(personalDetailsList ?? {})) {
	if (!personalDetails) {
	continue;
	}

	accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? personalDetails.displayName ?? '';
	}
	},
	});

	let reportIDToNameMap: Record<string, string> = {};
	Onyx.connect({
	key: ONYXKEYS.COLLECTION.REPORT,
	waitForCollectionCallback: true,
	callback: (value) => {
	// Clear the map so removed reports don’t linger
	reportIDToNameMap = {};

Uh oh!

Conversation

bernhardoj commented Jul 11, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 11, 2026

Uh oh!

bernhardoj Jul 11, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Jul 12, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants