[No QA] fix: add Share Extension receipt telemetry by adhorodyski · Pull Request #95840 · Expensify/App

adhorodyski · 2026-07-10T16:20:20Z

Explanation of Change

This extends the [Receipt] telemetry trace to the iOS Share Extension and closes a silent-drop gap.

The Share Extension builds its own receipt and calls requestMoney/trackExpense directly, skipping the code that normally mints a trace id and logs the capture/submit milestones. This PR stamps a trace id on share receipts and logs captured and submitted for that path, so a shared receipt gets the same trace as a camera or gallery receipt.

Separately, when the receipt file is gone at upload time, prepareRequestPayload silently sends the request without it. The request still drains from the queue as a success, so nothing looked stuck, and the old log used a different prefix that never reached Sentry or joined the trace. This adds a logReceiptDropped milestone on the [Receipt] trace spine, carrying receiptTraceId and transactionID, so a receipt can now be followed capture → submitted → enqueued → dropped end to end.

Fixed Issues

$ #95673
PROPOSAL:

Tests

This is a telemetry/observability change. There is no user-facing UI change, so verification is via unit/UI tests rather than manual steps:

tests/ui/SubmitDetailsPageTest.tsx — drives a share submit and verifies the trace id reaches the request receipt, and that captured/submitted fire with captureSource: 'share'.
tests/unit/libs/prepareRequestPayloadNativeTest.ts — verifies that a missing receipt file at upload time calls logReceiptDropped with the receiptTraceId and transactionID.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests. This is a logging-only change with no user-facing behavior to QA on staging.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

…d submit milestones Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

codecov · 2026-07-10T16:25:12Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/prepareRequestPayload/index.native.ts	`68.57% <100.00%> (+0.92%)`	⬆️
src/pages/Share/SubmitDetailsPage.tsx	`87.20% <100.00%> (+0.15%)`	⬆️
src/libs/telemetry/ReceiptObservability.ts	`82.00% <0.00%> (-3.42%)`	⬇️
... and 11 files with indirect coverage changes

When checkFileExists returns false the request is still sent, just without the receipt, and it drains from the queue as a normal success. The old [prepareRequestPayload] alert used a non-[Receipt] prefix, so it never reached Sentry and shared no key with the capture/enqueue lines. The drop was invisible: the trail ended at enqueued. Add a logReceiptDropped milestone on the [Receipt] spine carrying receiptTraceId and transactionID, so the drop is the terminal node on the same trace and this case is diagnosable end to end. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…d test The test loads the real prepareRequestPayload via requireActual, which now imports ReceiptObservability. Left unmocked, that pulled in the real PersistedRequests and NetworkState chain and crashed the jest worker (suite failed to run). Mock ReceiptObservability like the other deps and assert on logReceiptDropped, the contract the unit now has. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Source receiptTraceId's type from Receipt via Pick instead of re-declaring it inline. Dedupe the two SubmitDetailsPage tests onto shared setup/render helpers and read the [Receipt] milestones straight from the Log.info spy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

adhorodyski · 2026-07-13T13:07:04Z

@codex review

chatgpt-codex-connector · 2026-07-13T13:12:41Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: f0db68ba88

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-07-13T13:16:41Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-07-13T14:16:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-07-13.16.25.39.mov

Android: mWeb Chrome

2026-07-13.16.26.26.mov

iOS: HybridApp

2026-07-13.16.25.39.mov

iOS: mWeb Safari

2026-07-13.16.26.26.mov

MacOS: Chrome / Safari

2026-07-13.16.28.20.mov

github-actions · 2026-07-13T16:41:09Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-13T16:47:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-13T16:47:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95840.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-171fc70e726-3fececf-6ff2b185419724121f2ce8c86f3cf57f121f1305/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-171fc70-3fececf-75f424ee4d07b22001244ade8cf51b4a1d308e32/index.html

Web 🕸️
https://95840.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-14T11:38:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-14T11:40:54Z

Help site review — no changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles and no documentation updates are needed.

This is a telemetry/observability-only change scoped to the iOS Share Extension receipt path:

Adds 'share' as a ReceiptCaptureSource and stamps a [Receipt] trace id on shared receipts, logging the captured and submitted milestones for that path.
Adds a logReceiptDropped milestone (on the [Receipt] spine, at alert level) so a receipt file missing at upload time is now diagnosable end to end and reaches Sentry.

There is no user-facing UI, feature, setting, tab, button, or workflow change — the PR author explicitly notes there is "no user-facing UI change" and the PR is marked [No QA]. Help site articles document customer-facing product behavior, none of which changes here, so there is nothing to add or update and no draft docs PR was created.

If you believe a customer-facing behavior did change (e.g. how shared receipts appear or are handled from the user's perspective) that I should document, let me know and I'll take another pass and open a draft help site PR.

(No draft help site PR was created because no help site changes are required, so there is no linked docs PR to review.)

OSBotify · 2026-07-16T05:15:23Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:06:16Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Add Share Extension receipt telemetry: stamp trace id, log capture an…

dea7ad0

…d submit milestones Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

melvin-bot Bot assigned adhorodyski Jul 10, 2026

adhorodyski changed the title ~~Add Share Extension receipt telemetry: stamp trace id, log capture and submit milestones~~ fix: add Share Extension receipt telemetry Jul 10, 2026

adhorodyski and others added 4 commits July 10, 2026 19:25

Merge branch 'Expensify:main' into durable-receipts-share-telemetry

f0db68b

adhorodyski marked this pull request as ready for review July 13, 2026 13:16

adhorodyski requested review from a team as code owners July 13, 2026 13:16

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team July 13, 2026 13:16

melvin-bot Bot requested a review from trjExpensify July 13, 2026 13:16

adhorodyski changed the title ~~fix: add Share Extension receipt telemetry~~ [No QA] fix: add Share Extension receipt telemetry Jul 13, 2026

melvin-bot Bot removed the request for review from a team July 13, 2026 13:16

ZhenjaHorbach approved these changes Jul 13, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 13, 2026 14:29

mountiny approved these changes Jul 13, 2026

View reviewed changes

mountiny merged commit 171fc70 into Expensify:main Jul 13, 2026
39 checks passed

adhorodyski deleted the durable-receipts-share-telemetry branch July 13, 2026 18:59

jasperhuangg mentioned this pull request Jul 13, 2026

[CP staging] Revert #94973 to fix deploy blocker #95957 (storage access modal on sign-out) #96006

Merged

43 tasks

OSBotify mentioned this pull request Jul 14, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

MelvinBot mentioned this pull request Jul 15, 2026

[Due for payment 2026-07-23] web- Scan- Something went wrong after tapping on create expense #96159

Closed

7 tasks

melvin-bot Bot mentioned this pull request Jul 16, 2026

[Due for payment 2026-07-29] Receipt captured via long-press shortcut lost — expense saved as $0 with no receipt and no failure feedback #95673

Closed

quinthar added the #quality label Aug 11, 2026

Navigation Menu

[No QA] fix: add Share Extension receipt telemetry - #95840

[No QA] fix: add Share Extension receipt telemetry#95840
mountiny merged 5 commits into
Expensify:mainfrom
callstack-internal:durable-receipts-share-telemetry

adhorodyski commented Jul 10, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 10, 2026 •

edited by github-actions Bot

Loading

Uh oh!

adhorodyski commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

melvin-bot Bot commented Jul 13, 2026

Uh oh!

ZhenjaHorbach commented Jul 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

adhorodyski commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adhorodyski commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

melvin-bot Bot commented Jul 13, 2026

Uh oh!

ZhenjaHorbach commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

Help site review — no changes required

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adhorodyski commented Jul 10, 2026 •

edited

Loading

codecov Bot commented Jul 10, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jul 13, 2026 •

edited

Loading