fix: migrate NewChatPage to use useSearchSelector by mkzie2 · Pull Request #95778 · Expensify/App

mkzie2 · 2026-07-10T05:55:32Z

Explanation of Change

Fixed Issues

$ #71061
PROPOSAL:

Tests

Tap the green + (FAB) → Start chat
Verify that: options are displayed in the correct order (Recents, then alphabetical Contacts) and no duplicate item is shown
Type something that will return no results
Verify that: "No results found" message is displayed
Clear the search and tap one of the user options
Verify that: we are navigated to the correct 1:1 chat
Go back to Start chat and tap Add to group on a user that is not first in the list
Verify that: the user is selected in place (does not jump to the top) and a Next button appears
Type a valid email of a non-existing user, tap Add to group on the invite row, then clear the search
Verify that: the invited user stays visible in the top section
Tap Next
Verify that: NewChatConfirmPage opens with the correct selected participants

Verify that no errors appear in the JS console

Offline tests

QA Steps

Tap the green + (FAB) → Start chat
Verify that: options are displayed in the correct order (Recents, then alphabetical Contacts) and no duplicate item is shown
Type something that will return no results
Verify that: "No results found" message is displayed
Clear the search and tap one of the user options
Verify that: we are navigated to the correct 1:1 chat
Go back to Start chat and tap Add to group on a user that is not first in the list
Verify that: the user is selected in place (does not jump to the top) and a Next button appears
Type a valid email of a non-existing user, tap Add to group on the invite row, then clear the search
Verify that: the invited user stays visible in the top section
Tap Next
Verify that: NewChatConfirmPage opens with the correct selected participants

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2026-07-13.at.22.25.00.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2026-07-13.at.22.22.34.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-07-13.at.22.11.05.mp4

codecov · 2026-07-10T05:58:53Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSearchSelector/base.ts	`87.06% <100.00%> (+4.37%)`	⬆️
...es/NewChatPage/useGroupChatDraftParticipantSync.ts	`100.00% <100.00%> (ø)`
src/pages/NewChatPage/index.tsx	`77.06% <87.50%> (-1.56%)`	⬇️
... and 12 files with indirect coverage changes

melvin-bot · 2026-07-13T15:28:12Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mkzie2 · 2026-07-13T15:28:43Z

I can't log in to native app:

Screen.Recording.2026-07-13.at.22.26.01.mov

Screen.Recording.2026-07-13.at.22.26.17.mov

I'll try fix the issue and add missing screenshots later.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5a1a9cb1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkzie2 · 2026-07-17T09:44:27Z

@ZhenjaHorbach Friendly bump for review.

mkzie2 · 2026-07-27T09:36:20Z

@ZhenjaHorbach Friendly bump for review!

ZhenjaHorbach · 2026-07-27T09:37:22Z

Will check today or tomorrow!

ZhenjaHorbach · 2026-07-27T14:45:01Z

@codex
Review this PR

ZhenjaHorbach · 2026-07-27T14:45:12Z

@MelvinBot
Review this PR

MelvinBot · 2026-07-27T14:50:33Z

🤖 PR Review — overall this is a clean, well-scoped refactor. It removes the per-page option/pagination plumbing in NewChatPage and delegates to useSearchSelector, matching the InviteReportParticipantsPage reference pattern from the issue. All CI is green (typecheck, ESLint, React Compiler, unit tests, perf), no dangling references to the deleted mergeAndSortPersonalDetailsWithContacts/types files remain, and the moved de-dupe logic is now unit-tested. A few things to confirm before approving:

1. Native testing gap on the PR's headline behavior. The device-contact de-dupe is the substantive behavioral change here, and it is native-only — contactOptions is only populated in useSearchSelector/index.native.ts:29, so the de-dupe block in base.ts:226-253 never runs on web. But Android: Native and iOS: Native screenshots/videos are missing from the PR body (the author noted a native login issue and said they'd add them later). Since imported-contact de-dupe + selection is exactly what changed, please make sure the import → dedupe → select-existing-contact flow is verified on a real device before this merges.

2. This changes shared-hook behavior for all consumers, not just NewChatPage. The de-dupe was moved into useSearchSelectorBase, so it now applies to every caller passing contactOptions (any enablePhoneContacts: true consumer), not only NewChatPage. That's arguably an improvement, but it expands the blast radius beyond this page — worth confirming it's intended and that no other consumer relied on the old raw-concat behavior.

Minor points (non-blocking)

Ordering: the deleted mergeAndSortPersonalDetailsWithContacts re-sorted the merged union alphabetically before pagination. The new code concatenates deduped contacts to the end of defaultOptions.personalDetails (base.ts:251) and relies on getValidOptions/orderOptions downstream for final ordering. This should be fine (test step 2 covers "alphabetical Contacts"), just confirm it holds on device.
Two new no-unsafe-type-assertion disables — option as OptionData in toggleOption and the getParticipantsOption(...) as OptionData restore cast. Both are commented and reasonable given the option is fully built by the selector; flagging only for awareness.
Draft restore path looks correct: existing users (real accountID present in allPersonalDetails) restore via getParticipantsOption keeping isOptimisticAccount unset, while invited-by-email/phone users (optimistic accountID not in personal details) fall through to getUserToInviteOption and keep the optimistic flag (useGroupChatDraftParticipantSync.ts:61-71). No re-write loop since restore calls setSelectedOptions directly (bypassing onSelectionChange).

Nothing here is a hard blocker on the code itself — the main ask is native verification of the contact de-dupe before merge.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e51455381c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkzie2 · 2026-07-28T09:39:36Z

@ZhenjaHorbach I updated.

ZhenjaHorbach · 2026-07-31T08:29:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-08-03.12.14.10.mov

Android: mWeb Chrome

2026-08-03.12.14.10.mov

iOS: HybridApp

2026-08-03.12.19.22.mov

iOS: mWeb Safari

2026-08-03.12.17.07.mov

MacOS: Chrome / Safari

2026-08-03.12.10.32.mov

ZhenjaHorbach · 2026-07-31T08:29:16Z

@mkzie2
Can you fix conflicts, please?

mkzie2 · 2026-08-03T09:00:31Z

@ZhenjaHorbach I updated.

NikkiWines

looks good, couple small things regarding style

ZhenjaHorbach · 2026-08-06T08:19:37Z

@mkzie2
Can you fix the comments, please?

mkzie2 · 2026-08-07T06:11:26Z

@ZhenjaHorbach @NikkiWines I updated.

NikkiWines

👍

github-actions · 2026-08-10T15:46:06Z

🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-08-10T15:46:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-10T15:51:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95778.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-48eda989bf4-7e8bfd0-a5a8bda8bb2b72f67f33fe548ed16d975f9cf223/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-48eda98-7e8bfd0-3077419cfa767886df1d63bcc1ff29089b823598/index.html

Web 🕸️
https://95778.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-10T22:05:42Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.4.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-08-10T22:08:49Z

🤖 Help site review: no docs changes required.

This PR migrates NewChatPage (the Start chat flow) to the shared useSearchSelector hook to remove duplicated search/selection code (issue #71061, Task 4). It's an internal refactor — the diff only touches hooks, page implementation, and unit tests. There are:

No new or renamed user-facing features, tabs, settings labels, or buttons
No changed copy/strings (no translate/Localize additions — only an import re-shuffle)
No behavior change for users: option ordering (Recents → alphabetical Contacts), no-duplicate handling, "No results found", in-place selection, and inviting new users all continue to work as before — the refactor just makes them consistent with the shared hook

Nothing under App/docs/articles documents this internal implementation, so per HELP_AUTHORING_GUIDELINES.md / HELPSITE_NAMING_CONVENTIONS.md there is no customer-facing content to add or update. No draft help site PR was created.

@mkzie2, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-08-12T18:15:52Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

fix: migrate NewChatPage to use useSearchSelector

1e632f4

melvin-bot Bot assigned mkzie2 Jul 10, 2026

mkzie2 mentioned this pull request Jul 10, 2026

[Due for payment 2026-08-19] [$250] Refactor provided component to use useSearchSelector hook and remove unused and duplicated code (Task 4) #71061

Closed

Merge branch 'main' into mkzie2-issue/71061-2

f5a1a9c

mkzie2 marked this pull request as ready for review July 13, 2026 15:28

mkzie2 requested review from a team as code owners July 13, 2026 15:28

melvin-bot Bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team July 13, 2026 15:28

melvin-bot Bot removed the request for review from a team July 13, 2026 15:28

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread src/pages/NewChatPage/index.tsx

github-actions Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread src/pages/NewChatPage/index.tsx

mkzie2 added 4 commits July 17, 2026 17:25

Merge branch 'main' into mkzie2-issue/71061-2

ad29e49

Merge branch 'main' into mkzie2-issue/71061-2

c56869a

fix: apply suggestions

0567cba

Merge branch 'main' into mkzie2-issue/71061-2

e514553

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

Comment thread src/hooks/useSearchSelector/base.ts Outdated

ZhenjaHorbach reviewed Jul 27, 2026

View reviewed changes

Comment thread src/hooks/useSearchSelector/base.ts Outdated

ZhenjaHorbach reviewed Jul 27, 2026

View reviewed changes

Comment thread src/pages/NewChatPage/useGroupChatDraftParticipantSync.ts Outdated

Merge branch 'main' into mkzie2-issue/71061-2

d046b4b

fix: apply suggestions

568ff64

Merge branch 'main' into mkzie2-issue/71061-2

a97ee87

ZhenjaHorbach approved these changes Aug 3, 2026

View reviewed changes

melvin-bot Bot requested a review from NikkiWines August 3, 2026 10:21

NikkiWines requested changes Aug 4, 2026

View reviewed changes

Comment thread tests/unit/useSearchSelectorTest.tsx

Comment thread tests/unit/useSearchSelectorTest.tsx

Comment thread src/pages/NewChatPage/index.tsx

Comment thread src/pages/NewChatPage/index.tsx

Comment thread src/hooks/useSearchSelector/base.ts Outdated

mkzie2 added 2 commits August 7, 2026 12:00

Merge branch 'main' into mkzie2-issue/71061-2

f1fd713

fix: apply suggestions

962f0dc

NikkiWines approved these changes Aug 10, 2026

View reviewed changes

NikkiWines merged commit 48eda98 into Expensify:main Aug 10, 2026
36 of 37 checks passed

OSBotify mentioned this pull request Aug 10, 2026

Deploy Checklist: New Expensify 2026-08-10 #98179

Closed

MelvinBot mentioned this pull request Sep 3, 2026

Start chat - User not moved to the top after select #100325

Closed

1 of 7 tasks

Conversation

mkzie2 commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 13, 2026

Uh oh!

mkzie2 commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

mkzie2 commented Jul 17, 2026

Uh oh!

mkzie2 commented Jul 27, 2026

Uh oh!

ZhenjaHorbach commented Jul 27, 2026

Uh oh!

ZhenjaHorbach commented Jul 27, 2026

Uh oh!

ZhenjaHorbach commented Jul 27, 2026

Uh oh!

MelvinBot commented Jul 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkzie2 commented Jul 28, 2026

Uh oh!

ZhenjaHorbach commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 31, 2026

Uh oh!

mkzie2 commented Aug 3, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZhenjaHorbach commented Aug 6, 2026

Uh oh!

mkzie2 commented Aug 7, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

OSBotify commented Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

OSBotify commented Aug 10, 2026

Uh oh!

MelvinBot commented Aug 10, 2026

mkzie2 commented Jul 10, 2026 •

edited

Loading

codecov Bot commented Jul 10, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jul 31, 2026 •

edited

Loading