Skip to content

fix: Error is not shown for the empty Quantity field after choose another subrate #95735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 3 commits into from
Jul 13, 2026
Merged

fix: Error is not shown for the empty Quantity field after choose another subrate #95735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9b438c
fix: Error is not shown for the empty Quantity field after choose ano…
nkdengineer Jul 9, 2026
9cb061d
Merge branch 'main' into fix/94335
nkdengineer Jul 13, 2026
959b445
change prop name
nkdengineer Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/ValuePicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ function ValuePicker({
placeholder = '',
errorText = '',
onInputChange,
onOpen,
furtherDetails,
shouldShowTooltips = true,
shouldShowModal = true,
Expand All @@ -32,6 +33,7 @@ function ValuePicker({

const showPickerModal = () => {
setIsPickerVisible(true);
onOpen?.();
};

const hidePickerModal = () => {
Expand Down
3 changes: 3 additions & 0 deletions src/components/ValuePicker/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ type ValuePickerProps = ForwardedFSClassProps & {
/** Callback to call when the input changes */
onInputChange?: (value: string | undefined) => void;

/** Callback to call when the picker begins to open */
onOpen?: () => void;

/** Text to display under the main menu item */
furtherDetails?: string;

Expand Down
3 changes: 3 additions & 0 deletions src/pages/iou/request/step/IOURequestStepSubrate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,9 @@ function IOURequestStepSubrate({
waitForUpcomingTransition: true,
});
}}
onOpen={() => {
textInputRef.current?.blur();
}}
/>
</View>
<InputWrapperWithRef
Expand Down
Loading