Render report field name as HTML only when needed by jmgraa · Pull Request #95661 · Expensify/App

jmgraa · 2026-07-09T06:20:53Z

Explanation of Change

Report names (and other titles) can be plain strings or HTML. Forcing the RenderHTML path on plain-text values causes unnecessary parsing overhead. By gating on Parser.isHTML inside MenuItem, titles are only run through RenderHTML when they actually contain HTML; plain text is rendered as-is. This reduces render time for fields like the report name in the money request confirmation list by ~50–60ms.

The same shouldRenderAsHTML prop is used across many surfaces - ReportField, MoneyRequestView, TaskView, SplitExpensePage, DynamicReportDetailsPage, workspace settings, and more. Moving the conditional logic into MenuItem fixes the issue once for all of them, instead of duplicating Parser.isHTML checks at every call site.

Fixed Issues

$ #95335
PROPOSAL:

Tests

From the main screen, click the floating + (Create) button and select Create Report. Give the report a plain-text name, e.g. Weekly expenses.
Click the + button again → Create Report, and give this second report a name containing HTML entities, e.g. A & B expenses or Bob's expenses (A & B expenses / Bob's expenses).
Click the + button → Create expense (→ Manual), enter an amount, and proceed to the confirmation screen.
In the Report section, tap the field and select the first (plain-text) report — Weekly expenses.
Verify the Report field displays Weekly expenses correctly as plain text, with no raw markup.
Tap the Report field again and select the second (HTML-named) report — A & B expenses / Bob's expenses.
Verify the Report field displays the decoded name correctly — A & B expenses / Bob's expenses — and not the raw entities (A & B expenses / Bob's expenses).

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…extension

dariusz-biela

The change is definitely a step in the right direction, but we need to resolve a few issues related to differences in rendering.

Also update the PR description.

Add information about how you measured the performance gain.

Provide exact results showing how long it took before and after, and what the difference is.

You can also include results not only from the metrics but also from the React Profiler.

codecov · 2026-07-17T06:40:20Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MenuItem.tsx	`90.87% <100.00%> (+0.06%)`	⬆️
... and 332 files with indirect coverage changes

dariusz-biela

It's good, but don't be afraid to leave comments wherever you make a non-obvious decision in the code.

The next person who works on this code will be grateful to you if they don't have to scour half of GitHub to understand the reasoning behind this solution.

Co-authored-by: Dariusz Biela <dariusz.biela.dev@gmail.com>

melvin-bot · 2026-07-20T09:29:44Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-20T09:29:50Z

@mkhutornyi @mjasikowski One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39e136bd2d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JmillsExpensify

No product review required on this one.

…extension

truph01 · 2026-07-20T17:11:36Z

@codex review

chatgpt-codex-connector · 2026-07-20T17:19:51Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 80e5f14018

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

truph01 · 2026-07-22T07:14:29Z

+                                                                        {shouldRenderTitleAsHTML || shouldParseTitle ? (
+                                                                            <RenderHTML html={processedTitle} />
+                                                                        ) : (
+                                                                            <Text style={styles.webViewStyles.baseFontStyle}>{convertToLTR(Parser.htmlToText(processedTitle))}</Text>


Unnecessary htmlToText round-trip on plain text

When shouldRenderTitleAsHTML is false, processedTitle wraps the title in <comment> tags only for Parser.htmlToText to strip them. Could this just use convertToLTR(title ?? '') directly?

The wrap-then-strip pattern looks redundant. However, it exists because the processedTitle logic always appends , regardless of whether the output is HTML or plain text. If we remove Parser.htmlToText, the user will see literal "" tags in the text.

The truncation logic in processedTitle is awkward, but refactoring it is out of scope for this PR, so we retain the existing pipeline.

truph01 · 2026-07-24T07:55:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-24.at.14.54.21.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-07-24.at.15.06.41.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-24.at.14.41.09.mov

github-actions · 2026-07-24T08:28:44Z

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-24T08:34:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95661.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-07024e0ea39-d815402-3c26ec2d7cf51545790eb6ceeb73f28918db2907/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-07024e0-d815402-542892bd4141ed3ce118a4e3d86fe47768ee8b54/index.html

Web 🕸️
https://95661.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-24T12:05:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-07-27T19:05:24Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.45-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-27T19:07:33Z

🤖 I reviewed this PR against the help site articles under docs/articles.

No help site changes are required. ✅

This PR is a purely internal rendering optimization in MenuItem.tsx: it gates the RenderHTML path on Parser.isHTML(title) so plain-text titles (like a report name) render as plain Text instead of being pushed through HTML parsing. The rendered output is byte-for-byte identical from a user's perspective — plain names still show as plain text, and HTML-entity names (e.g. Bob's expenses) still decode correctly. Only the render cost changes (~50–60ms faster).

Because nothing user-facing changed — no new feature, no renamed tab/setting/button, no altered workflow — there is no documented product behavior to update. The help site documents features and flows, not internal component rendering, so there is nothing to add or correct.

No draft PR was created since there is no documentation delta to make.

@jmgraa, there's no linked help site PR to review here since this change is not user-facing and no documentation update is needed. If you believe a doc does need updating, let me know which article and I'll open a draft PR.

OSBotify · 2026-07-29T20:17:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

render report name as HTML conditionally

ebfe9d5

melvin-bot Bot assigned jmgraa Jul 9, 2026

jmgraa mentioned this pull request Jul 9, 2026

[Due for payment 2026-09-03] [Metric] [Performance] ShareExtensionOpenSubmitFlow - iOS Native Share Extension is slow and feels broken #95335

Closed

render report name as HTML conditionally

8a501ab

jmgraa force-pushed the jmgraa/ios-native-share-extension branch from a050988 to 8a501ab Compare July 14, 2026 12:53

Merge remote-tracking branch 'upstream' into jmgraa/ios-native-share-…

0f840ab

…extension

dariusz-biela reviewed Jul 15, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx

Comment thread src/components/MenuItem.tsx

Comment thread src/components/MenuItem.tsx

jmgraa added 2 commits July 17, 2026 08:34

add tests for HTML rendering, title truncation and styling consistency

37e5fd5

update conditions for rendering HTML titles

5394e44

revert adding tests

32fc032

dariusz-biela reviewed Jul 17, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

Comment thread src/components/MenuItem.tsx Outdated

Comment thread src/components/MenuItem.tsx Outdated

Comment thread src/components/MenuItem.tsx

dariusz-biela reviewed Jul 17, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

jmgraa and others added 4 commits July 20, 2026 08:25

simplify condition for processedPlainTextTitle

aa15fb5

Co-authored-by: Dariusz Biela <dariusz.biela.dev@gmail.com>

add explanation comment to shouldRenderAsHTML

57b822a

Co-authored-by: Dariusz Biela <dariusz.biela.dev@gmail.com>

remove redundant processedPlainTextTitle variable

98704c0

explain plain-text title rendering

39e136b

dariusz-biela approved these changes Jul 20, 2026

View reviewed changes

jmgraa marked this pull request as ready for review July 20, 2026 09:29

jmgraa requested review from a team as code owners July 20, 2026 09:29

melvin-bot Bot requested review from JmillsExpensify and truph01 July 20, 2026 09:29

melvin-bot Bot requested review from a team, mjasikowski and mkhutornyi and removed request for a team July 20, 2026 09:29

github-actions Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx

chatgpt-codex-connector Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

truph01 reviewed Jul 20, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

truph01 reviewed Jul 20, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

JmillsExpensify reviewed Jul 20, 2026

View reviewed changes

jmgraa added 4 commits July 20, 2026 12:52

remove additional comment

f896edb

preserve Android LTR conversion for plain HTML titles

a8229ce

skip RenderHTML for plain MenuItem titles only

80e5f14

Merge remote-tracking branch 'upstream' into jmgraa/ios-native-share-…

f90083a

…extension

truph01 reviewed Jul 21, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

revert shouldParseFullTitle condition

f62c78c

truph01 reviewed Jul 22, 2026

View reviewed changes

truph01 approved these changes Jul 24, 2026

View reviewed changes

mjasikowski approved these changes Jul 24, 2026

View reviewed changes

mjasikowski merged commit 07024e0 into Expensify:main Jul 24, 2026
35 of 37 checks passed

github-actions Bot mentioned this pull request Jul 24, 2026

Investigate workflow job failing on main: test / test (job 7) #96941

Closed

OSBotify mentioned this pull request Jul 27, 2026

Deploy Checklist: New Expensify 2026-07-27 #97134

Closed

quinthar added the #quality label Aug 11, 2026

jmgraa deleted the jmgraa/ios-native-share-extension branch August 28, 2026 11:54

Uh oh!

Conversation

jmgraa commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

dariusz-biela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dariusz-biela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Jul 20, 2026

Uh oh!

melvin-bot Bot commented Jul 20, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Jul 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 20, 2026

Uh oh!

Uh oh!

truph01 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

jmgraa Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

truph01 commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

OSBotify commented Jul 24, 2026

Uh oh!

OSBotify commented Jul 27, 2026

Uh oh!

MelvinBot commented Jul 27, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jmgraa commented Jul 9, 2026 •

edited

Loading

codecov Bot commented Jul 17, 2026 •

edited by github-actions Bot

Loading

truph01 commented Jul 24, 2026 •

edited

Loading