[No QA][Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg by fabioh8010 · Pull Request #95613 · Expensify/App

fabioh8010 · 2026-07-08T15:18:31Z

Explanation of Change

Part of the useOnyx dependencies-argument removal (#94595), PR 1 of the split.

Adds a local ESLint rule rulesdir/no-useonyx-dependencies-arg that forbids passing the deprecated 3rd dependencies argument to useOnyx(). React Compiler now memoizes selectors, so the manual dependency list is redundant (and unvalidatable by react-hooks/exhaustive-deps). Existing call sites are grandfathered via eslint-seatbelt (77 files) and will be migrated in the follow-up batch PRs; new 3-arg usages are blocked in CI. Tooling-only change — no runtime/behavior change.

New: eslint-plugin-local-rules/no-useonyx-dependencies-arg.js
Wired: config/eslint/eslint.config.mjs → 'rulesdir/no-useonyx-dependencies-arg': 'error'
Seeded: config/eslint/eslint.seatbelt.tsv (77 grandfathered entries)

Fixed Issues

$ #95573
PROPOSAL: N/A

Tests

Run npm run lint → passes. Existing 3-arg useOnyx call sites are grandfathered by seatbelt (reported as "tend the garden" warnings, not errors).
Add a throwaway const [x] = useOnyx(ONYXKEYS.SESSION, {selector: (v) => v}, ['dep']); to any src file, run npm run lint-changed on it → it fails with rulesdir/no-useonyx-dependencies-arg. Remove the throwaway line.
Confirm config/eslint/eslint.seatbelt.tsv contains entries for rulesdir/no-useonyx-dependencies-arg (count > 0).

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A — ESLint tooling-only change, validated by CI lint. No user-facing surface.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…seOnyx 3rd argument Adds a local ESLint rule that forbids passing the deprecated 3rd `dependencies` argument to useOnyx(). React Compiler now memoizes selectors, so the manual dep list is redundant. Existing call sites are grandfathered via eslint-seatbelt (77 files) and will be migrated in follow-up batch PRs; new usages are blocked. Part of Expensify#94595 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

melvin-bot · 2026-07-08T15:59:42Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-08T16:01:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 7 files with indirect coverage changes

hoangzinh · 2026-07-09T09:59:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

hoangzinh · 2026-07-09T11:05:11Z

@fabioh8010 can you resolve conflicts, please? Might be config/eslint/eslint.seatbelt.tsv is too hot

# Conflicts: # config/eslint/eslint.seatbelt.tsv # cspell.json

… casing Addresses review feedback: use camelCase `useOnyx` (like `no-inline-useOnyx-selector`). This also drops the `useonyx` cspell entry, since the camelCase name splits into already-known tokens. Re-seeded the eslint-seatbelt baseline under the new rule name. Part of Expensify#95573 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fabioh8010 · 2026-07-10T12:58:16Z

@hoangzinh back to you!

hoangzinh · 2026-07-10T13:39:25Z

It took 41 minutes to complete. Can you try to merge latest main or empty commit to verify it again?

…oval-lint-rule

github-actions · 2026-07-10T16:03:13Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-10T16:12:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95613.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-dd935b9f1bb-a91d37b-d1037fdea11b950ecb45d665228520fb31485efd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-dd935b9-a91d37b-9fbe00e040aa4584f6afdd5aa486be085aed8183/index.html

Web 🕸️
https://95613.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:40:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-07-14T11:37:36Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-16T05:14:14Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:05:07Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned fabioh8010 Jul 8, 2026

fabioh8010 mentioned this pull request Jul 8, 2026

[Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg #95612

Closed

16 tasks

Fix CSpell

a19a2d6

fabioh8010 changed the title ~~[Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg~~ [No QA][Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg Jul 8, 2026

fabioh8010 marked this pull request as ready for review July 8, 2026 15:59

fabioh8010 requested a review from a team as a code owner July 8, 2026 15:59

melvin-bot Bot requested review from hoangzinh and removed request for a team July 8, 2026 15:59

This was referenced Jul 8, 2026

[Due for payment 2026-08-27] [$1000] Remove useOnyx's dependencies argument #94595

Closed

[Due for payment 2026-07-23] [Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg #95573

Closed

hoangzinh reviewed Jul 9, 2026

View reviewed changes

Comment thread cspell.json Outdated

hoangzinh reviewed Jul 9, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-useOnyx-dependencies-arg.js

fabioh8010 and others added 2 commits July 10, 2026 12:13

Merge branch 'main' into feature/onyx-deps-removal-lint-rule

9152c50

# Conflicts: # config/eslint/eslint.seatbelt.tsv # cspell.json

fabioh8010 requested a review from hoangzinh July 10, 2026 12:58

Merge remote-tracking branch 'origin/main' into feature/onyx-deps-rem…

6f6186d

…oval-lint-rule

hoangzinh approved these changes Jul 10, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 10, 2026 15:39

mountiny approved these changes Jul 10, 2026

View reviewed changes

mountiny merged commit dd935b9 into Expensify:main Jul 10, 2026
32 checks passed

hoangzinh mentioned this pull request Jul 14, 2026

[Due for payment 2026-07-29] [Split #94595] Batch A - Remove useOnyx deps from low-risk shared hooks #95574

Closed

OSBotify mentioned this pull request Jul 14, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

quinthar added the #quality label Aug 11, 2026

Navigation Menu

[No QA][Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg - #95613

[No QA][Split #94595] PR 1 - Add ESLint guard for useOnyx dependencies arg#95613
mountiny merged 5 commits into
Expensify:mainfrom
callstack-internal:feature/onyx-deps-removal-lint-rule

fabioh8010 commented Jul 8, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jul 8, 2026

Uh oh!

codecov Bot commented Jul 8, 2026 •

edited by github-actions Bot

Loading

Uh oh!

hoangzinh commented Jul 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

hoangzinh commented Jul 9, 2026

Uh oh!

Uh oh!

fabioh8010 commented Jul 10, 2026

Uh oh!

hoangzinh commented Jul 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fabioh8010 commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 8, 2026

Uh oh!

codecov Bot commented Jul 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hoangzinh commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

hoangzinh commented Jul 9, 2026

Uh oh!

Uh oh!

fabioh8010 commented Jul 10, 2026

Uh oh!

hoangzinh commented Jul 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fabioh8010 commented Jul 8, 2026 •

edited

Loading

codecov Bot commented Jul 8, 2026 •

edited by github-actions Bot

Loading

hoangzinh commented Jul 9, 2026 •

edited

Loading