Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/languages/de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -990,8 +990,8 @@ const translations: TranslationDeepObject<typeof en> = {
personalSubtitle: 'Geldbörse',
},
addVirtualCardPersonalDetails: {
title: 'Fügen Sie Ihre persönlichen Daten hinzu',
subtitle: 'Fügen Sie Ihre Daten hinzu, um Ihre Expensify Karte anzusehen und zu verwenden.',
title: 'Fügen Sie Ihre Daten hinzu, um Ihre Expensify Karte anzuzeigen und zu verwenden.',
subtitle: 'Expensify Karte',
cta: 'Details hinzufügen',
},
enterSignerInfo: {title: 'Unterzeichnerdaten erforderlich', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `Bankkonto ${bankAccountLastFour}`},
Expand Down
4 changes: 2 additions & 2 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1016,8 +1016,8 @@ const translations = {
cta: 'Add address',
},
addVirtualCardPersonalDetails: {
title: 'We need your personal details',
subtitle: 'Add your details to view and start using your Expensify Card.',
title: 'Add your details to view and start using your Expensify Card.',
subtitle: 'Expensify Card',
cta: 'Add details',
},
addPaymentCard: {
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ const translations: TranslationDeepObject<typeof en> = {
subtitle: 'Proporciona una dirección para recibir tu Tarjeta Expensify.',
cta: 'Añade dirección',
},
addVirtualCardPersonalDetails: {title: 'Añade tus datos personales', subtitle: 'Añade tus datos para ver y empezar a usar tu Tarjeta Expensify.', cta: 'Añade detalles'},
addVirtualCardPersonalDetails: {title: 'Añade tus datos para ver y empezar a usar tu Tarjeta Expensify.', subtitle: 'Tarjeta Expensify', cta: 'Añade detalles'},
addPaymentCard: {
title: 'Añade una tarjeta de pago para seguir usando Expensify',
subtitle: 'Cuenta > Suscripción',
Expand Down
4 changes: 2 additions & 2 deletions src/languages/fr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -993,8 +993,8 @@ const translations: TranslationDeepObject<typeof en> = {
personalSubtitle: 'Portefeuille',
},
addVirtualCardPersonalDetails: {
title: 'Ajoutez vos informations personnelles',
subtitle: 'Ajoutez vos informations pour afficher et commencer à utiliser votre Carte Expensify.',
title: 'Ajoutez vos informations pour voir et commencer à utiliser votre Carte Expensify.',
subtitle: 'Carte Expensify',
cta: 'Ajouter des détails',
},
enterSignerInfo: {title: 'Informations du signataire requises', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `Compte bancaire ${bankAccountLastFour}`},
Expand Down
4 changes: 2 additions & 2 deletions src/languages/it.ts
Original file line number Diff line number Diff line change
Expand Up @@ -991,8 +991,8 @@ const translations: TranslationDeepObject<typeof en> = {
personalSubtitle: 'Portafoglio',
},
addVirtualCardPersonalDetails: {
title: 'Aggiungi i tuoi dati personali',
subtitle: 'Aggiungi i tuoi dati per visualizzare e iniziare a usare la tua Carta Expensify.',
title: 'Aggiungi i tuoi dati per visualizzare e iniziare a usare la tua Carta Expensify.',
subtitle: 'Carta Expensify',
cta: 'Aggiungi dettagli',
},
enterSignerInfo: {title: 'Informazioni del firmatario necessarie', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `Conto bancario ${bankAccountLastFour}`},
Expand Down
2 changes: 1 addition & 1 deletion src/languages/ja.ts
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ const translations: TranslationDeepObject<typeof en> = {
workspaceSubtitle: ({policyName}: {policyName: string}) => policyName,
personalSubtitle: 'ウォレット',
},
addVirtualCardPersonalDetails: {title: '個人情報を追加してください', subtitle: 'Expensify カードを表示して使い始めるには、詳細情報を入力してください。', cta: '詳細を追加'},
addVirtualCardPersonalDetails: {title: 'Expensify カードを表示して利用を開始するには、ご自身の情報を追加してください。', subtitle: 'Expensify カード', cta: '詳細を追加'},
enterSignerInfo: {title: '署名者情報が必要です', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `銀行口座 ${bankAccountLastFour}`},
},
announcements: 'お知らせ',
Expand Down
4 changes: 2 additions & 2 deletions src/languages/nl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -989,8 +989,8 @@ const translations: TranslationDeepObject<typeof en> = {
personalSubtitle: 'Portemonnee',
},
addVirtualCardPersonalDetails: {
title: 'Voeg je persoonlijke gegevens toe',
subtitle: 'Voeg je gegevens toe om je Expensify Kaart te bekijken en te gaan gebruiken.',
title: 'Voeg je gegevens toe om je Expensify Kaart te bekijken en te gebruiken.',
subtitle: 'Expensify Kaart',
cta: 'Details toevoegen',
},
enterSignerInfo: {title: 'Ondertekenaargegevens vereist', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `Bankrekening ${bankAccountLastFour}`},
Expand Down
2 changes: 1 addition & 1 deletion src/languages/pl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ const translations: TranslationDeepObject<typeof en> = {
workspaceSubtitle: ({policyName}: {policyName: string}) => policyName,
personalSubtitle: 'Portfel',
},
addVirtualCardPersonalDetails: {title: 'Dodaj swoje dane osobowe', subtitle: 'Dodaj swoje dane, aby wyświetlić i zacząć używać swojej Karty Expensify.', cta: 'Dodaj szczegóły'},
addVirtualCardPersonalDetails: {title: 'Dodaj swoje dane, aby wyświetlić i zacząć używać swojej Karty Expensify.', subtitle: 'Karta Expensify', cta: 'Dodaj szczegóły'},
enterSignerInfo: {title: 'Wymagane dane podpisującego', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `Konto bankowe ${bankAccountLastFour}`},
},
announcements: 'Ogłoszenia',
Expand Down
4 changes: 2 additions & 2 deletions src/languages/pt-BR.ts
Original file line number Diff line number Diff line change
Expand Up @@ -989,8 +989,8 @@ const translations: TranslationDeepObject<typeof en> = {
personalSubtitle: 'Carteira',
},
addVirtualCardPersonalDetails: {
title: 'Adicione seus dados pessoais',
subtitle: 'Adicione seus dados para visualizar e começar a usar seu Cartão Expensify.',
title: 'Adicione seus dados para visualizar e começar a usar seu Cartão Expensify.',
subtitle: 'Cartão Expensify',
cta: 'Adicionar detalhes',
},
enterSignerInfo: {title: 'Informações do signatário necessárias', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `Conta bancária ${bankAccountLastFour}`},
Expand Down
2 changes: 1 addition & 1 deletion src/languages/zh-hans.ts
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ const translations: TranslationDeepObject<typeof en> = {
workspaceSubtitle: ({policyName}: {policyName: string}) => policyName,
personalSubtitle: '钱包',
},
addVirtualCardPersonalDetails: {title: '添加您的个人信息', subtitle: '添加您的详细信息以查看并开始使用 Expensify 卡', cta: '添加详细信息'},
addVirtualCardPersonalDetails: {title: '添加你的详细信息以查看并开始使用 Expensify 卡。', subtitle: 'Expensify 卡', cta: '添加详细信息'},
enterSignerInfo: {title: '需要签署人信息', subtitle: ({bankAccountLastFour}: {bankAccountLastFour: string}) => `银行账户 ${bankAccountLastFour}`},
},
announcements: '公告',
Expand Down
8 changes: 7 additions & 1 deletion src/libs/PersonalDetailsUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type {OnyxEntry, OnyxUpdate} from 'react-native-onyx';
import {Str} from 'expensify-common';
import Onyx from 'react-native-onyx';

import {getCountryCode} from './CountryUtils';
import {translateLocal} from './Localize';
import {areEmailsFromSamePrivateDomain} from './LoginUtils';
import {parsePhoneNumber} from './PhoneNumber';
Expand Down Expand Up @@ -593,7 +594,12 @@ function areAddressAndPersonalDetailsMissing(privatePersonalDetails: OnyxEntry<P
return true;
}
const currentAddress = getCurrentAddress(privatePersonalDetails);
return !currentAddress?.street || !currentAddress?.city || !currentAddress?.state || !currentAddress?.zip || !currentAddress?.country;
// For US addresses the state is required; non-US addresses use a province (also stored under `state`) that only
// recently became required, so legacy non-US users may not have it. This check backs the home/wallet "add details"
// prompts, which intentionally ignore a missing state/province for non-US addresses so those legacy users aren't
// flagged (the personal-details form still requires it when actually entering details).
const isStateMissing = getCountryCode(currentAddress?.country) === CONST.COUNTRY.US && !currentAddress?.state;
return !currentAddress?.street || !currentAddress?.city || isStateMissing || !currentAddress?.zip || !currentAddress?.country;
Comment thread
DylanDylann marked this conversation as resolved.
}

/**
Expand Down
Loading