Fix clearSelectedTransactions call in export download status modal - #95469
Conversation
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@lorretheboy, could you please fill out the |
|
@marufsharifi I added the explanation |
|
@lorretheboy, this fixes the report-level export modal cleanup by changing both call sites from |
trjExpensify
left a comment
There was a problem hiding this comment.
I can see we do this for other actions like Hold, so makes sense to follow suit. 👍
|
@lorretheboy, could you please check the above comment? |
|
@lorretheboy, do you need any help? |
|
@marufsharifi I'm taking a look on it now. Will let u know if having any issues |
|
@marufsharifi I added UT |
|
@MelvinBot, can you give me the manual test steps for the changes in this PR? |
|
Here are manual test steps that exercise both call sites this PR touches. The fix wires Setup
Path 1 — Bulk-selection toolbar (
|
|
@lorretheboy, could you please merge the main? thanks. |
|
@marufsharifi I merged main |
|
@lorretheboy, could you please check the failed action? thanks. |
|
@marufsharifi I think it doesn't related to our PR
|
|
Lemme try to re-run the workflow |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-10.at.3.44.04.PM.movAndroid: mWeb ChromeScreen_Recording_20260710_142918_Chrome.mp4iOS: HybridAppScreen.Recording.1405-04-19.at.5.32.52.PM.moviOS: mWeb SafariScreen.Recording.1405-04-19.at.5.00.21.PM.movMacOS: Chrome / SafariScreen.Recording.2026-07-10.at.2.22.53.PM.mov |
|
@mollfpr, the PR reviewer checklist should pass once you rerun the actions. This is done from my side; all yours. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.34-0 🚀
|
|
🤖 Help site review: no docs changes required I reviewed the changes in this PR and confirmed no updates are needed to Expensify's help site files under Why: This is a purely internal bug fix. It corrects the argument shape passed to the selection cleanup callback — What I checked
Note: browser-based verification of the live UI was unavailable in this run (web prep failed), so this assessment is based on static analysis of the code and help-site content only. @lorretheboy — since no help site changes were required, there is no linked help site PR to review here. If you believe this change does affect documented behavior, let me know and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
The report‑level export status modal runs a cleanup callback on dismiss, but that callback calls
clearSelectedTransactionswith the wrong argument shape, so the report‑view selection is never reset. This PR is for correcting those callback callsFixed Issues
$ #94717
PROPOSAL: #94717 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-07.at.02.00.25.mov
Android: mWeb Chrome
Screen.Recording.2026-07-07.at.02.01.46.mov
iOS: Native
Screen.Recording.2026-07-07.at.01.56.30.mov
iOS: mWeb Safari
Screen.Recording.2026-07-07.at.01.53.38.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-07.at.01.52.19.mov