Skip to content

[No QA] Docs updates for E/A#94567 default letter avatar behavior - #95296

Merged
johncschuster merged 2 commits into
mainfrom
melvin-docs-letter-avatars
Jul 24, 2026
Merged

johncschuster merged 2 commits into
mainfrom
melvin-docs-letter-avatars

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

E/A#94567 adds support for dual-initial (letter) avatars — photo-less users now render an avatar showing their initials on a colored background instead of the previously auto-assigned illustrated/cartoon-style default avatar. Two help articles described the old default-avatar behavior and are now inaccurate:

  • Expensify Classic — Add profile photo (Add-profile-photo.md): the FAQ said a "randomly selected cartoon-style avatar is assigned to new accounts." Updated to describe the initials-on-color default, with the illustrated-avatar fallback for accounts that have no name or email (e.g. phone number-only accounts).
  • New Expensify — Account Settings (Account-Settings.md): added an FAQ entry explaining what a user's avatar looks like when they haven't uploaded a photo.

The described behavior matches the client logic in getLetterAvatarURL — initials come from the first alphanumeric character of the first and last name (or the email when there is no name), the color is derived deterministically from the login so it stays consistent, and accounts with no derivable initial fall back to an illustrated avatar.

Applied HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md: edits stay within the existing # FAQ sections, and the new heading uses a question-form ("What…") task-based heading.

Fixed Issues

Related to #94567

Tests / QA


@grgia, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 3, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#94567 default letter avatar behavior [No QA] Docs updates for E/A#94567 default letter avatar behavior Jul 3, 2026
@OSBotify

This comment has been minimized.

Comment on lines +152 to +154
## What is my avatar if I don't add a profile photo?
If you haven't added a profile photo, your avatar shows your initials on a colored background, based on your name or email. The color stays the same each time, so your avatar is consistent across chats, reports, and notifications. Accounts without a name or email—such as phone number-only accounts—show an illustrated avatar instead.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot remove this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — removed the "What is my avatar if I don't add a profile photo?" section in 6dcabfd.

Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://4ff95122.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review July 17, 2026 02:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6dcabfd5a8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/expensify-classic/settings/Add-profile-photo.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR updates help documentation to reflect the new dual-initial (letter) avatar behavior from E/A pull request 94567. The net effective change against the base branch is a single modified FAQ answer in Add-profile-photo.md (Expensify Classic). The Account-Settings.md addition was introduced in commit 1 and fully reverted in commit 2, so it contributes no net change to the target branch and is not scored below.

The one changed line replaces the outdated "randomly selected cartoon-style avatar" description with an accurate explanation of the initials-on-color default, including the illustrated-avatar fallback for name/email-less accounts. It is a clean, minimal, accurate edit that stays within the existing FAQ structure.

Scores Summary

  • Readability: 9/10 - Clear, concise, and accurate. Two well-formed sentences explaining the default and the fallback case. The parenthetical aside about phone number-only accounts is a helpful, readable clarification.
  • AI Readiness: 8/10 - The edit lives under an existing question-form FAQ heading and adds concrete, searchable terms (initials, colored background, phone number-only accounts) that improve semantic retrieval. The diff is a single answer line, so metadata/heading structure was not touched, and is correctly not required for this edit.
  • Style Compliance: 9/10 - Stays within the exempt FAQ section, no invented UI labels, no prohibited vague navigation phrasing, no button/tab references needing bold. Consistent with HELPSITE_NAMING_CONVENTIONS.md and the FAQ structure in TEMPLATE.md.

Key Findings

  • Positive: The updated text is factually aligned with the described getLetterAvatarURL client logic (deterministic color from login, initials from name or email, illustrated fallback).
  • Positive: Minimal, surgical edit that keeps the existing FAQ heading and structure intact, with no scope creep.
  • Note: The PR intent was to update two articles, but the New Expensify Account-Settings.md FAQ entry was reverted in the second commit. If updating the NewDot article is still desired, that change is currently missing from the net diff. If the revert was intentional, the PR description should be updated to match.
  • Minor: The two articles used slightly different phrasing for the same fallback ("are assigned an illustrated avatar" vs "show an illustrated avatar"); since only the Classic line remains this is not an active inconsistency, but worth aligning if the NewDot entry is re-added.

Recommendations

  • Confirm whether dropping the Account-Settings.md FAQ entry was intentional. If not, restore it; if so, reconcile the PR description so it does not claim a two-article update.
  • No blocking issues on the surviving change; it is accurate and compliant and can merge as-is.

Files Reviewed

  • Add-profile-photo.md (expensify-classic/settings) - One FAQ answer updated; accurate and compliant. Approved.
  • Account-Settings.md (new-expensify/settings) - Added then reverted; no net change in this PR.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott requested a review from a team July 17, 2026 02:24
@melvin-bot

melvin-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @johncschuster

@melvin-bot
melvin-bot Bot requested a review from johncschuster July 17, 2026 02:24
@melvin-bot

melvin-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 17, 2026 02:24
@johncschuster
johncschuster merged commit 6f35748 into main Jul 24, 2026
22 checks passed
@johncschuster
johncschuster deleted the melvin-docs-letter-avatars branch July 24, 2026 12:58
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/johncschuster in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants