Search: show expense count and total when "Select all matching items" is active by lorretheboy · Pull Request #95238 · Expensify/App

lorretheboy · 2026-07-02T22:17:31Z

Explanation of Change

Fixed Issues

$ #94907
PROPOSAL: #94907 (comment)

Tests

Prerequisites:

An account with multiple expenses across at least two pages of results (50+ expenses)

Open the app and go to the Search page
Click "Select all matching items"
Verify that expense count and total is shown in footer
Click "Select all"
Verify that expense count and total is shown in footer
Build an ad-hoc filter query. For example, filter by a specific date range, category, or merchant so the query is custom
Wait for results to load
Click "Select all"
Verify that expense count and total is shown in footer
Click "Select all matching items"
Verify that expense count and total is shown in footer

Verify that no errors appear in the JS console

Offline tests

QA Steps

Prerequisites:

An account with multiple expenses across at least two pages of results (50+ expenses)

Open the app and go to the Search page
Click "Select all matching items"
Verify that expense count and total is shown in footer
Click "Select all"
Verify that expense count and total is shown in footer
Build an ad-hoc filter query. For example, filter by a specific date range, category, or merchant so the query is custom
Wait for results to load
Click "Select all"
Verify that expense count and total is shown in footer
Click "Select all matching items"
Verify that expense count and total is shown in footer

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-07-02.at.18.13.04.mov

Android: mWeb Chrome

234234.mov

iOS: Native

Screen.Recording.2026-07-02.at.18.20.08.mov

Screen.Recording.2026-07-02.at.18.19.44.mov

iOS: mWeb Safari

Screen.Recording.2026-07-02.at.18.18.11.mov

Screen.Recording.2026-07-02.at.18.17.51.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-02.at.18.21.28.mov

…ntext and updating selection button text logic.

codecov · 2026-07-02T22:24:38Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/SearchSelectionFooter.tsx	`41.66% <100.00%> (ø)`
src/components/Search/index.tsx	`46.19% <100.00%> (+0.13%)`	⬆️
src/hooks/useSearchShouldCalculateTotals.ts	`100.00% <100.00%> (ø)`
src/components/Search/SearchPageFooter.tsx	`0.00% <0.00%> (ø)`
src/components/Search/SearchBulkActionsButton.tsx	`1.44% <0.00%> (-0.17%)`	⬇️
... and 11 files with indirect coverage changes

melvin-bot · 2026-07-02T23:22:15Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-02T23:22:19Z

@DylanDylann @luacmartins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 640d48e452

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-07-03T08:34:06Z

@lorretheboy Please don't ignore codex's comment

DylanDylann · 2026-07-03T08:39:54Z

It doesn't work if we load more expenses before selecting all

Screen.Recording.2026-07-03.at.15.39.03.mov

luacmartins · 2026-07-03T17:17:47Z

Conflicts

lorretheboy · 2026-07-05T17:50:14Z

Hi all, thank you for your reviews. I'm checking them and will give an update today

…ng states and total calculations

lorretheboy · 2026-07-07T01:56:26Z

For the flicker here #95238 (comment), I updated the code to add the loading indicator like this, is it ok? @DylanDylann

Screen.Recording.2026-07-06.at.20.55.14.mov

lorretheboy · 2026-07-07T02:01:38Z

@DylanDylann For this issue #95238 (comment):

In case we loaded all expenses, I hide the Select all and Select all on this page options since now we auto select all expense by default

Screen.Recording.2026-07-06.at.20.58.47.mov

In case we loaded a part of expenses, the behavior remains unchange

Screen.Recording.2026-07-06.at.21.00.34.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 996b9a0f51

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-07-08T08:11:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-08.at.15.13.03.mov

Android: mWeb Chrome

Screen.Recording.2026-07-08.at.15.10.50.mov

iOS: HybridApp

Screen.Recording.2026-07-08.at.15.10.08.mov

iOS: mWeb Safari

Screen.Recording.2026-07-08.at.14.59.15.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-08.at.14.56.00.mov

luacmartins · 2026-07-08T21:50:29Z

@lorretheboy it seems like we have some outstanding comments left. Can you please address them?

lorretheboy · 2026-07-09T02:50:10Z

@luacmartins Yes, I will check it shortly

…prove spinner visibility and prevent label flicker

lorretheboy · 2026-07-09T04:08:20Z

@DylanDylann I addressed your comments, however please note that the test failures don't related to this PR changes, I will merge main to fix it once they are tackled

luacmartins · 2026-07-09T18:50:56Z

@lorretheboy I think you can merge main now

lorretheboy · 2026-07-10T06:58:32Z

@luacmartins @DylanDylann I merged main

github-actions · 2026-07-10T17:53:49Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-10T18:00:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95238.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9cd883625f2-fbc55b5-2e5f0d251d638cb6fce266b0dbece13b1b72409a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9cd8836-fbc55b5-7a20dbdd1dc15c44ad52b43fe15add1d7253c0f6/index.html

Web 🕸️
https://95238.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-14T11:36:48Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-14T11:39:14Z

Help site review — no changes required

I reviewed the changes in this PR against Expensify's help site files under docs/articles, and no help site updates are required.

Why: This is a UI-polish fix, not a new feature or workflow. It surfaces the full-result expense count and total in the Search selection footer when Select all matching items is active for ad-hoc filter queries — server-computed totals that were already shown for saved and suggested searches. It also hides the total row when a total can't be computed (e.g. mixed-currency / grouping). No new setting, button, tab, or user-facing step is introduced.

What I checked: The only help article that describes this area, Search-and-Download-Expenses.md, references "select all" solely as a checkbox action in the export flow — it does not document the selection footer's count/total display. The related Search articles (Use-Search-Shortcuts.md, Use-Search-Operators-to-Filter-and-Analyze.md, Getting-Started-with-the-Spend-Page.md) likewise don't describe this footer behavior. Nothing in the current docs asserts something this PR contradicts, so there's nothing to update.

Because no changes are needed, I did not create a draft help site PR.

⚠️ I could not verify this in a live browser (browser control was unavailable in this run), so the assessment is based on the code diff, the linked issue, and a static review of the help-site articles.

@lorretheboy, if you believe the help site should still be updated (e.g. to newly document this footer behavior), let me know and I'll draft the PR.

jponikarchuk · 2026-07-14T13:38:13Z

Deploy Blocker #96069 was identified to be related to this PR.

lorretheboy · 2026-07-14T15:26:16Z

@jponikarchuk I think it doesn't related to this PR

jponikarchuk · 2026-07-14T18:42:03Z

Deploy Blocker #96116 was identified to be related to this PR.

OSBotify · 2026-07-16T05:13:26Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:04:19Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Enhance search functionality by integrating current search results co…

640d48e

…ntext and updating selection button text logic.

melvin-bot Bot assigned lorretheboy Jul 2, 2026

lorretheboy changed the title ~~Enhance search functionality by integrating current search results co…~~ Search: show expense count and total when "Select all matching items" is active Jul 2, 2026

lorretheboy marked this pull request as ready for review July 2, 2026 23:22

lorretheboy requested review from a team as code owners July 2, 2026 23:22

melvin-bot Bot requested review from DylanDylann and heyjennahay and removed request for a team and DylanDylann July 2, 2026 23:22

melvin-bot Bot requested review from a team, DylanDylann and luacmartins and removed request for a team July 2, 2026 23:22

melvin-bot Bot removed the request for review from a team July 2, 2026 23:22

lorretheboy mentioned this pull request Jul 2, 2026

[Due for payment 2026-08-21][$250] Search: show expense count and total when "Select all matching items" is active #94907

Closed

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/components/Search/index.tsx

Comment thread src/components/Search/SearchBulkActionsButton.tsx Outdated

DylanDylann reviewed Jul 3, 2026

View reviewed changes

Comment thread src/components/Search/SearchBulkActionsButton.tsx Outdated

Comment thread src/components/Search/SearchPageFooter.tsx Outdated

lorretheboy added 3 commits July 6, 2026 20:38

resolved conflicts

681b6ae

Enhance SearchBulkActionsButton and SearchPageFooter for better loadi…

5153244

…ng states and total calculations

fix: dup declaration

bcf489b

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread src/components/Search/SearchBulkActionsButton.tsx Outdated

DylanDylann reviewed Jul 8, 2026

View reviewed changes

Comment thread src/components/Search/SearchBulkActionsButton.tsx Outdated

lorretheboy added 3 commits July 8, 2026 22:53

Merge branch 'main' of https://github.com/Expensify/App into fix/94907

b7329df

fix: Refactor loading state handling in SearchBulkActionsButton to im…

0f63eb3

…prove spinner visibility and prevent label flicker

fix: remove comments

df43640

Merge branch 'main' of https://github.com/Expensify/App into fix/94907

86a7e9c

DylanDylann approved these changes Jul 10, 2026

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into fix/94907

864c2ab

luacmartins approved these changes Jul 10, 2026

View reviewed changes

luacmartins merged commit 9cd8836 into Expensify:main Jul 10, 2026
40 of 41 checks passed

OSBotify mentioned this pull request Jul 14, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

applause-bot Bot mentioned this pull request Jul 14, 2026

[Due for payment 2026-08-21] Spend - Total spend footer does not always appear when all expenses are selected #96116

Closed

7 tasks

quinthar added #quality labels Aug 11, 2026

yusufdeveloper2903 mentioned this pull request Aug 27, 2026

[Due for payment 2026-09-14] The Select all option on the Reports page displays the number of expenses instead of the number of reports. #99067

Closed

7 tasks

Conversation

lorretheboy commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 2, 2026

Uh oh!

melvin-bot Bot commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Jul 3, 2026

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Jul 3, 2026

Uh oh!

luacmartins commented Jul 3, 2026

Uh oh!

lorretheboy commented Jul 5, 2026

Uh oh!

lorretheboy commented Jul 7, 2026

Uh oh!

lorretheboy commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Jul 8, 2026

Uh oh!

lorretheboy commented Jul 9, 2026

Uh oh!

lorretheboy commented Jul 9, 2026

Uh oh!

luacmartins commented Jul 9, 2026

Uh oh!

lorretheboy commented Jul 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

Help site review — no changes required

Uh oh!

jponikarchuk commented Jul 14, 2026

Uh oh!

lorretheboy commented Jul 14, 2026

Uh oh!

jponikarchuk commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

lorretheboy commented Jul 2, 2026 •

edited

Loading

codecov Bot commented Jul 2, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Jul 8, 2026 •

edited

Loading