Repository navigation
Add native support for HTML tables in responses - #94926
Conversation
|
it's still on hold |
|
@dannymcclain @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dannymcclain @daledah One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41c8167f3a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Yeah that's is totally fair. Do you think we should try to do something more like this? cc @shawnborton for thoughts too. I don't think I feel super strongly one way or the other. But this version does feel a bit more in line with our other tables, and even our "simpler" tables like @dukenv0307 is styling the table like that and making the whole row clickable here feasible? Just want to know about any potential technical limitations before committing to something like that. |
|
I think that looks great and it would be awesome if we could pull it off. |
|
@shawnborton @dannymcclain it's quite complex to update the behavior above, I think we should merge this one first since it'll fix the issue here. I'll create a new issue and work on it |
Sounds good to me. We can improve this iteratively. |
|
@MelvinBot Please create a new issue to fix #94926 (comment) and assign me |
|
🤖 Created the follow-up issue and assigned you: #97247 It tracks styling the Concierge HTML table more in line with our other tables and making the whole row clickable (per this discussion), to be done iteratively after this PR merges. |
|
All yours @luacmartins |
|
@dukenv0307 please add qa steps and merge main |
|
@rushatgabhane Done |
|
@dannymcclain Does this look good from design perspective? |
|
Yes, looking good here 👍 And we'll follow up to make it even better |
mountiny
left a comment
There was a problem hiding this comment.
Code looks good to me, though it would be great to consider adding unit tests for these as well, can you explore that please and create a follow up as well @dukenv0307 ? thanks
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.47-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site content under No help site changes are required. This PR adds native rendering support for HTML tables in chat/Concierge responses (issue #94612) — tabular content now displays as a properly formatted, styled table instead of raw/unstyled markup. All changes are frontend rendering components ( This is a purely visual/presentational improvement:
Because there's no user-facing behavior change to document, I did not create a draft help site PR. If you believe a specific article should be updated (e.g., to mention table-formatted responses somewhere), let me know which one and I'll draft it. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.47-7 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Fixed Issues
$ #94612
PROPOSAL:
Tests
Show my June 2026 expenses sorted by amountOffline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari