Fix: imported contact name not shown in expense after creation by MelvinBot · Pull Request #94819 · Expensify/App

MelvinBot · 2026-06-29T10:11:54Z

Explanation of Change

When an expense is created against an imported device contact (one with no Expensify account yet), the contact's name was shown correctly during selection/confirmation but reverted to the phone number in the report header and expense detail "From" field after the expense was created.

This happened because of two independent break points, both in Expensify/App:

The contact's name was never persisted to Onyx. The optimistic personal detail built in getMoneyRequestInformation read only participant.displayName (undefined for device contacts) before falling back to the phone login. For imported contacts the name actually lives on participant.text / participant.firstName / participant.lastName, which were ignored — so the phone number got persisted.
Even a persisted name would have been ignored. getDisplayNameForParticipant short-circuits to the formatted login for any record flagged isOptimisticPersonalDetail: true, so the post-creation report views always rendered the phone number.

This PR fixes both:

getMoneyRequestInformation now builds the optimistic personal detail from the first non-empty name candidate (displayName → text → firstName + lastName), and persists firstName/lastName alongside a real displayName.
getDisplayNameForParticipant now prefers a real display name on an optimistic record before falling back to the formatted login. For invite/new-user stubs (whose optimistic displayName is set equal to the login) the resolved value is unchanged, so the original "don't fall back to Hidden when searching for a new user" behavior is preserved.

Fixed Issues

$ #94644
PROPOSAL: #94644 (comment)

Tests

On Android, open the create-expense flow and grant contacts permission.
Select an imported contact that has a name (not just a phone number).
Create the expense.
Verify the contact's name (not the phone number) is shown in the report header and the expense detail "From" field.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

On Android, open the create-expense flow and grant contacts permission.
Select an imported contact that has a name.
Create the expense.
Verify the contact's name is shown in the report header and expense detail page (and does not revert to the phone number).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: HybridApp

2026-07-07.16.41.44.mov

Android: mWeb Chrome

NA

iOS: HybridApp

2026-07-07.16.32.14.mov

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

ZhenjaHorbach · 2026-06-29T12:35:39Z

@MelvinBot
Add tests for new cases for getDisplayNameForParticipant

… cases Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

ZhenjaHorbach · 2026-07-03T09:33:35Z

@MelvinBot
Open the PR

melvin-bot · 2026-07-03T09:36:29Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-07-03T09:36:30Z

🤖 Done — this PR is now marked Ready for review (removed from draft state).

Heads up before reviewers dig in: the Tests, QA Steps, and Screenshots/Videos sections are still placeholder TODOs, and the PR Author Checklist is unchecked. Those should be filled in for the review to proceed smoothly.

melvin-bot · 2026-07-03T09:36:32Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

LGTM

MelvinBot · 2026-07-03T10:53:36Z

🤖 I looked into the failing checks — there's no code fix to push here.

The only two failing checks are:

Check	Reason
`PR Author Checklist / checklist`	`No PR Author Checklist was found`
`PR Reviewer Checklist / checklist`	`No PR Reviewer Checklist was found`

Every code and test check is passing — Bun tests, ESLint, Prettier, TypeScript typecheck, all 8 test jobs, Storybook, perf tests, and the rest.

These two checklist checks aren't code failures. They fail because the manual Author Checklist and Reviewer Checklist comments haven't been posted on the PR yet. They can only be resolved by a human completing and posting those checklists — pushing a commit won't clear them, so I'm not making any code changes.

To make these pass: the PR author posts the PR Author Checklist as a comment (or in the PR body), and the reviewer posts the Reviewer Checklist.

ZhenjaHorbach · 2026-07-06T12:33:55Z

@MelvinBot
Update the branch to the latest version of main

MonilBhavsar · 2026-07-07T12:50:01Z

@ZhenjaHorbach mind filling the author checklist?

ZhenjaHorbach · 2026-07-07T12:50:53Z

@MelvinBot
Update the branch to the latest version of main

ZhenjaHorbach · 2026-07-07T12:51:28Z

@ZhenjaHorbach mind filling the author checklist?

I will complete it today or tomorrow!

MonilBhavsar · 2026-07-07T13:01:34Z

    }

    const shouldCreateOptimisticPersonalDetails = isNewChatReport && !(personalDetails?.[payerAccountID] ?? allPersonalDetails[payerAccountID]);
+    // For imported device contacts the name is carried on `text`/`firstName`/`lastName` rather than


Suggested change

// For imported device contacts the name is carried on `text`/`firstName`/`lastName` rather than

// For imported device contacts the name is carried on text/firstName/lastName rather than

MonilBhavsar · 2026-07-07T13:01:44Z


    const shouldCreateOptimisticPersonalDetails = isNewChatReport && !(personalDetails?.[payerAccountID] ?? allPersonalDetails[payerAccountID]);
+    // For imported device contacts the name is carried on `text`/`firstName`/`lastName` rather than
+    // `displayName`, so fall back through those before defaulting to the login/phone number. Otherwise


Suggested change

// `displayName`, so fall back through those before defaulting to the login/phone number. Otherwise

// displayName, so fall back through those before defaulting to the login/phone number. Otherwise

MonilBhavsar · 2026-07-07T13:13:28Z

+    // the contact's name is lost and the optimistic record falls back to the phone number.
+    const optimisticPersonalDetailFirstName = participant.firstName ?? '';
+    const optimisticPersonalDetailLastName = participant.lastName ?? '';
+    // These fields can each be an empty string, so pick the first non-empty candidate rather than using `??`.


self explanatory or unnecessary, IMO

Suggested change

// These fields can each be an empty string, so pick the first non-empty candidate rather than using `??`.

MelvinBot · 2026-07-07T13:24:23Z

🤖 I looked into the failing checks — there's nothing to fix in the code.

The only two failing checks are:

PR Author Checklist / checklist
PR Reviewer Checklist / checklist

Every real CI check is passing — Jest (all 8 jobs), Bun tests, typecheck, ESLint, Prettier, Storybook, React Compiler, Knip, spellcheck, perf tests, and codecov.

Why the checklist checks fail: they're gated on the checkboxes in the PR body being ticked. The ### PR Author Checklist, ### Tests, and ### QA Steps sections are still unchecked/unfilled. These are human steps — I intentionally don't complete them on the author's behalf.

To clear them: ZhenjaHorbach, once you've filled out the Tests/QA steps and checked the Author Checklist boxes (and a reviewer completes their checklist), both checks will pass. No code change is needed.

MonilBhavsar · 2026-07-07T13:29:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

ZhenjaHorbach · 2026-07-07T13:48:36Z

@MelvinBot
Can you update the PR to the latest version of main and fix comments?

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

melvin-bot · 2026-07-07T13:52:18Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-07-07T13:52:48Z

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

MelvinBot · 2026-07-07T13:53:03Z

🤖 Done, ZhenjaHorbach:

Updated the branch to the latest main via a merge commit (96657ae) — the branch is now behind_by: 0. No conflicts.
Addressed MonilBhavsar's review comments in src/libs/actions/IOU/MoneyRequestBuilder.ts (commit c24a2b0):
- Removed the backticks from the two comment lines (text/firstName/lastName/displayName → plain text).
- Deleted the "These fields can each be an empty string…" comment line as unnecessary per your suggestion.

Note: I couldn't run Prettier locally (its plugin deps aren't installed in this environment), but the changes are comment-only and don't affect formatting. Please give the CI checks a look once they run.

ZhenjaHorbach · 2026-07-07T14:08:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-07-07.16.41.44.mov

Android: mWeb Chrome

NA

iOS: HybridApp

2026-07-07.16.32.14.mov

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

ZhenjaHorbach · 2026-07-07T14:45:16Z

@MelvinBot
Paste this instead of your Author Checklist

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-07.at.15.34.33.mov

MelvinBot · 2026-07-07T14:51:55Z

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-07.at.15.34.33.mov

ZhenjaHorbach · 2026-07-07T14:54:35Z

@MelvinBot
Replace your author checklist in the PR description with this one

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-07.at.15.34.33.mov

MelvinBot · 2026-07-07T15:04:01Z

🤖 Done — replaced the author checklist in the PR description with the full checklist you provided.

MonilBhavsar · 2026-07-07T15:20:57Z

Is the video correct?

ZhenjaHorbach · 2026-07-07T15:27:44Z

For Melvin's author checklist, I used a random checklist
So probably the video came out by accident 😅

MonilBhavsar · 2026-07-08T05:19:51Z

This has the correct one, mind updating it please #94819 (comment)

ZhenjaHorbach · 2026-07-13T11:26:14Z

@MelvinBot
Replace your author checklist in the PR description with this one

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: HybridApp

2026-07-07.16.41.44.mov

Android: mWeb Chrome

NA

iOS: HybridApp

2026-07-07.16.32.14.mov

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

MelvinBot · 2026-07-13T11:26:56Z

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

ZhenjaHorbach · 2026-07-13T11:29:46Z

@MelvinBot
Replace your author checklist in the PR description with this one

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: HybridApp

2026-07-07.16.41.44.mov

Android: mWeb Chrome

NA

iOS: HybridApp

2026-07-07.16.32.14.mov

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

MelvinBot · 2026-07-13T11:32:34Z

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

github-actions · 2026-07-13T11:36:37Z

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-13T11:41:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-13T11:42:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94819.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-28fe63cff2f-fbc55b5-218d6e9464304c20bbb326202daf6ace9278b7fc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-28fe63c-fbc55b5-a2aa1792c0981d50822b48a5096cf938f941bcc5/index.html

Web 🕸️
https://94819.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-14T11:36:20Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.4.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-14T11:38:19Z

HelpDot review: no help-site changes required

I reviewed the changes in this PR against Expensify's help-site articles under App/docs/articles and no documentation updates are needed.

Why: This is an internal bug fix. It corrects an optimistic-data problem where an imported device contact's name reverted to their phone number in the report header and expense "From" field after an expense was created (getMoneyRequestInformation and getDisplayNameForParticipant). It restores the expected behavior rather than adding or changing any feature, UI, setting, tab, or workflow.

Help-site articles describe user-facing flows and features at a conceptual level. The affected behavior (how a participant's display name is resolved from optimistic personal details) is not documented in any article, and the fix doesn't change any documented step. I searched App/docs/articles for references to imported/device contacts and contact-based expense creation (including Create-an-Expense.md, Split-Expenses.md, Track-Expenses.md) and found nothing describing this behavior.

Because no changes are required, I did not create a draft help-site PR, apply the HelpDot label, or assign one.

⚠️ Note: browser-based verification of the live UI was unavailable for this run, so this assessment is based on static analysis of the code changes and the existing help-site content only.

@ZhenjaHorbach, please confirm you agree that no help-site changes are required. If you believe an article should be updated, let me know which flow/article and I'll create the draft PR.

IuliiaHerets · 2026-07-14T21:10:48Z

PR was failed on Android with an original issue

cc @MonilBhavsar @JmillsExpensify

1784060444789.9afa6309-31a1-41aa-ace4-544a5a17336e.mp4

ZhenjaHorbach · 2026-07-15T09:24:00Z

But everything is working 😅
We updated optimistic data, and now, before BE responds, we have the correct contact name

And I suppose we show hidden because, by default, all non-validated accounts are hidden

OSBotify · 2026-07-16T05:12:56Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:03:49Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

MelvinBot and others added 2 commits June 29, 2026 10:05

Fix: persist imported contact name on optimistic personal detail

49a36f2

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

Use non-empty candidate name without eslint-disable

b15a39e

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot assigned ZhenjaHorbach Jun 29, 2026

MelvinBot requested a review from a team June 29, 2026 10:11

Add tests for getDisplayNameForParticipant optimistic personal detail…

1af7073

… cases Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot marked this pull request as ready for review July 3, 2026 09:36

MelvinBot requested a review from a team as a code owner July 3, 2026 09:36

melvin-bot Bot requested review from a team, JmillsExpensify and ZhenjaHorbach and removed request for a team July 3, 2026 09:36

melvin-bot Bot requested a review from MonilBhavsar July 3, 2026 09:36

melvin-bot Bot removed the request for review from a team July 3, 2026 09:36

JmillsExpensify previously approved these changes Jul 3, 2026

View reviewed changes

MonilBhavsar reviewed Jul 7, 2026

View reviewed changes

Address review comments: simplify optimistic personal detail comments

c24a2b0

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

ZhenjaHorbach approved these changes Jul 7, 2026

View reviewed changes

MonilBhavsar approved these changes Jul 13, 2026

View reviewed changes

MonilBhavsar merged commit 28fe63c into main Jul 13, 2026
44 of 45 checks passed

MonilBhavsar deleted the claude-importedContactNameLostAfterExpense branch July 13, 2026 11:35

OSBotify mentioned this pull request Jul 14, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

melvin-bot Bot mentioned this pull request Jul 16, 2026

[Due for payment 2026-07-23] [$250] Chat - Imported contact list name is not shown in the expense #94644

Closed

7 tasks

	// For imported device contacts the name is carried on `text`/`firstName`/`lastName` rather than
	// For imported device contacts the name is carried on text/firstName/lastName rather than

	// `displayName`, so fall back through those before defaulting to the login/phone number. Otherwise
	// displayName, so fall back through those before defaulting to the login/phone number. Otherwise

Conversation

MelvinBot commented Jun 29, 2026 • edited by MonilBhavsar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jun 29, 2026

Uh oh!

ZhenjaHorbach commented Jul 3, 2026

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

MelvinBot commented Jul 3, 2026

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Jul 3, 2026

Uh oh!

ZhenjaHorbach commented Jul 6, 2026

Uh oh!

MonilBhavsar commented Jul 7, 2026

Uh oh!

ZhenjaHorbach commented Jul 7, 2026

Uh oh!

ZhenjaHorbach commented Jul 7, 2026

Uh oh!

MonilBhavsar Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Jul 7, 2026

Uh oh!

MonilBhavsar commented Jul 7, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 7, 2026

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

MelvinBot commented Jul 7, 2026

Uh oh!

MelvinBot commented Jul 7, 2026

Uh oh!

ZhenjaHorbach commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 7, 2026

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Jul 7, 2026

PR Author Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 7, 2026

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Jul 7, 2026

Uh oh!

MonilBhavsar commented Jul 7, 2026

Uh oh!

ZhenjaHorbach commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MelvinBot commented Jun 29, 2026 •

edited by MonilBhavsar

Loading

ZhenjaHorbach commented Jul 7, 2026 •

edited

Loading

ZhenjaHorbach commented Jul 7, 2026 •

edited

Loading