Cleanup of screens related to old search filter routes by shubham1206agra · Pull Request #94785 · Expensify/App

shubham1206agra · 2026-06-28T14:17:45Z

Explanation of Change

Fixed Issues

$ #86254

Tests

Open App
Go to Search tab > Filters.
In wide layout, verify that the filter popup opens and we can set different types of filters.
In narrow layout, verify that the filter page opens and we can set different types of filters.

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-06-28.at.7.58.37.PM.mov

melvin-bot · 2026-06-28T14:17:50Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-28T14:21:47Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.07% <ø> (ø)`
src/ROUTES.ts	`21.20% <ø> (-0.27%)`	⬇️
src/SCREENS.ts	`100.00% <ø> (ø)`
...h/SearchPageHeader/SearchAdvancedFiltersButton.tsx	`61.90% <ø> (ø)`
src/libs/CardFeedUtils.ts	`93.59% <ø> (+0.96%)`	⬆️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.77% <ø> (+0.31%)`	⬆️
...avigation/linkingConfig/RELATIONS/SEARCH_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/libs/SearchUIUtils.ts	`64.37% <ø> (ø)`
...rsContentPage/SearchAdvancedFiltersContentBase.tsx	`0.00% <ø> (ø)`
... and 2 more
... and 11 files with indirect coverage changes

trjExpensify · 2026-06-29T10:37:21Z

PR doesn’t need product input as a clean-up PR. Unassigning and unsubscribing myself.

QichenZhu · 2026-06-29T11:37:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native.webm

Android: mWeb Chrome

android-web.webm

iOS: HybridApp

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

mac-web.mov

QichenZhu · 2026-06-29T11:42:27Z

@bernhardoj looping you in since you said in #91806:

I'm planning to remove this and its page components in the next PR.

Please let us know if this conflicts with your work. Thanks!

cc @shubham1206agra

bernhardoj · 2026-06-29T11:55:45Z

Oh, you're right. If it's not much of a trouble, I can open the PR now to clean it up and hold this one.

QichenZhu · 2026-06-29T12:01:02Z

@bernhardoj since this PR is large and likely to conflict with main, I'd prefer not to hold it if possible. Does it conflict with any of your open or draft PRs?

shubham1206agra · 2026-06-29T12:08:56Z

Oh, you're right. If it's not much of a trouble, I can open the PR now to clean it up and hold this one.

@bernhardoj Sorry, but you had ~2 weeks to open that cleanup PR. This PR is the elaborate cleanup of that old logic.

@QichenZhu Can you please approve this? I need this PR to work on a different issue.

bernhardoj · 2026-06-29T12:12:39Z

I intentionally hold the cleanup so I can easily reference the code for some follow-ups (the latest follow-up and should be the last). I'm fine if we want to handle it here.

QichenZhu · 2026-06-29T12:15:20Z

Thanks for confirming! Let's move on this one.

shubham1206agra · 2026-06-29T12:17:12Z

I intentionally hold the cleanup so I can easily reference the code for some follow-ups (the latest follow-up and should be the last). I'm fine if we want to handle it here.

Oh, then @bernhardoj can you also just go through this PR once to make sure I am not removing anything extra here?

bernhardoj · 2026-06-29T12:22:13Z


-type SearchBooleanFilterKeys = typeof CONST.SEARCH.SYNTAX_FILTER_KEYS.BILLABLE | typeof CONST.SEARCH.SYNTAX_FILTER_KEYS.REIMBURSABLE;
-
-type SearchTextFilterKeys =


We can keep this one
(code usage ref)

Finished checking them all. Only need to keep this.

@bernhardoj Can you re-define this in your PR? Cause knip check will fail otherwise :(

Yeah, sure, np

QichenZhu

LGTM other than the outstanding comment: #94785 (review).

github-actions · 2026-06-29T15:26:41Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-29T15:33:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94785.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d516575bab1-0f1cc02-33452aa9981e722cc91afcaefeadb33f5bc5dcaa/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d516575-0f1cc02-201ae6726a83e6a175740d7451beb673f003976a/index.html

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-30T12:07:22Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-07-01T19:46:09Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Cleanup of screens related to old search filter routes

ffc0c2b

shubham1206agra requested review from a team as code owners June 28, 2026 14:17

melvin-bot Bot assigned shubham1206agra Jun 28, 2026

melvin-bot Bot requested review from QichenZhu and trjExpensify June 28, 2026 14:17

melvin-bot Bot removed request for a team June 28, 2026 14:17

shubham1206agra changed the title ~~[NoQA] Cleanup of screens related to old search filter routes~~ Cleanup of screens related to old search filter routes Jun 28, 2026

Cleanup using knip

0396cf7

trjExpensify removed their request for review June 29, 2026 10:37

bernhardoj reviewed Jun 29, 2026

View reviewed changes

JS00001 self-requested a review June 29, 2026 12:41

QichenZhu approved these changes Jun 29, 2026

View reviewed changes

melvin-bot Bot requested review from Julesssss and roryabraham June 29, 2026 14:20

JS00001 approved these changes Jun 29, 2026

View reviewed changes

JS00001 merged commit d516575 into Expensify:main Jun 29, 2026
37 of 39 checks passed

OSBotify mentioned this pull request Jun 30, 2026

Deploy Checklist: New Expensify 2026-06-30 #94951

Closed

60 tasks

applause-bot Bot mentioned this pull request Jun 30, 2026

[Due for payment 2026-08-17] [$250] Concierge chat is displayed instead of Filter page when when switch narrow layout #94996

Closed

7 tasks

melvin-bot Bot mentioned this pull request Jul 1, 2026

[Due for payment 2026-07-23] [$2025] Audit unused files and exports using Knip #86254

Closed

shubham1206agra deleted the screen-cleanup branch July 7, 2026 10:56


		type SearchBooleanFilterKeys = typeof CONST.SEARCH.SYNTAX_FILTER_KEYS.BILLABLE \| typeof CONST.SEARCH.SYNTAX_FILTER_KEYS.REIMBURSABLE;

		type SearchTextFilterKeys =

Uh oh!

Conversation

shubham1206agra commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 28, 2026

Uh oh!

codecov Bot commented Jun 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Jun 29, 2026

Uh oh!

QichenZhu commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Jun 29, 2026

Uh oh!

QichenZhu commented Jun 29, 2026

Uh oh!

shubham1206agra commented Jun 29, 2026

Uh oh!

bernhardoj commented Jun 29, 2026

Uh oh!

QichenZhu commented Jun 29, 2026

Uh oh!

shubham1206agra commented Jun 29, 2026

Uh oh!

bernhardoj Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

OSBotify commented Jun 30, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shubham1206agra commented Jun 28, 2026 •

edited

Loading

codecov Bot commented Jun 28, 2026 •

edited by github-actions Bot

Loading

QichenZhu commented Jun 29, 2026 •

edited

Loading

QichenZhu commented Jun 29, 2026 •

edited

Loading