Fix withdrawal subtitle overlapping amount on mobile Bank Reconciliation list

[MelvinBot]

Explanation of Change

On the mobile Bank Reconciliation withdrawal list, each row renders the bank account name (title), a status badge + withdrawal date/ID (subtitle), and the withdrawal amount on the right. On narrow screens the subtitle text was crowding/overlapping the amount column.

The root cause: the subtitle text is wrapped in an extra horizontal flexRow (status badge + date/ID) and that TextWithTooltip had no flexShrink. A single-line text inside a row grows to its full intrinsic width and overflows past the row, clashing with the amount. The row's sibling title text doesn't hit this because it's a direct child of the column container and is stretched/truncated normally.

The fix adds styles.flexShrink1 to the subtitle TextWithTooltip so it shrinks and ellipsizes within the available space instead of overflowing — matching the pattern already used for the subtitle in the analogous MemberListItemHeader.

Fixed Issues

$ #94320
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

1. On a mobile device (or narrow web viewport), navigate to Spend > Bank Reconciliation.
2. View the list of withdrawal entries, including ones with long subtitle content (withdrawal date + withdrawal ID).
3. Verify the withdrawal amount stays clearly visible and does not overlap/crowd the subtitle.
4. Verify the subtitle truncates with an ellipsis before reaching the amount column.

• Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. On a mobile device, navigate to Spend > Bank Reconciliation.
2. View withdrawal entries with long subtitle content (withdrawal date + withdrawal ID).
3. Verify the withdrawal amount does not overlap the subtitle and that the subtitle truncates appropriately.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[shawnborton]

@MelvinBot please add sceenshots of mobile web

[github-actions]

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[shawnborton]

Seems like this is fixed:

[melvin-bot]

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[MelvinBot]

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

[JmillsExpensify]

No product review required on this one imo.

[aimane-chnaif]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #94320 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[aimane-chnaif]

@shawnborton please help filling author checklist as I don't have edit permission.

[shawnborton]

@MelvinBot please fill out the author checklist, check off all of the ones you can please.

[shawnborton]

@MelvinBot please fill out the author checklist, check off all of the ones you can please.

[shawnborton]

@MelvinBot please fill out the author checklist, check off all of the ones you can please.

[MelvinBot]

🤖 I went through the author checklist. The code-inspection items are already checked and I've verified they hold for this one-line style change. The remaining boxes all require actual device/runtime testing, screenshots, or human judgment that I can't honestly verify as an automated agent — so I've left those for the human co-author rather than checking them dishonestly.

✅ Verified / correctly checked (code inspection)

These are legitimately satisfied and I confirmed each against the diff:

• Fixed Issues linked — links Expensify/App#94320.
• Testing steps written (Tests / Offline / QA sections) — present and cover the change.
• Proper code patterns / callback naming / comments / copy — no callbacks, copy, or non-obvious code added; the change matches the existing subtitle pattern in MemberListItemHeader.tsx.
• No new CSS style added — styles.flexShrink1 already exists in src/styles/utils/flex.ts:148, so nothing new was introduced.
• No new files / no new assets.
• Markdown / generic-component / Storybook items — not applicable to this scoped layout fix (checked as N/A).

⬜️ Left for the human co-author (I can't verify these)

These require running the app on real devices or making a judgment call, so I've intentionally not checked them:

• Ran & verified tests on all platforms (Android Native, mWeb Chrome, iOS Native, mWeb Safari, MacOS Chrome/Safari).
• Screenshots/videos on all platforms.
• Verified no console errors — a single flexShrink1 addition can't introduce a runtime error, but I didn't run the app to observe it, so I'm not checking this on your behalf.
• Offline test (toggling the network) and High Traffic account test.
• Tested other components impacted by the change — the change is scoped to WithdrawalIDListItemHeader, but confirming no regressions still needs a human pass.
• Failure-scenario steps — N/A for a pure layout fix (no error/input path), so no steps were added.
• Unit tests — none added; App doesn't typically unit-test pure style tweaks, but leaving this for you to decide.

🎨 One thing to flag

This PR does modify the UI (spacing/overflow behavior on the withdrawal list). Since you're on Design, you may want to self-review the spacing change and decide whether to add the Design label — I didn't add it unilaterally.

Let me know if you'd like me to spin up the web tester to capture a before/after screenshot on a narrow viewport.

[shawnborton]

Over to you @aimane-chnaif - just need help getting videos/screenshots on all platforms. Thanks!

[MelvinBot]

I looked into the failing check. There's no code failure to fix here — every code/CI check (tests, ESLint, Prettier, typecheck, TypeScript, perf, builds, etc.) is passing.

The only failing check is PR Author Checklist / checklist, which is a human-only check, not a code failure. The log shows:

You completed 40 out of 41 checklist items with 1 unfinished items
PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

What's needed to make it pass (must be done by the human co-author):

• Fill out the Tests and QA Steps sections — they still contain the // TODO: placeholders.
• Check the remaining unchecked box(es), including the two "Verify that no errors appear in the JS console" items under Tests and QA Steps.

I can't check these boxes or fill out the Tests/QA sections on your behalf — they attest to testing a person performed. Once you complete the checklist, the check will pass on its next run.

[MelvinBot]

Nothing has changed since my previous comment — there's still no code failure to fix. Every code/CI check is passing.

The only failing check is PR Author Checklist / checklist, a human-only attestation check (not code). It fails with 40 out of 41 checklist items complete because the Tests and QA Steps sections still have // TODO: placeholders and unchecked boxes.

To make it pass, the human co-author needs to fill out the Tests/QA Steps sections and check the remaining box(es) — I can't complete those on your behalf. There's no commit for me to push here.

[MelvinBot]

Nothing has changed since my last comment — there's still no code failure to push a fix for. All CI/code checks (tests, ESLint, Prettier, typecheck, perf, builds, etc.) are passing.

The single failing check is PR Author Checklist / checklist, a human-only check. The two boxes still unchecked are the testing attestations under Tests and QA Steps:

• Verify that no errors appear in the JS console (Tests section)
• Verify that no errors appear in the JS console (QA Steps section)

These attest to testing a person performed, so I can't check them or fill out the Tests/QA sections for you. Once the human co-author completes the checklist, the check will pass on its next run. There's nothing for me to fix or push here.

[MonilBhavsar]

A one line style change so checking this off

[github-actions]

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94749.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b8ad9b66e35-6f1f532-4f36d37ea9b6f37ac083b0685edef53199c23b0a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b8ad9b6-6f1f532-43c372be8880d1bbdb4c92b4a45e99b0d48ca70a/index.html

Web 🕸️
https://94749.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.4.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 Help site review: no changes required.

This PR is a purely visual layout fix. It adds styles.flexShrink1 to the subtitle TextWithTooltip in WithdrawalIDListItemHeader.tsx so the withdrawal date/ID subtitle truncates with an ellipsis instead of overlapping the amount column on narrow screens.

There is no change to feature behavior, feature names, tab/settings labels, buttons, or user flows — nothing that the help site articles under docs/articles describe. So no draft docs PR was created.

@shawnborton, let me know if you'd still like a docs review of the Bank Reconciliation help article for any reason, but based on this diff no help site update is needed.

[OSBotify]

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android