Repository navigation
[CP Staging] Fix tag selection mode on RHP - #94600
Conversation
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@luacmartins I can still repro the issue: Monosnap.screencast.2026-06-25.21-13-28.mp4 |
|
Looking |
|
@Krishna2323 updated |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@luacmartins checkboxes are shown in the RHP, is that expected? It differs from the prod behaviour. Monosnap.screencast.2026-06-25.23-24-31.mp4 |
|
No, I don't think we want that. I'll take a look |
|
@Krishna2323 updated! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-06-25.23-49-03.mp4 |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
[CP Staging] Fix tag selection mode on RHP (cherry picked from commit e45e0d2) (cherry-picked to staging by luacmartins)
…193793919-1 🍒 Cherry pick PR #94600 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.4.19-5 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed the changes in this PR and no Help site changes are required. This is an internal bug fix in Since there's no user-facing or documented-behavior change, I did not create a draft docs PR. @luacmartins, please confirm you agree no Help site updates are needed. If you'd like a docs PR created for a specific article anyway, let me know which one. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.4.20-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Guard Table selection middleware with
useIsFocused()so a background wide tags page cannot turn off the shared mobile selection mode flag while the RHP instance is selecting.Fixed Issues
$ #94521
Tests
workspacestosettingsin the URL and open Tags in the RHP.Screen.Recording.2026-06-25.at.9.31.27.AM.mov
Offline tests
Same as Tests.
QA Steps
Same as Tests.