[CP staging] Surface AgentZero request ID in report action context menu - #94221
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 1f2c159aad3..232d3e37294 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -840,7 +840,7 @@ const translations: TranslationDeepObject<typeof en> = {
joinThread: 'Rejoindre la discussion',
leaveThread: 'Quitter la discussion',
copyOnyxData: 'Copier les données Onyx',
- copyAgentZeroRequestID: "Copier l'ID de requête AgentZero",
+ copyAgentZeroRequestID: 'Copier l’ID de demande AgentZero',
flagAsOffensive: 'Signaler comme offensant',
menu: 'Menu',
},
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 6bffb040d3a..bb83bbbf6ed 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -837,7 +837,7 @@ const translations: TranslationDeepObject<typeof en> = {
joinThread: 'Entrar na conversa',
leaveThread: 'Sair da conversa',
copyOnyxData: 'Copiar dados do Onyx',
- copyAgentZeroRequestID: 'Copiar ID de solicitação do AgentZero',
+ copyAgentZeroRequestID: 'Copiar ID da solicitação do AgentZero',
flagAsOffensive: 'Sinalizar como ofensivo',
menu: 'Menu',
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
No product review is needed, as this is strictly a staging and dev change that affects only employees. |
Gate the copy AgentZero request ID context-menu action to dev and staging only instead of all non-production environments. Co-authored-by: Cursor <cursoragent@cursor.com>
| successIcon: 'Checkmark', | ||
| shouldShow: ({type, reportAction, isDevelopment, isStaging}) => | ||
| type === CONST.CONTEXT_MENU_TYPES.REPORT_ACTION && | ||
| (isDevelopment || isStaging) && |
There was a problem hiding this comment.
Why wouldn't we do !isProduction like above with copyOnyxData? This keeps it consistent with that other very similar button.
There was a problem hiding this comment.
(Jasper's Agent) Good catch, updated to use !isProduction for consistency.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…-menu Surface AgentZero request ID in report action context menu (cherry picked from commit 4aa0163) (cherry-picked to staging by blimpich)
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.4.22-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.4.24-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.24-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.4.25-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.4.24-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds a staging/dev-only report-action context menu item, "Copy AgentZero request ID", that copies the
agentZeroRequestIDstamped on AgentZero comments (from the companion Auth PR) so internal employees can trace an AI reply. It mirrors the existing non-prod "Copy Onyx data" item and reads the ID from the comment'soriginalMessage.Fixed Issues
$
For https://github.com/Expensify/Expensify/issues/651179
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari