[luacmartins]

Explanation of Change

Migrate the policy taxes page to the shared Table component.

Fixed Issues

$ #86208

Tests

1. Open a workspace Taxes page with tax rates configured
2. Confirm name, rate value/default label, and enabled switch render
3. Tap a row → tax edit page opens
4. Select multiple rates and confirm bulk delete/enable/disable still work
5. With 12+ rates, confirm search and sorting work
6. Confirm Add rate, Settings, and accounting import banner still work

• Verify that no errors appear in the JS console

Screen.Recording.2026-06-22.at.3.28.54.PM.mov

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

[melvin-bot]

@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 683227a349

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	93.84% <ø> (ø)
src/components/SearchBar.tsx	100.00% <100.00%> (ø)
src/components/Table/TableHeader.tsx	95.52% <100.00%> (+0.06%)	⬆️
src/components/Table/TableSearchBar.tsx	100.00% <100.00%> (ø)
src/components/Switch.tsx	94.11% <50.00%> (-5.89%)	⬇️
src/components/Table/middlewares/selection.ts	53.22% <0.00%> (-1.78%)	⬇️
src/components/Table/TableRow.tsx	71.23% <0.00%> (-10.02%)	⬇️
...les/WorkspaceTaxesTable/WorkspaceTaxesTableRow.tsx	0.00% <0.00%> (ø)
src/pages/workspace/taxes/WorkspaceTaxesPage.tsx	0.00% <0.00%> (ø)
...rc/components/Tables/WorkspaceTaxesTable/index.tsx	0.00% <0.00%> (ø)
... and 20 files with indirect coverage changes

[luacmartins]

This is not ready for review yet

[luacmartins]

Ready for review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e4629165c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Krishna2323]

• When items are removed from the list optimistically, the last item does not show the bottom border radius.

• Search input focus is lost when using the toggle

input_focus_lost.mp4

• Select cursor is shown instead of disabled cursor when no items can be selected

cursor_select_shown.mp4

[luacmartins]

When items are removed from the list optimistically, the last item does not show the bottom border radius.

Screen.Recording.2026-06-23.at.12.46.13.PM.mov

Search input focus is lost when using the toggle

Screen.Recording.2026-06-23.at.12.45.47.PM.mov

Select cursor is shown instead of disabled cursor when no items can be selected

Screen.Recording.2026-06-23.at.12.47.32.PM.mov

[luacmartins]

@Krishna2323 fixed

[joekaufmanexpensify]

Good for product

[Krishna2323]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

andorid_mWeb.mp4

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

[Krishna2323]

LGTM!

[melvin-bot]

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94208.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-619d88505f4-57159c0-5a9e76122b95d83b8b99ace3a4818f116865c2e5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-619d885-57159c0-073d51066a054ca58ac09171829a6115cf40bdc0/index.html

Web 🕸️
https://94208.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.19-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[MelvinBot]

🤖 I reviewed the changes in this PR against the help site files under docs/articles.

No help site changes are required.

This PR migrates the workspace Taxes page to the shared Table component — a visual/structural refactor. The user-facing behavior is unchanged: tax rates still render with name, rate/default label, and an enabled switch; rows still open the tax edit page; bulk delete/enable/disable, search, sorting, Add rate, Settings, and the accounting import banner all behave as before.

The relevant help articles (Learn about Tracking Taxes, Track taxes) describe how tax tracking works and how to configure tax rates conceptually — none of that documented behavior changes here, so the docs remain accurate.

@luacmartins, no help site PR was created since no documentation updates are needed. Please confirm this assessment reflects the current behavior — if you'd like docs changes anyway, let me know and I'll open a draft PR.

[OSBotify]

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅