[cp staging] Disable currency selection on stag & prod - #94195
Conversation
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@marufsharifi can you review this one too please |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-22.at.9.21.38.PM.movAndroid: mWeb ChromeScreen.Recording.2026-06-22.at.9.57.47.PM.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-06-22.at.10.02.56.PM.movMacOS: Chrome / SafariScreen.Recording.2026-06-22.at.9.01.13.PM.mov |
…e-currency-on-dev
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Hi @JS00001, I noticed that the Permitted Currencies menu is hidden on the Spend Rule page, as expected. However, it is still accessible when navigating directly to its route. Could you please confirm whether this behavior is expected? Screen.Recording.2026-06-22.at.9.27.04.PM.mov |
That's fine, this is just to disable the user flows on staging. Deep linking to the page is unlikely |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…n-dev [cp staging] Disable currency selection on stag & prod (cherry picked from commit b489b0b)
…n-dev [cp staging] Disable currency selection on stag & prod (cherry picked from commit b489b0b) (cherry-picked to staging by blimpich)
…972890097-1 🍒 Cherry pick PR #94195 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.4.17-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required. This PR hides the Permitted currencies menu item from Expensify Card Spend Rules on staging and production (it now renders only when I checked the help site under Because the help site already matches the post-merge staging/production behavior (no currency option), no doc updates are needed and I have not opened a draft PR. If currency selection is later re-enabled for staging/prod, the spend rules article should be revisited to add it. @JS00001, no help site PR was created since no docs changes are required. Please confirm this assessment reflects the current behavior — if you'd like the spend rules article updated anyway, let me know and I'll open a draft PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
Explanation of Change
Disable currency selection on stag & prod for card rules to fix blockers rather than reverting
Fixed Issues
$ #94116
$ #94092
$ #94078
$ #94091
Tests
N/A
Offline tests
N/a
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)