Fix company card CSV import help link to point to spreadsheet article - #94089
Conversation
Co-authored-by: Jenna Hay <heyjennahay@users.noreply.github.com>
|
🤖 The failing Failing test: Why it's unrelated: This PR changes exactly one line — the Recommendation: Re-run the The other failing check, |
Co-authored-by: Jenna Hay <heyjennahay@users.noreply.github.com>
|
🤖 There's no code fix needed here — the only non-passing test ( Confirmed unrelated: This PR's commit changes only the Action taken: I couldn't re-run the CI job directly (insufficient token permissions), so I pushed an empty commit to re-trigger all checks. The flaky test should pass on this fresh run. The remaining |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Do you need my help here?) |
|
No, it's a trivial change the automation put a C+ on so I removed the request |
|
This is a trivial PR updating a link. We don't need an author checklist. |
|
🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.4.17-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR is a link-target fix only: it repoints The destination article already exists in
Because the article is already in place and correct, I did not open a draft docs PR. @heyjennahay, no linked help site PR was created since the destination article already exists and reflects current behavior. If you'd still like me to make any edits to that article, reply with the changes you want and I'll open a draft PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
Explanation of Change
In the company card CSV/spreadsheet import flow (
Workspace > Company cards > Import CSV), the "help guide" link pointed to the genericCompany-Card-Settingsarticle (which resolves toConfigure-Company-Card-Settings), a page with no information about importing a CSV.This updates
COMPANY_CARDS_CREATE_FILE_FEED_HELP_URLinsrc/CONST/index.tsto point to the correct article,Import-Company-Card-Transactions-From-a-Spreadsheet, which documents the spreadsheet import flow. This constant is used only by the company card spreadsheet import page (CompanyCardsImportedPage.tsx), so the change is scoped to that flow.Fixed Issues
$ #94087
PROPOSAL:
Tests
Workspace > Company cardsand start the Import CSV flow.Offline tests
N/A — static help link change.
QA Steps
Workspace > Company cardsand start the Import CSV flow.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari