Skip to content

Fix company card CSV import help link to point to spreadsheet article - #94089

Merged
justinpersaud merged 2 commits into
mainfrom
claude-fixCompanyCardCsvImportHelpLink
Jun 22, 2026
Merged

justinpersaud merged 2 commits into
mainfrom
claude-fixCompanyCardCsvImportHelpLink

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

In the company card CSV/spreadsheet import flow (Workspace > Company cards > Import CSV), the "help guide" link pointed to the generic Company-Card-Settings article (which resolves to Configure-Company-Card-Settings), a page with no information about importing a CSV.

This updates COMPANY_CARDS_CREATE_FILE_FEED_HELP_URL in src/CONST/index.ts to point to the correct article, Import-Company-Card-Transactions-From-a-Spreadsheet, which documents the spreadsheet import flow. This constant is used only by the company card spreadsheet import page (CompanyCardsImportedPage.tsx), so the change is scoped to that flow.

Fixed Issues

$ #94087
PROPOSAL:

Tests

  1. Go to Workspace > Company cards and start the Import CSV flow.
  2. On the column-mapping screen, click the "help guide" link in the helper text.
  3. Verify it opens https://help.expensify.com/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet (the spreadsheet import article), not the Configure Company Card Settings page.
  • Verify that no errors appear in the JS console

Offline tests

N/A — static help link change.

QA Steps

  1. Go to Workspace > Company cards and start the Import CSV flow.
  2. On the column-mapping screen, click the "help guide" link.
  3. Verify it opens the "Import Company Card Transactions From a Spreadsheet" help article.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Jenna Hay <heyjennahay@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 The failing test (job 7) check is unrelated to this PR.

Failing test: tests/ui/ContactMethodsPageTest.tsx › sets error indicator when login has error fields — it asserts a contact-method brick-road indicator (error-brickRoadIndicator vs none-brickRoadIndicator).

Why it's unrelated: This PR changes exactly one line — the COMPANY_CARDS_CREATE_FILE_FEED_HELP_URL help-link string in src/CONST/index.ts, used only by the company-card spreadsheet import page. It does not touch contact methods, login data, or brick-road indicator logic. The CI log also shows A worker process has failed to exit gracefully and has been force exited, pointing to a flaky teardown/timing issue rather than a real regression from this change.

Recommendation: Re-run the test (job 7) job. It should pass on retry. No code fix is warranted here.

The other failing check, PR Author Checklist / checklist, is the human-only checklist and is expected to remain unchecked until the co-author fills it out before marking the PR ready for review.

Co-authored-by: Jenna Hay <heyjennahay@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 There's no code fix needed here — the only non-passing test (test (job 7)) is an unrelated flaky failure, not a regression from this PR.

Confirmed unrelated: This PR's commit changes only the COMPANY_CARDS_CREATE_FILE_FEED_HELP_URL string in src/CONST/index.ts. The failing test is tests/ui/ContactMethodsPageTest.tsx › sets error indicator when login has error fields, which exercises contact-method brick-road indicators and Onyx login state — code this PR never touches. The CI log also shows A worker process has failed to exit gracefully and has been force exited... tests leaking due to improper teardown, the classic signature of a flaky/state-leak test.

Action taken: I couldn't re-run the CI job directly (insufficient token permissions), so I pushed an empty commit to re-trigger all checks. The flaky test should pass on this fresh run.

The remaining PR Author Checklist / checklist failure is the human-only checklist, expected to stay unchecked until the co-author completes it before marking the PR ready for review.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
... and 34 files with indirect coverage changes

@justinpersaud
justinpersaud marked this pull request as ready for review June 22, 2026 13:01
@justinpersaud
justinpersaud requested a review from a team as a code owner June 22, 2026 13:01
@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and removed request for a team June 22, 2026 13:01
@melvin-bot

melvin-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team June 22, 2026 13:01
@justinpersaud
justinpersaud removed the request for review from Eskalifer1 June 22, 2026 13:01
@justinpersaud

justinpersaud commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Eskalifer1

Copy link
Copy Markdown
Contributor

Do you need my help here?)

@justinpersaud

Copy link
Copy Markdown
Contributor

No, it's a trivial change the automation put a C+ on so I removed the request

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peazy 👍

@justinpersaud
justinpersaud merged commit f889e66 into main Jun 22, 2026
35 of 36 checks passed
@justinpersaud
justinpersaud deleted the claude-fixCompanyCardCsvImportHelpLink branch June 22, 2026 22:20
@justinpersaud

Copy link
Copy Markdown
Contributor

This is a trivial PR updating a link. We don't need an author checklist.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.4.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 No help site changes required.

This PR is a link-target fix only: it repoints COMPANY_CARDS_CREATE_FILE_FEED_HELP_URL in src/CONST/index.ts from the generic Company-Card-Settings article to Import-Company-Card-Transactions-From-a-Spreadsheet.

The destination article already exists in docs/articles and accurately documents the company card spreadsheet import flow this PR links to, so no new content or edits are needed:

  • File: docs/articles/new-expensify/connect-credit-cards/Import-Company-Card-Transactions-From-a-Spreadsheet.md
  • It already covers: who can import, the step-by-step import-from-file flow, uploading additional transactions to an existing feed, deleting a feed, supported file formats (CSV/TXT/XLS/XLSX), and required columns.
  • Its published path matches the new constant exactly, so no redirects.csv entry is needed either.

Because the article is already in place and correct, I did not open a draft docs PR.

@heyjennahay, no linked help site PR was created since the destination article already exists and reflects current behavior. If you'd still like me to make any edits to that article, reply with the changes you want and I'll open a draft PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants