Skip to content

Fix Certinia prerequisites CTA being covered by offline indicator - #94085

Merged
arosiclair merged 1 commit into
mainfrom
claude-certiniaPrerequisitesOfflineFooterPadding
Jun 22, 2026
Merged

arosiclair merged 1 commit into
mainfrom
claude-certiniaPrerequisitesOfflineFooterPadding

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

On Step 3 (OAuth) of the Certinia prerequisites flow, going offline made the Connect to Certinia CTA appear to vanish instead of staying visible but greyed‑out/disabled.

The button was not being unmounted — it was being covered by the bottom‑docked offline indicator. When the device goes offline, ScreenWrapper renders the small‑screen offline indicator with stickToBottom (position: absolute; bottom: 0), and on devices with soft‑key/gesture nav it gets an opaque background. The Certinia CTA lives in a FixedFooter pushed flush to the bottom with mtAuto, and that footer did not opt into bottom safe‑area padding, so it reserved no room for the indicator — the indicator painted directly over the disabled button.

This change adds addBottomSafeAreaPadding to the FixedFooter. Because useBottomSafeSafeAreaPaddingStyle defaults addOfflineIndicatorBottomSafeAreaPadding to the value of addBottomSafeAreaPadding, the single flag both adds safe‑area padding and reserves CONST.OFFLINE_INDICATOR_HEIGHT of space when offline — lifting the footer above the indicator so the CTA stays visible and greyed‑out. The offline‑indicator padding term is gated on isOffline, so online layout is unchanged. This matches the existing pattern used by the sibling Sage Intacct and QBD setup pages.

The isDisabled={isLastStep && isOffline} from PR #92826 is kept — both pieces are needed (one disables the button, this one keeps it visible).

Fixed Issues

$ #93285
PROPOSAL: #93285 (comment)

Tests

  • Verify that no errors appear in the JS console

Offline tests

  1. Open the Certinia prerequisites flow and navigate to Step 3 (OAuth).
  2. Turn off the network connection.
  3. Verify the Connect to Certinia CTA remains visible, greyed‑out, and cannot be interacted with (it is no longer covered by the offline indicator).

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…offline indicator does not cover the CTA

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...rtinia/prerequisites/CertiniaPrerequisitesStep.tsx 0.00% <0.00%> (ø)
... and 248 files with indirect coverage changes

@rojiphil

Copy link
Copy Markdown
Contributor

@MelvinBot In the OP, we can remove the comments within Tests and QA Steps section as the use case is related to offline scenario. Also, please tick all the PR Author checklist items. I would attach the test videos as part of reviewer checklist.

@rojiphil

Copy link
Copy Markdown
Contributor

@MelvinBot PR Author checklist is still failing. Please add and tick all the checkboxes as per the template https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md

@rojiphil

Copy link
Copy Markdown
Contributor

@MelvinBot Please mark PR as "Ready for review"

@MelvinBot
MelvinBot marked this pull request as ready for review June 20, 2026 04:39
@MelvinBot
MelvinBot requested a review from a team as a code owner June 20, 2026 04:39
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and rojiphil and removed request for a team June 20, 2026 04:39
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 20, 2026 04:39
@rojiphil

rojiphil commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
94085-android-hybrid-001.mp4
Android: mWeb Chrome
94085-mweb-chrome-001.mp4
iOS: HybridApp
94085-ios-hybrid-001.mp4
iOS: mWeb Safari
94085-mweb-safari-001.mp4
MacOS: Chrome / Safari
94085-web-chrome-001.mp4

@rojiphil rojiphil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arosiclair Code changes LGTM.
Approving for your review. Thanks.

@melvin-bot
melvin-bot Bot requested a review from arosiclair June 22, 2026 12:34

@rojiphil rojiphil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again since pr reviewer checklist failed.

@arosiclair
arosiclair merged commit 81f7120 into main Jun 22, 2026
42 of 45 checks passed
@arosiclair
arosiclair deleted the claude-certiniaPrerequisitesOfflineFooterPadding branch June 22, 2026 13:13
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 No help site changes required.

I reviewed this PR against the help site files under App/docs/articles (including the existing Certinia articles: Connect-To-Certinia.md, Configure-Certinia.md, and the Certinia troubleshooting set).

This change is a purely visual/layout bug fix — it adds addBottomSafeAreaPadding to the FixedFooter so the Connect to Certinia CTA on Step 3 (OAuth) stays visible and greyed-out instead of being painted over by the bottom-docked offline indicator. It does not:

  • introduce or rename any feature, tab, setting, or button,
  • change any documented workflow or steps, or
  • alter any user-facing behavior that the help articles describe.

The existing Certinia connection docs already describe how to connect and configure the integration, and none of them reference the offline-indicator layout behavior this PR touches. So there's nothing to update on the help site, and no draft docs PR was created.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants