[No QA] Move sentry size analysis upload to deploy step by rinej · Pull Request #94039 · Expensify/App

rinej · 2026-06-19T11:50:46Z

Explanation of Change

The previous setup uploaded on every staging build, which blew Sentry's free 100 size-analysis quota in couple of days. Uploading once per production-bound version will stay under quota.

Details:

Added new jobs androidUploadSentry / iosUploadSentry in deploy.yml, gated on DEPLOY_ENV == 'production' && IS_RELEASE_READY.
Shared logic extracted into a composite action .github/actions/composite/uploadSentrySizeAnalysis.
Binary source:
- Cherry-pick prod deploys (which build natively in the same run) → actions/download-artifact
- Re-promotion prod deploys (no native build) → gh release download from -staging
Sentry URLs flow into the existing "Bundle Size Analysis (Sentry)" section of the deploy PR comment.
Removed the inline Sentry upload step from buildAndroid.yml and buildIOS.yml.

Fixed Issues

$ #82850
PROPOSAL: #82850 (comment)

Tests

First staging deploy:

Open the deploy.yml workflow run for the deploy. Confirm:
androidUploadSentry and iosUploadSentry jobs are skipped (gated on DEPLOY_ENV == 'production')
Deploy PR comments do not contain a "Bundle Size Analysis (Sentry)" section

First production deploy:

Open the deploy.yml workflow run. Confirm:
androidUploadSentry and iosUploadSentry jobs both ran (✅ green)
The "Download binary from the staging GitHub Release" step in each succeeded
The "Upload to Sentry" step emitted ::notice::Android Sentry size analysis: https://expensify.sentry.io/preprod/size/ and the same for iOS
Open the deploy PR comment. Confirm:
- A "Bundle Size Analysis (Sentry):" section appears
- Both Android and iOS links are present

Sentry dashboard verification (once quota resets / available):

Go to https://expensify.sentry.io/explore/releases/?environment=production&statsPeriod=90d&tab=mobile-builds and confirm the uploaded build appears

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-06-19T11:56:45Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c102de1ab4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-19T12:02:49Z

+    - name: Upload to Sentry
+      id: upload
+      if: ${{ hashFiles(inputs.asset-name) != '' }}
+      continue-on-error: true


Prevent optional Sentry uploads from failing deploy

In production deploys where npx sentry-cli build upload stalls or the new upload job hits its 10-minute job timeout, the whole androidUploadSentry/iosUploadSentry job fails even though this step is marked continue-on-error; job-level timeouts are not covered by the step's error handling. The old build-workflow upload had a step-level timeout with continue-on-error, so Sentry outages could not flip an otherwise successful deploy red. Please keep the timeout/error handling at the upload step (or make the job non-blocking) so size analysis remains optional.

Useful? React with 👍 / 👎.

…-deploy-step

roryabraham · 2026-06-25T21:13:59Z

+      uses: ./.github/actions/composite/setupNode
+
+    - name: Download binary from current workflow run (cherry-pick path)
+      if: ${{ inputs.is-cherry-pick == 'true' }}


NAB ${{ }} isn't necessary on if

roryabraham · 2026-06-25T21:16:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-06-25T21:51:30Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.20-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2026-06-25T22:15:09Z

@roryabraham @rinej Is there anything for us to QA here? It seems internal

roryabraham · 2026-06-25T23:20:54Z

No QA

OSBotify · 2026-06-26T19:23:24Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

rinej added 6 commits June 18, 2026 17:22

add sentry upload for prod only

f5808d4

remove previous action comments

f8edaa8

add the deploy comments with sentry urls

2ab2350

refactor: extract Sentry size-analysis upload into composite action

bc46a6b

fix spellings

9b0d8e9

Merge branch 'main' into move-sentry-upload-to-deploy-step

c102de1

melvin-bot Bot assigned rinej Jun 19, 2026

rinej marked this pull request as ready for review June 19, 2026 11:56

rinej requested a review from a team as a code owner June 19, 2026 11:56

rinej mentioned this pull request Jun 19, 2026

[Due for payment 2026-07-03] Set up Sentry release size analysis #82850

Closed

melvin-bot Bot requested review from mollfpr and removed request for a team June 19, 2026 11:56

chatgpt-codex-connector Bot reviewed Jun 19, 2026

View reviewed changes

rinej added 2 commits June 22, 2026 12:04

add continue on error for sentry upload

0a43d19

Merge remote-tracking branch 'origin/main' into move-sentry-upload-to…

9085b3a

…-deploy-step

roryabraham approved these changes Jun 25, 2026

View reviewed changes

roryabraham merged commit ad422ed into Expensify:main Jun 25, 2026
13 of 14 checks passed

OSBotify mentioned this pull request Jun 25, 2026

Deploy Checklist: New Expensify 2026-06-25 #94631

Closed

60 tasks

roryabraham changed the title ~~Move sentry size analysis upload to deploy step~~ [No QA] Move sentry size analysis upload to deploy step Jun 25, 2026

Beamanator mentioned this pull request Aug 20, 2026

[CI] Surface and fix recurrent iOS Sentry size-analysis upload failures #99083

Open

Navigation Menu

Uh oh!

[No QA] Move sentry size analysis upload to deploy step - #94039

[No QA] Move sentry size analysis upload to deploy step#94039
roryabraham merged 8 commits into
Expensify:mainfrom
callstack-internal:move-sentry-upload-to-deploy-step

rinej commented Jun 19, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 19, 2026

Uh oh!

roryabraham Jun 25, 2026

Uh oh!

roryabraham commented Jun 25, 2026

Uh oh!

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

mvtglobally commented Jun 25, 2026

Uh oh!

roryabraham commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rinej commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Jun 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

mvtglobally commented Jun 25, 2026

Uh oh!

roryabraham commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rinej commented Jun 19, 2026 •

edited

Loading