[NoQA] Fix flaky pushTransactionAutoSelectionsOnyxData unit tests by mountiny · Pull Request #93962 · Expensify/App

mountiny · 2026-06-18T18:03:01Z

Explanation of Change

The pushTransactionAutoSelectionsOnyxData tests were flaky because they populated Onyx and then read policy state through renderHook(usePolicyData), which depends on async Onyx subscriptions and derived values. Under CI load, stale or incomplete hook data could make the test think only one enabled category remained, causing a spurious auto-selection.

These tests exercise pure ReportUtils logic, so they now build a PolicyData object inline (same approach as tests/perf-test/ReportUtils.perf-test.ts) instead of going through usePolicyData. The adjacent pushTransactionViolationsOnyxData test was updated the same way for consistency.

Fixed Issues

$ #93921
$ #94051
PROPOSAL:

Tests

Run npx jest tests/unit/ReportUtilsTest.ts -t "pushTransactionAutoSelectionsOnyxData|pushTransactionViolationsOnyxData" --runInBand and verify all 6 tests pass.
Run the flaky test 10 times to confirm stability: for i in {1..10}; do npx jest tests/unit/ReportUtilsTest.ts -t "does not auto-select when more than one enabled category remains" --runInBand --silent || break; done

Verify that no errors appear in the JS console

Offline tests

N/A — test-only change with no product behavior impact.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — test-only change.

Android: mWeb Chrome

N/A — test-only change.

iOS: Native

N/A — test-only change.

iOS: mWeb Safari

N/A — test-only change.

MacOS: Chrome / Safari

N/A — test-only change.

Build PolicyData inline instead of reading it through usePolicyData so tests no longer depend on async Onyx subscriptions and leaked state. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot · 2026-06-18T18:03:10Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Transaction does not include policyID, which caused typecheck failures on the PR. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove unused imports and rename buildPolicyData parameter to avoid shadowing the outer policy variable. Co-authored-by: Cursor <cursoragent@cursor.com>

randWord() can return duplicate words, collapsing the categories map to fewer than requested and flipping count-sensitive auto-selection asserts. Append the index suffix, matching createRandomPolicyTags. Co-authored-by: Cursor <cursoragent@cursor.com>

mountiny · 2026-06-19T12:52:07Z

@codex review

chatgpt-codex-connector · 2026-06-19T12:56:09Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 70e12e1a0c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

youssef-lr · 2026-06-19T19:13:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

OSBotify · 2026-06-22T23:28:23Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-23T22:00:37Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-23T23:39:07Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Fix flaky pushTransactionAutoSelectionsOnyxData unit tests

72f9e94

Build PolicyData inline instead of reading it through usePolicyData so tests no longer depend on async Onyx subscriptions and leaked state. Co-authored-by: Cursor <cursoragent@cursor.com>

mountiny requested a review from a team as a code owner June 18, 2026 18:03

melvin-bot Bot assigned mountiny Jun 18, 2026

melvin-bot Bot requested review from rojiphil and removed request for a team June 18, 2026 18:03

Remove invalid policyID from Transaction test fixtures

7613fa0

Transaction does not include policyID, which caused typecheck failures on the PR. Co-authored-by: Cursor <cursoragent@cursor.com>

mountiny force-pushed the fix/flaky-pushTransactionAutoSelections-test-93921 branch from f988c3c to 7613fa0 Compare June 18, 2026 18:25

mountiny and others added 2 commits June 19, 2026 11:22

Fix ESLint errors in ReportUtilsTest auto-selection tests

e26b5be

Remove unused imports and rename buildPolicyData parameter to avoid shadowing the outer policy variable. Co-authored-by: Cursor <cursoragent@cursor.com>

mountiny removed the request for review from rojiphil June 19, 2026 12:52

mountiny requested a review from madmax330 June 19, 2026 13:15

mountiny mentioned this pull request Jun 19, 2026

Investigate workflow job failing on main: test / test (job 2) #94084

Closed

youssef-lr approved these changes Jun 19, 2026

View reviewed changes

mountiny merged commit 50d7684 into main Jun 19, 2026
29 checks passed

mountiny deleted the fix/flaky-pushTransactionAutoSelections-test-93921 branch June 19, 2026 19:17

mountiny changed the title ~~Fix flaky pushTransactionAutoSelectionsOnyxData unit tests~~ [NoQA] Fix flaky pushTransactionAutoSelectionsOnyxData unit tests Jun 19, 2026

OSBotify mentioned this pull request Jun 22, 2026

Deploy Checklist: New Expensify 2026-06-22 #94222

Closed

This was referenced Jun 23, 2026

[Due for payment 2026-06-30] Investigate workflow job failing on main: test / test (job 2) #93921

Closed

[Due for payment 2026-06-30] Investigate workflow job failing on main: test / test (job 2) #94051

Closed

Navigation Menu

Uh oh!

[NoQA] Fix flaky pushTransactionAutoSelectionsOnyxData unit tests - #93962

[NoQA] Fix flaky pushTransactionAutoSelectionsOnyxData unit tests#93962
mountiny merged 4 commits into
mainfrom
fix/flaky-pushTransactionAutoSelections-test-93921

mountiny commented Jun 18, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jun 18, 2026

Uh oh!

mountiny commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 19, 2026

Uh oh!

youssef-lr commented Jun 19, 2026

Uh oh!

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mountiny commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 18, 2026

Uh oh!

mountiny commented Jun 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 19, 2026

Uh oh!

youssef-lr commented Jun 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mountiny commented Jun 18, 2026 •

edited

Loading