Repository navigation
CopyPolicySettings: add missing rules and categories fields - #93936
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Add defaultReimbursable, disabledFields, glCodes, and customRules to the rules part optimistic update fields. Add requiresCategory to the categories part. Matches the new fields being copied on the Auth side.
a801054 to
014690f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a801054b2a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@fedirjh can you please review this, the BE pr was merged a while ago but this got off my radar, dont think we need c+ for this small review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b179cdca7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
bump @fedirjh |
|
On it |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariCleanShot.2026-07-28.at.18.14.51.mp4 |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.46-0 🚀
|
Help site review — no docs changes requiredI reviewed the changes in this PR against the help site articles under Conclusion: No help site update is needed, so I did not create a draft PR. WhyThis PR is a purely technical/optimistic-update change:
The only related help article is Those selectable categories are unchanged by this PR — the article does not (and by design should not) enumerate the individual sub-fields within each category. The change only makes the copy behavior more complete and immediate for fields already inside the Categories and Rules groups, so nothing in the documented feature surface becomes inaccurate. @ishpaul777, please confirm you agree no help site changes are needed here. If you think the article should call out any of these specific settings (e.g. GL codes, custom expense policy text, default reimbursable) as part of what Rules/Categories copies, let me know and I'll draft the update. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
5 participants
Explanation of Change
Companion App change for Auth #22338 (already merged).
Extends the optimistic update field lists in
CopyPolicySettings.tsto match the fields copied on the backend:categoriespart: addsrequiresCategoryrulespart: addsdefaultReimbursable,disabledFields,glCodes, andcustomRules(the last was already copied by Auth but missing from the App's optimistic fields, so the client relied on the server push)Fixed Issues
$ https://github.com/Expensify/Expensify/issues/650099
PROPOSAL:
Tests
Automated tests
No new App tests needed - the change is purely additive to the field lists used for optimistic state updates. The Auth test suite covers the backend copy behavior.
Manual tests
Offline tests
N/A - this change only affects optimistic update field lists and has no offline-specific behavior.
QA Steps
Auth PR is already deployed. This App change only makes the newly copied fields show up immediately in Onyx after Copy settings (instead of waiting for a full policy refresh).
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari