[NO QA] Fix Travel "Let's go" dead-end for half-provisioned workspaces by blimpich · Pull Request #93862 · Expensify/App

blimpich · 2026-06-17T18:08:13Z

Explanation of Change

When an admin is on the workspace Travel settings page for a workspace that's been provisioned for Travel but hasn't accepted the Travel terms yet, clicking "Let's go" sends them to the not-found page instead of the Travel terms page.

This PR routes them correctly:

validated admin → straight to the accept-terms page
unvalidated admin → verify account first, then the accept-terms page

Part of https://github.com/Expensify/Expensify/issues/645887. The Auth companion PR (Expensify/Auth blimpich-spotnanaSelfManagerFix) fixes the underlying provisioning failure that creates this half‑provisioned state.

Fixed Issues

https://github.com/Expensify/Expensify/issues/645887
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

– written by Claude on Ben's behalf

codecov · 2026-06-17T18:13:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/BookTravelButton.tsx	`73.56% <100.00%> (+71.21%)`	⬆️
... and 117 files with indirect coverage changes

blimpich · 2026-06-17T18:39:40Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40f8b403f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ng-domain block check

melvin-bot · 2026-06-18T22:25:32Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d89d6cedf5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-18T22:30:10Z

+            // Send the default so the Travel-access check runs against the workspace owner's domain, not the acting admin's.
+            if (!isUserValidated) {
+                setTravelProvisioningNextStep(createDynamicRoute(DYNAMIC_ROUTES.TRAVEL_TCS.getRoute(CONST.TRAVEL.DEFAULT_DOMAIN, activePolicyID)));
+                Navigation.navigate(ROUTES.TRAVEL_VERIFY_ACCOUNT.getRoute(CONST.TRAVEL.DEFAULT_DOMAIN, activePolicyID, Navigation.getActiveRoute()));


Preserve the terms redirect after validation

When the half-provisioned admin is unvalidated and not in the isTravelVerified beta, this sends them through Travel/VerifyAccountPage, but that page only uses travelProvisioning.nextStepRoute when the beta is enabled; otherwise navigateForwardTo is undefined and validation calls requestTravelAccess() then goes back. In that context the saved terms route is ignored, so after OTP the user still never reaches the accept-terms screen and the workspace remains stuck/reviewing.

Useful? React with 👍 / 👎.

if the beta is not enabled they have to requesttravelaccess, so I think this is working as intended, but if you want to check it out @blimpich

blimpich · 2026-06-18T22:59:31Z

please ignore the ping @flaviadefaria @madmax330

rlinoz · 2026-06-19T12:49:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-06-22T17:37:05Z

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-22T17:41:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-22T17:45:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93862.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4d59bba8a57-f5c607c-3f178e943350bc06c325449a86c3466c8d417250/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4d59bba-f5c607c-022380da4c7f1619203b83024bcc38d5293dbcd6/index.html

Web 🕸️
https://93862.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-22T23:27:59Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-22T23:29:40Z

🤖 Help site review: no changes required

I reviewed the changes in this PR against the help site files under docs/articles (focusing on the Travel hub) and concluded that no documentation updates are needed, so I did not open a docs PR.

Why: This is an internal navigation/routing bug fix. It corrects where a Workspace Admin lands after clicking Let's go on a workspace that is provisioned for Travel but hasn't accepted the Travel terms yet — routing a validated admin straight to the accept-terms screen, and sending an unvalidated admin to verify their account first. Previously this path dead-ended on a not-found page.

The fix only restores the expected flow; it adds no new feature, setting, button, or label. The existing Travel articles (e.g. Enable Expensify Travel on a workspace) document how to enable Travel and the post-enable experience, and they never described the buggy not-found behavior — so there is nothing in the published docs to correct or add.

If you'd like a doc that explicitly walks through accepting the Travel terms (the "Let's go" → accept-terms step), let me know and I can draft one.

@blimpich, no help site PR was created because no documentation changes are required for this fix. If you disagree and want a docs update, reply with the specifics and I'll open a draft PR.

OSBotify · 2026-06-23T22:00:13Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-23T23:38:43Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Fix Travel Let's go dead-end for half-provisioned workspaces

40f8b40

melvin-bot Bot assigned blimpich Jun 17, 2026

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/components/BookTravelButton.tsx Outdated

blimpich added 3 commits June 17, 2026 11:50

Add BookTravelButton tests for provisioned workspace routing

32b604b

Use default domain sentinel for provisioned travel terms to avoid wro…

0866f53

…ng-domain block check

Simplify Travel default-domain comment

d89d6ce

blimpich marked this pull request as ready for review June 18, 2026 22:25

blimpich requested review from a team as code owners June 18, 2026 22:25

blimpich requested a review from rlinoz June 18, 2026 22:25

melvin-bot Bot requested review from flaviadefaria and madmax330 and removed request for a team June 18, 2026 22:25

melvin-bot Bot removed the request for review from a team June 18, 2026 22:25

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

blimpich removed request for flaviadefaria and madmax330 June 18, 2026 22:59

rlinoz approved these changes Jun 19, 2026

View reviewed changes

blimpich merged commit 4d59bba into main Jun 22, 2026
41 of 42 checks passed

blimpich deleted the blimpich-travelLetsGoNotFound branch June 22, 2026 17:35

blimpich changed the title ~~Fix Travel "Let's go" dead-end for half-provisioned workspaces~~ [NO QA] Fix Travel "Let's go" dead-end for half-provisioned workspaces Jun 22, 2026

OSBotify mentioned this pull request Jun 22, 2026

Deploy Checklist: New Expensify 2026-06-22 #94222

Closed

Conversation

blimpich commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blimpich commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

rlinoz Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

blimpich commented Jun 18, 2026

Uh oh!

rlinoz commented Jun 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

MelvinBot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

blimpich commented Jun 17, 2026 •

edited

Loading

codecov Bot commented Jun 17, 2026 •

edited by github-actions Bot

Loading