Skip to content

[No QA] Docs updates for E/A#80449 invite new users in approval workflow - #93612

Merged
RachCHopkins merged 2 commits into
mainfrom
docs-approval-workflow-invite-80449
Jun 24, 2026
Merged

RachCHopkins merged 2 commits into
mainfrom
docs-approval-workflow-invite-80449

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Documents the new behavior from #80449, which lets admins invite a user who isn't yet a workspace member directly from the Expenses from step of the Add approval workflow flow.

What changed

  • Updated the Set a Custom Workflow for Specific Members steps in Add-Approvals.md to note that on the Expenses from page you can type a non-member's email, select them, and click Invite on the Invite new member screen to add them and continue the workflow.
  • Added retrieval keywords for inviting members to an approval workflow.
  • Added a screenshot placeholder for the invite step.

Verified against the UI

All labels verified against src/languages/en.ts: Add approval workflow, Expenses from, Next, Invite new member, Invite.

Related PR: #80449

@twilight2294, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Rutika Pawar <twilight2294@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 15, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#80449 invite new users in approval workflow [No QA] Docs updates for E/A#80449 invite new users in approval workflow Jun 15, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review June 19, 2026 21:45
@stephanieelliott
stephanieelliott self-requested a review as a code owner June 19, 2026 21:45
Comment thread docs/articles/new-expensify/workspaces/Add-Approvals.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused update to Add-Approvals.md, documenting the new ability to invite a non-member directly from the Expenses from step of the Add approval workflow flow (per Expensify/App PR 80449). The change touches two procedural steps and the keywords metadata. The proposed lines are well written and UI-accurate.

Scores Summary

  • Readability: 9/10 - The revised steps 3 and 4 are clear, sequential, and action-oriented. The conditional flow ("If you selected someone who isn't a workspace member...") is explained cleanly without breaking the step structure.
  • AI Readiness: 8/10 - Added keywords (invite member to approval workflow, invite new user approval workflow) reflect realistic search intent and improve retrieval. The change uses full feature names. No new headings were introduced, so heading hierarchy is unaffected by this diff.
  • Style Compliance: 9/10 - All referenced UI labels are bolded and use exact Sentence case matching the product UI: Expenses from, Next, Invite new member, Invite. Navigation phrasing is preserved. Terminology (member, workspace) is consistent with conventions.

Key Findings

  • The two modified steps follow the Step Formatting Standard well: sequential, clear, and aligned with the actual UI flow.
  • Button/label naming fully complies with the naming conventions (exact text, bold, no quotes, correct casing).
  • The added keywords are search-aligned and strengthen AI retrieval.
  • The PR description states a screenshot placeholder was added, but the diff contains no SCREENSHOT HTML-comment block. Either add one in the documented HTML-comment format (Authoring Guidelines Section 8) or update the PR description to match.
  • Minor: "To route expenses from someone who isn't a workspace member yet" is slightly informal but acceptable and clear.

Recommendations

  • Reconcile the screenshot discrepancy: add a non-rendered SCREENSHOT HTML-comment placeholder for the Invite new member confirmation state immediately after step 4, or remove that claim from the PR description.
  • No blocking issues with the proposed changes. Pre-existing file-level items (multiple top-level headings and missing internalScope) are outside this PR's scope and not scored here.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Add-Approvals.md - Steps 3-4 of "Set a Custom Workflow for Specific Members" updated and keywords expanded. Changes are accurate and compliant; only the missing screenshot placeholder needs attention.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://22c75e7d.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott requested a review from a team June 20, 2026 04:05
@melvin-bot

melvin-bot Bot commented Jun 20, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @RachCHopkins

@melvin-bot
melvin-bot Bot requested review from RachCHopkins and removed request for a team June 20, 2026 04:05
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@RachCHopkins RachCHopkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice feature.

@RachCHopkins
RachCHopkins merged commit a066981 into main Jun 24, 2026
15 checks passed
@RachCHopkins
RachCHopkins deleted the docs-approval-workflow-invite-80449 branch June 24, 2026 06:31
@OSBotify OSBotify mentioned this pull request Jun 24, 2026
69 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/RachCHopkins in version: 9.4.19-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants