Repository navigation
[NoQA] Restore render timer on performance tests - #93573
Merged
cristipaval merged 1 commit intoJun 24, 2026
Merged
cristipaval merged 1 commit into
cristipaval merged 1 commit into
Conversation
LukasMod
force-pushed
the
test/restore-performance-timer
branch
from
June 15, 2026 11:09
87da0e8 to
8fc0020
Compare
Contributor
Author
|
Before (actions for other PRs) example: https://github.com/Expensify/App/actions/runs/27538652971/job/81396123168 With this change: |
This was referenced Jun 15, 2026
LukasMod
changed the title
53 tasks done
LukasMod
marked this pull request as ready for review
June 17, 2026 13:46
melvin-bot
Bot
requested review from
abdulrahuman5196
and removed request for
a team
June 17, 2026 13:46
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fc002028f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| doNotFake: ['nextTick'], | ||
| // `nextTick` is never faked because Onyx notifies its subscribers on process.nextTick. | ||
| // `performance` is left real only for perf runs (see isPerfTestRun above). | ||
| doNotFake: isPerfTestRun ? ['nextTick', 'performance'] : ['nextTick'], |
There was a problem hiding this comment.
In PRs that contain this migration, the Reassure workflow does not run the same Jest config for the two samples: I checked .github/workflows/reassurePerformanceTests.yml, where the baseline job force-checks out origin/$BASELINE_BRANCH before npx reassure --baseline (lines 21-30), while the branch job runs this checkout (lines 50-55). That means this new doNotFake only applies to the current sample; the baseline sample still has the old fake performance clock and records [render] durations as 0, so the comparison is non-zero real durations vs zeroed baselines and the perf result is invalid for the change that restores timing. Please ensure both sides use the same timer behavior during this migration.
Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment.
main is a baseline branch so it needs to land to work
Contributor
|
Checking now |
Contributor
|
@LukasMod To confirm does this need C+ review? |
Contributor
Author
|
@abdulrahuman5196 Why not, but Its very short config change. Im more worried how stable our current test suite is after this will be merged and we will have new baseline with real values |
Contributor
Author
|
@abdulrahuman5196 Any news? Btw duration check is only ever reached for entries that already had a count change in CI script. It should be more stable then it looks in raw local tests. cc: @cristipaval |
Contributor
|
Hi, Will check and provide update before EOD |
Contributor
|
Checking now |
Contributor
|
Ran the comparison locally with and without the changes Performance Comparison Report
Significant Changes To DurationShow entries
Show details
Meaningless Changes To DurationShow entries
Show details
Render Count ChangesThere are no entries Render Issues
Added EntriesThere are no entries Removed EntriesThere are no entries |
Contributor
Thank you. I think the CI shouldn't be blocked due to the compare changes showing infinity since the baseline is 0 for render cases. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
abdulrahuman5196
approved these changes
Jun 23, 2026
abdulrahuman5196
left a comment
abdulrahuman5196
left a comment
Contributor
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @cristipaval
🎀 👀 🎀
C+ Reviewed
cristipaval
approved these changes
Jun 24, 2026
Contributor
|
🚧 cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
69 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.4.19-1 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Currently all [render] times show 0 duration in tests:
performance, which React's Scheduler captures once at module load — zeroing every React Profiler render duration and making Reassure[render]measurements meaningless.perf-test/__perf__) and addperformancetodoNotFakefor those runs only, leaving normal unit tests (which rely on faked timers) unchanged.Fixed Issues
$ #93819
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari