Migrate useSearchSelector.base.ts from useOptionsList to usePersonalDetailOptions (part 4) by shubham1206agra · Pull Request #93544 · Expensify/App

shubham1206agra · 2026-06-14T13:27:23Z

Explanation of Change

Fixed Issues

$ #82191

Tests

Test 1:

Open App
Open any chat where you can add tasks.
Click on + > Assign Task
Enter title and go next.
Click on Assignee menu.
Verify that all options are displayed correctly and searching and selecting works fine.

Test 2:

Open App
Go to Account Tab > Profile.
Click on Status > Vacation Delegate
Verify that all options are displayed correctly and searching and selecting works fine.

Test 3:

Open App
Go to Account Tab > Copilot.
Click on Add copilot.
Verify that all options are displayed correctly and searching and selecting works fine.

Test 4:

Pre-req: Do Onyx.merge('account', {isApprovedAccountant: true}); on the console before proceeding.

Open App
Go to Workspace tab
Click on New > Owner menu.
Verify that all options are displayed correctly and searching and selecting works fine.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-06-14.at.5.38.37.PM.mov

Screen.Recording.2026-06-14.at.6.04.28.PM.mov

Screen.Recording.2026-06-14.at.6.08.59.PM.mov

Screen.Recording.2026-06-14.at.6.44.35.PM.mov

…etailOptions (part 4)

melvin-bot · 2026-06-14T13:27:29Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-14T13:30:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/tasks/TaskAssigneeSelectorModal.tsx	`0.00% <0.00%> (ø)`
.../settings/Security/AddDelegate/AddDelegatePage.tsx	`0.00% <0.00%> (ø)`
...ponents/BaseVacationDelegateSelectionComponent.tsx	`0.00% <0.00%> (ø)`
...rkspace/WorkspaceConfirmationOwnerSelectorPage.tsx	`0.00% <0.00%> (ø)`
... and 13 files with indirect coverage changes

JmillsExpensify

No product review required.

hoangzinh · 2026-06-15T16:31:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-17.at.21.06.11.mov

Android: mWeb Chrome

Screen.Recording.2026-06-17.at.20.53.28.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-06-17.at.21.08.04.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-17.at.20.42.11.mp4

hoangzinh · 2026-06-17T11:04:54Z

Code changes LGTM. I'm going to test PR

hoangzinh

🚢

github-actions · 2026-06-17T15:03:34Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-17T15:06:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-17T15:10:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93544.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-41f09bc7d3e-86e5643-ecabc6a6b544e618038f56455fbfea853fea3348/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-41f09bc-86e5643-5dae3bf673d287e65a75ee28d3b9c7e6dd21dcb8/index.html

Web 🕸️
https://93544.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-17T18:43:04Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-17T18:44:49Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles.

This PR is a pure internal refactor — it migrates four selector surfaces from the useSearchSelector hook to usePersonalDetailSearchSelector:

src/components/BaseVacationDelegateSelectionComponent.tsx
src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx
src/pages/tasks/TaskAssigneeSelectorModal.tsx
src/pages/workspace/WorkspaceConfirmationOwnerSelectorPage.tsx

The user-facing behavior of these selectors (searching, selecting, and displaying recents/contacts/invite options) is unchanged — only the underlying hook and section-building logic were swapped. There are no new features, renamed labels, changed tab names, or altered user flows.

Since the help site documents user-facing product behavior — not internal hook implementations — no documentation updates are needed, and I have not created a draft docs PR.

@shubham1206agra, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

(Note: no help site PR was created, since this refactor introduces no user-facing changes. If you believe a specific article is affected, let me know which one and I'll take another look.)

OSBotify · 2026-06-18T00:19:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.12-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-18T00:21:28Z

🤖 I reviewed the changes in this PR to determine whether any help site updates under App/docs/articles are required.

No help site changes are required.

This is an internal code refactor that migrates four selector screens from useSearchSelector/useOptionsList to usePersonalDetailSearchSelector/usePersonalDetailOptions:

src/components/BaseVacationDelegateSelectionComponent.tsx
src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx
src/pages/tasks/TaskAssigneeSelectorModal.tsx
src/pages/workspace/WorkspaceConfirmationOwnerSelectorPage.tsx

The change swaps the underlying option-fetching hook and reorganizes how sections are built, but the user-facing behavior of the affected flows (Assign task assignee, Vacation delegate, Copilot/Add delegate, and Workspace owner selectors) is intentionally unchanged — every test step only verifies that "options are displayed correctly and searching and selecting works fine." There are no new features, renamed labels, tabs, settings, or workflow changes that the help site documents.

Since no documented behavior changed, I did not create a draft docs PR.

OSBotify · 2026-06-18T03:04:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.14-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-18T17:15:30Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Migrate useSearchSelector.base.ts from useOptionsList to usePersonalD…

fefddd2

…etailOptions (part 4)

shubham1206agra requested review from a team as code owners June 14, 2026 13:27

melvin-bot Bot assigned shubham1206agra Jun 14, 2026

melvin-bot Bot requested review from JmillsExpensify and hoangzinh and removed request for a team and hoangzinh June 14, 2026 13:27

JmillsExpensify reviewed Jun 14, 2026

View reviewed changes

hoangzinh approved these changes Jun 17, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny June 17, 2026 14:13

mountiny approved these changes Jun 17, 2026

View reviewed changes

mountiny merged commit 41f09bc into Expensify:main Jun 17, 2026
35 of 36 checks passed

OSBotify mentioned this pull request Jun 17, 2026

Deploy Checklist: New Expensify 2026-06-17 #93863

Closed

67 tasks

melvin-bot Bot mentioned this pull request Jun 18, 2026

Migrate useSearchSelector.base.ts from useOptionsList to useFilteredOptions #82191

Closed

shubham1206agra deleted the refactor-useSearchSelector-4 branch July 7, 2026 10:56

MelvinBot mentioned this pull request Jul 30, 2026

[Due for payment 2026-07-30] [Tracking] Remove OptionListContextProvider and migrate all consumers to useFilteredOptions #82193

Closed

12 tasks

Conversation

shubham1206agra commented Jun 14, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 14, 2026

Uh oh!

codecov Bot commented Jun 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Jun 17, 2026

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 17, 2026

Uh oh!

MelvinBot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

MelvinBot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jun 14, 2026 •

edited by github-actions Bot

Loading

hoangzinh commented Jun 15, 2026 •

edited

Loading