Skip to content

Fix "Go to room" option briefly changing to "Go to workspace" in room details RHP - #93296

Merged
grgia merged 5 commits into
Expensify:mainfrom
software-mansion-labs:kuba-nowakowski/fix/93257-go-to-room-flicker
Jun 17, 2026
Merged

grgia merged 5 commits into
Expensify:mainfrom
software-mansion-labs:kuba-nowakowski/fix/93257-go-to-room-flicker

Conversation

@sumo-slonik

@sumo-slonik sumo-slonik commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

In the report details RHP, the isRoomCurrentlyOpen condition (which decides between showing Go to room and Go to workspace) was re-evaluated on every render, so tapping Go to room flipped it while the RHP was still closing, briefly swapping the option to Go to workspace. The condition is now computed once when the page is opened (lazy useState initializer), which is safe because report.reportID comes from the route params and never changes during the lifetime of a details page instance.

Fixed Issues

$ #93257
PROPOSAL:

Tests

  1. Sign in with an account that has access to at least one workspace containing at least one room, and ensure that you are an administrator of that room.
  2. Go to Workspaces > workspace > Rooms.
  3. Tap on any room to open its details in the RHP.
  4. Tap on "Go to room".
  5. Verify that while the RHP is closing, the "Go to room" option does not change to "Go to workspace" and does not move to the bottom of the menu.
  6. Verify you land in the room conversation.
  7. Open the room conversation, tap the room header to open the details RHP, and verify "Go to room" is not shown (while "Go to workspace" is, for workspace members).
  • Verify that no errors appear in the JS console

Offline tests

Unnecessary — the menu rendering and navigation are local, so the behavior is identical offline.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-06-12.at.12.00.16.mov

@sumo-slonik
sumo-slonik marked this pull request as ready for review June 12, 2026 10:30
@sumo-slonik
sumo-slonik requested review from a team as code owners June 12, 2026 10:30
@melvin-bot
melvin-bot Bot requested review from Krishna2323 and trjExpensify and removed request for a team June 12, 2026 10:30
@melvin-bot

melvin-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 12, 2026 10:30
@arekm213

arekm213 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

🤖 Mobile QA — PR #93296 · ✅ PASS (Android)

Fix "Go to room" option briefly changing to "Go to workspace" in room details RHP
Automated before/after mobile QA: bug reproduced on main, fix verified on the PR branch — with screen recordings.


Context

PR #93296 — branch kuba-nowakowski/fix/93257-go-to-room-flicker (software-mansion-labs)
Issue #93257"Go to room" option in RHP changes briefly to "Go to workspace" when tapped
Platform reproduced Android: App only → tested on Android
File touched src/pages/DynamicReportDetailsPage.tsx

Repro: open a room's Details RHP from the workspace Rooms list → tap "Go to room".
Expected: "Go to room" shouldn't change after being tapped.
Actual (bug): while the RHP is closing, "Go to room" briefly changes to "Go to workspace" and moves to the bottom of the menu.

What the diff does: isRoomCurrentlyOpen was re-evaluated on every render, so tapping "Go to room" flipped it while the RHP was still closing (the room became the topmost report mid-animation). The PR computes it once when the page opens, via useInitialValue(...), so the menu can't change during the close. JS-only → reload, no native rebuild.


Environment

Device Pixel 9 — Android 15 (API 35) emulator
App com.expensify.chat.dev (HybridApp dev build), Metro bundler
Account / workspace disposable test account · Argent Test's Workspace
Test room #qatestroom93296 (created for this test)
main commit 3d76089aa65
PR commit 6ab17f05e74

Android — Before (main) ❌ bug reproduced

🎥 Recording (main) — plays inline (loops); full quality: MP4

main recording

1. Room Details RHP — "Go to room" is the first option (top of the menu):

main: Go to room at top

2. After tapping — while the RHP closes, it flips to "Go to workspace" and moves to the bottom (now below Settings):

main: flicker to Go to workspace at bottom

➡️ Matches the issue's Actual Result — the option changes after being tapped.


Android — After (PR fix/93257…) ✅ fixed

🎥 Recording (PR) — plays inline (loops); full quality: MP4

PR recording

1. Room Details RHP — "Go to room" is the first option (identical starting point):

PR: Go to room at top

2. After tapping — "Go to room" stays put as the RHP closes (no flip to "Go to workspace", no reorder):

PR: Go to room unchanged during close

➡️ Matches the issue's Expected Result — the option doesn't change after being tapped.


Side-by-side

main (before) PR fix/93257… (after)
Tap "Go to room" → during RHP close ❌ flips to "Go to workspace", moves to bottom "Go to room" stays put, clean close

Verdict — ✅ PASS (Android)

The PR resolves the reported flicker: on main, tapping "Go to room" briefly swaps it to "Go to workspace" and reorders the menu during the close; on the PR branch the option is stable through the close and you land in the room cleanly. This is the exact Expected-vs-Actual delta in issue #93257.

Caveats / setup notes (environment, not the PR):

  • Rooms-list beta override. The "Go to room" option is only reachable from the Workspace Rooms list, which is gated behind the workspaceRoomsPage beta the test account lacked (WorkspaceInitialPage.tsxisBetaEnabled(CONST.BETAS.WORKSPACE_ROOMS_PAGE)). I enabled it client-side for the test (Onyx betas merge via the Metro debugger), applied identically to both branches. It only surfaces the entry point; the bug/fix lives in the render logic, so the before/after is fair.
  • Entry via deep link. The Rooms list was opened via workspaces/<policyID>/rooms deep link (the menu item appears once the beta is on); a room (#qatestroom93296) was created so the list had a room to test.
  • Metro OOM mid-session. Metro had run out of heap earlier and was restarted fresh with a 12 GB heap (unrelated to the PR).
  • Recording note. Videos start at the room Details RHP (the state where the bug manifests) and run through the tap → close → landing.

🤖 Automated mobile QA via argent-qa-pr · Android emulator via Argent/adb · before/after on main vs the PR branch · screen recordings via adb screenrecord, compressed with ffmpeg.

@Krishna2323

Copy link
Copy Markdown
Contributor

@sumo-slonik should I review this?

trjExpensify
trjExpensify previously approved these changes Jun 12, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@Krishna2323

Copy link
Copy Markdown
Contributor

@sumo-slonik details page shows "Go to workspace" instead of "Go to room":

  • Steps
  1. Go to Workspaces > workspace > Rooms.
  2. Tap on any room to open its details in the RHP.
  3. Tap on "Go to room".
  4. Tap the room header to open the details RHP
  5. Tap "Go to workspace"
  6. Navigate back thrice to go back to step 2 details page
  7. Bug: "Go to workspace" is shown instead of "Go to room"
Monosnap.screencast.2026-06-16.00-51-28.mp4

@sumo-slonik

Copy link
Copy Markdown
Contributor Author

@sumo-slonik details page shows "Go to workspace" instead of "Go to room":

  • Steps
  1. Go to Workspaces > workspace > Rooms.
  2. Tap on any room to open its details in the RHP.
  3. Tap on "Go to room".
  4. Tap the room header to open the details RHP
  5. Tap "Go to workspace"
  6. Navigate back thrice to go back to step 2 details page
  7. Bug: "Go to workspace" is shown instead of "Go to room"

Monosnap.screencast.2026-06-16.00-51-28.mp4

I'm on it!

Verify that the 'Go to room' row stays visible when the room becomes the topmost report after it is tapped (the frozen useInitialValue check), and that it is hidden when the details page is opened from the room itself.
@sumo-slonik

Copy link
Copy Markdown
Contributor Author

@Krishna2323 Could you please try to reproduce this bug one more time? Or could you tell me
what I'm doing wrong in my video reproduction?

Screen.Recording.2026-06-16.at.13.47.54.mov

@Krishna2323

Krishna2323 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
  • Tap "Go to workspace"
  • Navigate back thrice to go back to step 2 details page

@sumo-slonik you forgot to tap "Go to workspace".

Monosnap.screencast.2026-06-16.20-05-18.mp4

The room-visibility check read live global navigation state, which flickered during the RHP close (Expensify#93257). Deriving it from the page's own route.path keeps it stable across the close and later revisits; for instances recreated by back navigation that have no route.path, fall back to a reactive live topmost-report check so the menu settles on the correct option. Extend the unit tests to cover the route-path and path-less branches.
@sumo-slonik

Copy link
Copy Markdown
Contributor Author

@Krishna2323 fixed 🚀

Screen.Recording.2026-06-16.at.20.51.02.mov

@Krishna2323

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36486cd047

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/DynamicReportDetailsPage.tsx Outdated
Comment on lines +404 to +405
const liveIsRoomCurrentlyOpen = useRootNavigationState(() => isReportTopmostSplitNavigator() && Navigation.getTopmostReportId() === report?.reportID);
const isRoomCurrentlyOpen = route.path ? isReportDetailsOnTopOfRoom(route.path, report?.reportID) : liveIsRoomCurrentlyOpen;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve path-less room state after showing Go to room

When route.path is absent, this falls back to a live navigation-state subscription, so a path-less details page that currently shows Go to room still re-evaluates as soon as that action navigates to the room while the RHP is closing. In that path-less flow, liveIsRoomCurrentlyOpen flips to true before unmount and the menu can still swap to Go to workspace, which is the flicker this change is trying to prevent for room details opened away from the room.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumo-slonik this seems like a valid concern but I haven't faced this on while testing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking into it now

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct. I'm currently looking for a fix. There is a flicker when no path is available.

Screen.Recording.2026-06-17.at.10.54.53.mov

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Screen.Recording.2026-06-17.at.11.04.29.mov

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: HybridApp
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWebR.mp4
MacOS: Chrome / Safari
web_chrome.mp4

Deriving the row from live navigation state re-showed the flicker when the row was tapped on a back-restored details page (no route.path), and the route.path derivation only covered freshly-opened pages. Snapshot the topmost-report check on focus instead: it stays stable while the page is closing after the row is tapped, yet refreshes on later visits, covering every entry path with one mechanism.
@sumo-slonik

Copy link
Copy Markdown
Contributor Author

@trjExpensify I think this one is ready

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/DynamicReportDetailsPage.tsx 57.81% <66.66%> (+1.79%) ⬆️
... and 496 files with indirect coverage changes

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from grgia June 17, 2026 10:40
@grgia
grgia merged commit 462264a into Expensify:main Jun 17, 2026
34 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under docs/articles.

What the PR does: It fixes a visual flicker in the report details RHP where tapping Go to room briefly swapped the option to Go to workspace while the page was closing. The fix snapshots the isRoomCurrentlyOpen condition on focus (lazy useState + useFocusEffect) instead of recomputing it on every render. See src/pages/DynamicReportDetailsPage.tsx.

Why no docs are needed:

  • This is a pure rendering/correctness fix — no new feature, no changed user-facing behavior, and no renamed or added labels, tabs, or settings.
  • The Go to room / Go to workspace menu options are not documented in any article under docs/articles (no help content references these strings), so there is nothing to update.

Since no changes are required, I did not create a draft help site PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a pure UI bug fix: it snapshots the isRoomCurrentlyOpen condition on focus (via a lazy useState initializer + useFocusEffect) so the Go to room row no longer briefly flips to Go to workspace while the report details RHP is closing. It changes only render timing — no feature names, button/menu labels, navigation behavior, or user-facing workflows are added or altered.

I searched App/docs/articles and found no help article that documents the Go to room / Go to workspace options in the report details RHP. The closest article, Expensify Chat Rooms for Admins, covers room creation/access but not this menu, and its content remains accurate.

Since there are no documented behaviors affected, I did not create a draft help site PR — there is nothing for the docs to add or correct here.

@sumo-slonik, if you believe a help article should document this flow (or you'd like one created), let me know and I'll draft it.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.14-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants