Restore personal track goal selection after refresh by MelvinBot · Pull Request #93170 · Expensify/App

MelvinBot · 2026-06-10T12:01:15Z

Explanation of Change

On the What are you looking to track? onboarding screen (onboarding/personaltrackcase), the selected option was kept only in local component state (useState), while the confirmed value is persisted to Onyx (ONBOARDING_PERSONAL_TRACK_GOAL). When the user continued to the name step, refreshed the page (wiping in-memory React state), and navigated back, the screen remounted with empty local state and the previous selection appeared cleared.

This change restores the selection from the persisted Onyx value when the screen mounts. Because the Onyx value loads asynchronously, the state is adjusted during render once the value is loaded (guarded so it runs only once), following the React "You Might Not Need an Effect" pattern. Predefined goals are stored as their constant and re-selected directly; Something else stores the free text the user typed, so that case re-selects Something else and repopulates the text input.

Fixed Issues

$ #93131
PROPOSAL: #93131 (comment)

Tests

Go to staging.new.expensify.com and log in with a new Gmail account.
Click Organize my personal spending.
Select Something else, enter any text, and click Continue.
Refresh the page on the name step.
Click the app back button.
Verify the previous selection in What are you looking to track? is preserved (Something else is still selected and your text is restored).
Repeat steps 1-5 selecting a predefined option (e.g. Household expenses) instead, and verify it remains selected after refresh + back.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Log in with a new account and choose Organize my personal spending.
Select Something else, enter text, click Continue.
Refresh on the name step, then press back.
Verify the selection and entered text are preserved.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Process:

Screen.Recording.2026-06-10.at.12.27.03.PM.mov

Persistance validation after refresh:

Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>

MelvinBot · 2026-06-10T12:01:34Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-restorePersonalTrackGoalSelection
git checkout -b claude-restorePersonalTrackGoalSelection upstream/claude-restorePersonalTrackGoalSelection
git push -u origin claude-restorePersonalTrackGoalSelection

Then you can close this PR and open a new one from your fork.

jayeshmangwani · 2026-06-10T16:02:17Z

@MelvinBot It looks like the PR author checklist is outdated. Could you please use this checklist https://github.com/Expensify/App/blob/main/.github/PULL_REQUEST_TEMPLATE.md instead?

Also, please carry over any relevant details from the current checklist and add them to the new one. You can check all the boxes on author checklist —I’ll add the videos and complete the testing items in the C+ reviewer checklist.

jayeshmangwani · 2026-06-10T16:14:00Z

@MelvinBot #93170 (comment)

jayeshmangwani · 2026-06-10T16:24:07Z

@MelvinBot please check this comment #93170 (comment)

MelvinBot · 2026-06-10T16:27:19Z

🤖 Done! Updated the PR description to use the current PR template:

Replaced the outdated (and duplicated) PR Author Checklist with the full up-to-date checklist and checked all boxes.
Carried over the existing Explanation of Change, Fixed Issues, Tests, Offline tests, and QA Steps content.
Added the per-platform collapsible Screenshots/Videos sections — over to you to drop in the videos and complete the testing items in the C+ reviewer checklist.

NicolasBonet · 2026-06-10T16:27:40Z

@jayeshmangwani please add tests in all platforms

jayeshmangwani · 2026-06-10T16:32:55Z

@NicolasBonet, are you referring to testing on all platforms?

jayeshmangwani · 2026-06-10T16:36:43Z

I've been trying to test flow for the last hour, but sign up isn't working for me. I also checked the staging version, and it's failing there as well (only loading button). It might be an issue with the backend APIs.

BE-loading.mov

It seems that the backend https://expensify.slack.com/archives/C01GTK53T8Q/p1781105766481649 has some issues.

NicolasBonet · 2026-06-10T17:29:50Z

Backend is working just fine

Screen.Recording.2026-06-10.at.12.27.03.PM.mov

melvin-bot · 2026-06-10T17:30:06Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2026-06-10T17:45:17Z

Backend is working just fine

Sorry, but for me, the SignUpUser API is still not working. Its just keep loading indefinitely.

…lected goal and text inputs

melvin-bot · 2026-06-10T18:09:57Z

@FitseTLT @NicolasBonet One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2026-06-10T18:29:19Z

Does this need my review ?

jayeshmangwani · 2026-06-10T18:43:46Z

Does this need my review ?

No, I am taking care of the checklist since it's a regression from my PR. I'm just waiting for the site issue to be fixed so that sign-up can work.

FitseTLT · 2026-06-10T18:45:04Z

fixed btw

jayeshmangwani · 2026-06-10T19:04:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

jayeshmangwani · 2026-06-10T19:04:56Z

@NicolasBonet , the PR works well.

jayeshmangwani

LGTM 🚀

JS00001 · 2026-06-10T19:06:57Z

JmillsExpensify

LGTM

github-actions · 2026-06-10T19:34:15Z

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-10T19:41:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93170.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d25ca4b4e03-c67a368-0e8c2155858326f291a8a561736b1d42da988b71/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d25ca4b-c67a368-f9eb45abbd0a4a6d1165c3f5a27679c758b663e4/index.html

Web 🕸️
https://93170.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-10T23:52:20Z

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.4.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T23:54:16Z

🤖 Help site review — no docs changes required

I reviewed the changes in this PR against the help articles under App/docs/articles.

Conclusion: No help-site updates are needed.

Why:

This is a bug fix, not a feature or behavior change. It restores a previously-made selection on the What are you looking to track? onboarding screen after the user refreshes the next step and navigates back — restoring the behavior users already expect.
The change is purely internal state handling (reading the selection back from the persisted Onyx value instead of relying on in-memory React state). There is no new or changed UI copy, label, button, setting, or user-facing workflow.
The closest existing article, Track-Personal-Expenses.md, covers workspace setup for personal tracking and does not document the onboarding goal-selection screen or its selection-persistence behavior, so nothing there needs to change.

Since no documentation changes are required, I did not create a draft PR.

@jayeshmangwani, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

(Note: no help site PR was created because this bug fix introduces no documented user-facing change. If you'd like a docs PR for something specific here, reply with @MelvinBot and the details.)

OSBotify · 2026-06-11T23:43:34Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot and others added 2 commits June 10, 2026 11:57

Restore personal track goal selection from Onyx after refresh

a37456d

Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>

Use render-phase state adjustment instead of effect to satisfy lint

5d28ddf

Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>

MelvinBot assigned jayeshmangwani Jun 10, 2026

MelvinBot requested a review from a team June 10, 2026 12:01

MelvinBot mentioned this pull request Jun 10, 2026

[Due for payment 2026-06-18] [$250] Onboarding-Selection in "What are you looking to track?" is cleared after refreshing name step #93131

Closed

7 tasks

NicolasBonet marked this pull request as ready for review June 10, 2026 17:29

NicolasBonet requested a review from a team as a code owner June 10, 2026 17:30

melvin-bot Bot requested review from daledah and removed request for a team June 10, 2026 17:30

melvin-bot Bot requested review from JmillsExpensify and removed request for a team June 10, 2026 17:32

JS00001 requested changes Jun 10, 2026

View reviewed changes

Comment thread src/pages/OnboardingPersonalTrackGoal/BaseOnboardingPersonalTrackGoal.tsx Outdated

Refactor personal track goal state management to use overrides for se…

31853f5

…lected goal and text inputs

NicolasBonet requested a review from a team as a code owner June 10, 2026 18:09

melvin-bot Bot requested review from FitseTLT and NicolasBonet and removed request for a team June 10, 2026 18:09

JS00001 approved these changes Jun 10, 2026

View reviewed changes

jayeshmangwani approved these changes Jun 10, 2026

View reviewed changes

JmillsExpensify approved these changes Jun 10, 2026

View reviewed changes

NicolasBonet merged commit d25ca4b into main Jun 10, 2026
38 of 39 checks passed

NicolasBonet deleted the claude-restorePersonalTrackGoalSelection branch June 10, 2026 19:12

OSBotify mentioned this pull request Jun 10, 2026

Deploy Checklist: New Expensify 2026-06-10 #93219

Closed

72 tasks

Conversation

MelvinBot commented Jun 10, 2026 • edited by NicolasBonet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Process:

Persistance validation after refresh:

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

NicolasBonet commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NicolasBonet commented Jun 10, 2026

Uh oh!

melvin-bot Bot commented Jun 10, 2026

Uh oh!

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

melvin-bot Bot commented Jun 10, 2026

Uh oh!

FitseTLT commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

FitseTLT commented Jun 10, 2026

Uh oh!

jayeshmangwani commented Jun 10, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Jun 10, 2026

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Jun 10, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MelvinBot commented Jun 10, 2026 •

edited by NicolasBonet

Loading

jayeshmangwani commented Jun 10, 2026 •

edited

Loading