Fix unreported expense export payload by KJ21-ENG · Pull Request #93163 · Expensify/App

KJ21-ENG · 2026-06-10T08:45:40Z

Explanation of Change

This updates the Spend bulk export flow so selected unreported expenses can be exported through All Data - expense level without sending frontend sentinel report IDs as real report IDs.

Specifically, this PR:

Filters CONST.REPORT.UNREPORTED_REPORT_ID and CONST.REPORT.TRASH_REPORT_ID out of selectedTransactionReportIDs, so QueueExportSearchWithTemplate receives reportIDList: [] for all-unreported selections and only real report IDs for mixed selections.
Updates the empty-report guard so a missing report object, such as the expected missing REPORT_0, is not treated as an empty report. Real reports that exist with transactionCount === 0 still trigger the empty-report flow.

Fixed Issues

$ #91930
PROPOSAL: #91930 (comment)

Tests

Run npm run web.
Log in with a test account.
If validating against staging, go to Settings > Troubleshoot and enable Use Staging Server.
Go to a self-DM.
Create a manual expense.
Open the expense and split the expense by date, selecting multiple dates.
Go to Spend > Expenses.
Select the resulting unreported expense rows.
Select Export > All Data - expense level.
Verify the app does not show the local empty-report error: You can't export empty report.
Verify the export completes successfully and the export file contains all the selected expenses.
Select a mix of reported and unreported expenses.
Verify the export completes successfully and the export file contains all the selected expenses.

Verify that no errors appear in the JS console

Offline tests

Run npm run web.
Log in with a test account.
Go offline.
Go to Spend > Expenses and select one or more expense rows.
Select Export > All Data - expense level.
Verify the offline modal is shown and no export request is sent while offline.

QA Steps

Go to a self-DM.
Create a manual expense.
Open the expense and split the expense by date, selecting multiple dates.
Go to Spend > Expenses.
Select the resulting unreported expense rows.
Select Export > All Data - expense level.
Verify the app does not show the local empty-report error: You can't export empty report.
Verify the export completes successfully and the export file contains all the selected expenses.
Select a mix of reported and unreported expenses.
Verify the export completes successfully and the export file contains all the selected expenses.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Record_2026-06-17-17-56-58_40d2c9e2d8fb5b5aba3904834590021e.mp4

Android: mWeb Chrome

Record_2026-06-17-17-35-14.mp4

iOS: Native

Screen.Recording.2026-06-17.at.6.16.48.PM.mov

iOS: mWeb Safari

ezyZip.48.mp4

MacOS: Chrome / Safari

ezyZip.32.mp4

codecov · 2026-06-10T08:50:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useSearchBulkActions.ts	`52.44% <50.00%> (ø)`
... and 74 files with indirect coverage changes

NikkiWines · 2026-06-12T21:59:53Z

We're seeing some unexpected side effects from the backend change so it's going to be temporarily reverted while we look into it a bit more. Will update here when it's live again

KJ21-ENG · 2026-06-13T09:04:58Z

We're seeing some unexpected side effects from the backend change so it's going to be temporarily reverted while we look into it a bit more. Will update here when it's live again

@NikkiWines NP, Please ping me here when its back so we can proceed here.

NikkiWines · 2026-06-16T10:02:56Z

Backend changes have been deployed again

trjExpensify · 2026-06-17T00:42:58Z

@KJ21-ENG we're getting more requests come in about this. Can you prioritise getting this out of draft today, please? Thanks!

KJ21-ENG · 2026-06-17T04:08:22Z

@trjExpensify Yaa Sure, Since this is done, I will recheck that front end changes are aligned with it and will make PR ready for review. Thanks!

melvin-bot · 2026-06-17T08:57:32Z

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

gijoe0295 · 2026-06-17T11:27:00Z

@KJ21-ENG Can you fill the checklist and add recordings for all platforms?

For QA Steps, please fill this:

Go to a self-DM.
Create a manual expense.
Open the expense and split the expense by date, selecting multiple dates.
Go to Spend > Expenses.
Select the resulting unreported expense rows.
Select Export > All Data - expense level.
Verify the app does not show the local empty-report error: You can't export empty report.
Verify the export completes successfully and the export file contains all the selected expenses 
Select a mix of reported and unreported expenses
Verify the export completes successfully and the export file contains all the selected expenses

gijoe0295 · 2026-06-17T11:27:50Z

@codex review

chatgpt-codex-connector · 2026-06-17T11:33:06Z

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 460cbb6490

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

gijoe0295 · 2026-06-17T11:59:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-17.at.19.12.18.mov

Android: mWeb Chrome

Screen.Recording.2026-06-17.at.19.13.15.mov

iOS: HybridApp

Screen.Recording.2026-06-17.at.19.04.32.mov

iOS: mWeb Safari

Screen.Recording.2026-06-17.at.19.06.49.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-17.at.18.56.10.mov

Screen.Recording.2026-06-17.at.18.55.06.mov

gijoe0295

LGTM

KJ21-ENG · 2026-06-17T12:15:28Z

@KJ21-ENG Can you fill the checklist and add recordings for all platforms?

@gijoe0295 Yep, already on it. My original recordings got corrupted, so I'm re-doing them now and will update the PR shortly. Apologies for the delay—the upload must have failed without me realizing it until your comment.

KJ21-ENG · 2026-06-17T13:04:31Z

The PR body has been updated. Please accept my sincere apologies. I use a personal tool to compress all recordings under 10 MB before uploading them to issues or PRs, but it unfortunately failed this time, which is why the body wasn't updated in time. I know this is a priority, and I will make sure to avoid these errors in the future. Thanks!

cc: @gijoe0295 @trjExpensify

github-actions · 2026-06-17T13:36:50Z

🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-17T13:44:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93163.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-776140330f3-86e5643-ecabc6a6b544e618038f56455fbfea853fea3348/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7761403-86e5643-5dae3bf673d287e65a75ee28d3b9c7e6dd21dcb8/index.html

Web 🕸️
https://93163.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-17T18:42:43Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-17T18:44:36Z

🤖 Help site review: no documentation changes required.

I reviewed the changes in this PR against the help site articles under App/docs/articles.

Conclusion: No draft docs PR is needed.

Why: This PR is an internal bug fix in the bulk-export payload logic (src/hooks/useSearchBulkActions.ts). It:

Filters frontend sentinel report IDs (UNREPORTED_REPORT_ID, TRASH_REPORT_ID) out of the export request so QueueExportSearchWithTemplate receives the correct reportIDList.
Fixes the empty-report guard so a missing report object isn't incorrectly treated as an empty report.

There is no user-facing behavior change to document: no new feature, no renamed/added UI labels, tabs, settings, or buttons, and no change to the documented export flow itself. The existing export functionality is unchanged from the user's perspective — this fix simply makes the unreported-expense export work correctly. The relevant export-related articles (e.g., Export-Expenses-from-the-Expenses-Page.md) describe the user flow accurately and remain correct.

@KJ21-ENG, no linked help site PR was created since no documentation updates are required. If you believe a user-facing concept here should be documented, let me know and I'll draft one.

OSBotify · 2026-06-18T00:18:48Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.12-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-18T00:21:18Z

🤖 Help site review — no docs changes required.

I reviewed the changes in this PR against the help articles under App/docs/articles, and no updates are needed.

Why: This is an internal bug fix, not a user-facing behavior or feature change. The diff is a 2-line change in src/hooks/useSearchBulkActions.ts that:

Filters the sentinel UNREPORTED_REPORT_ID / TRASH_REPORT_ID values out of selectedTransactionReportIDs so the export payload only sends real report IDs.
Tightens the empty-report guard so a missing report object isn't mistaken for an empty report.

The user-facing flow (Spend > Expenses, select rows, Export > All Data - expense level) is unchanged — the fix just makes it work correctly for unreported and mixed selections. None of the help articles document this sentinel-ID payload behavior or the local empty-report error, so there's nothing to add or correct.

Since no documentation changes are required, I have not created a draft PR.

@KJ21-ENG, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-06-18T03:04:23Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.14-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-18T17:15:08Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix unreported expense export request payload

460cbb6

melvin-bot Bot assigned KJ21-ENG Jun 10, 2026

KJ21-ENG mentioned this pull request Jun 11, 2026

[Due for payment 2026-06-25] [$250] Spend - Expense-level export fails with “You can't export empty report” #91930

Closed

7 tasks

KJ21-ENG changed the title ~~[WIP] Fix unreported expense export payload~~ Fix unreported expense export payload Jun 17, 2026

KJ21-ENG marked this pull request as ready for review June 17, 2026 08:57

KJ21-ENG requested review from a team as code owners June 17, 2026 08:57

melvin-bot Bot requested review from gijoe0295 and trjExpensify and removed request for a team June 17, 2026 08:57

izarutskaya mentioned this pull request Jun 17, 2026

[HOLD #93163] Export unreported to All Data IS Templates returns errors #93803

Open

7 tasks

gijoe0295 approved these changes Jun 17, 2026

View reviewed changes

melvin-bot Bot requested a review from Gonals June 17, 2026 12:14

Gonals approved these changes Jun 17, 2026

View reviewed changes

Gonals merged commit 7761403 into Expensify:main Jun 17, 2026
37 of 51 checks passed

github-actions Bot mentioned this pull request Jun 17, 2026

[Due for payment 2026-06-25] Investigate workflow job failing on main: test / test (job 6) #93818

Closed

github-actions Bot mentioned this pull request Jun 17, 2026

Investigate workflow job failing on main: test / test (job 6) #93821

Closed

MelvinBot mentioned this pull request Jun 17, 2026

Fix flaky createOwnedPaidPoliciesCountsSelector unit tests #93823

Merged

50 tasks

This was referenced Jun 17, 2026

Investigate workflow job failing on main: test / test (job 6) #93825

Closed

Investigate workflow job failing on main: test / test (job 6) #93827

Closed

OSBotify mentioned this pull request Jun 17, 2026

Deploy Checklist: New Expensify 2026-06-17 #93863

Closed

67 tasks

Conversation

KJ21-ENG commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NikkiWines commented Jun 12, 2026

Uh oh!

KJ21-ENG commented Jun 13, 2026

Uh oh!

NikkiWines commented Jun 16, 2026

Uh oh!

trjExpensify commented Jun 17, 2026

Uh oh!

KJ21-ENG commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 17, 2026

Uh oh!

gijoe0295 commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gijoe0295 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 17, 2026

Uh oh!

gijoe0295 commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

KJ21-ENG commented Jun 17, 2026

Uh oh!

KJ21-ENG commented Jun 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 17, 2026

Uh oh!

MelvinBot commented Jun 17, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

MelvinBot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KJ21-ENG commented Jun 10, 2026 •

edited

Loading

codecov Bot commented Jun 10, 2026 •

edited by github-actions Bot

Loading

KJ21-ENG commented Jun 17, 2026 •

edited

Loading

gijoe0295 commented Jun 17, 2026 •

edited

Loading

gijoe0295 commented Jun 17, 2026 •

edited

Loading