fix: Report title link from Spend > Expenses opens Inbox instead of Spend super-wide modal - #93162
Conversation
…pend super-wide modal
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid-Native.mp4Android: mWeb ChromeAndroid-mWeb.Chrome.mp4iOS: HybridAppiOS-Native.mp4iOS: mWeb SafariiOS-mWeb.Safari.mp4MacOS: Chrome / SafariMacOS-Chrome.mp4 |
|
@nkdengineer Could you merge with latest main? |
|
Done. |
|
🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.17-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no docs changes required I reviewed the changes in this PR against Expensify's help site content under What this PR does: It fixes a navigation-routing bug so that clicking a report title hyperlink from Spend > Expenses opens the expense report in the Search super-wide modal (RHP) instead of routing to the Inbox. The diff is limited to:
Why no docs update is needed: This is an internal UI/navigation fix. It introduces no new feature, setting, tab, label, or workflow, and changes no user-facing copy. No help article under No draft help-site PR was created. @nkdengineer, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR (Note: no help site PR was created because no documentation changes are required for this navigation fix. If you believe a specific article should be updated, let me know which one and I'll draft the change.) |
|
@nkdengineer PR failing with original issue ID #91889 |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
Explanation of Change
fix: Report title link from Spend > Expenses opens Inbox instead of Spend super-wide modal
Fixed Issues
$ #91889
PROPOSAL: #91889 (comment)
Tests
Precondition: Create an expense report with some expenses
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-10.at.15.37.30.mov
Android: mWeb Chrome
Screen.Recording.2026-06-10.at.15.25.20.mov
iOS: Native
Screen.Recording.2026-06-10.at.15.28.27.mov
iOS: mWeb Safari
Screen.Recording.2026-06-10.at.15.30.15.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-10.at.15.19.02.mov