Expense-To field shows correct avatar but wrong name after creating new report on confirm page by dukenv0307 · Pull Request #92902 · Expensify/App

dukenv0307 · 2026-06-08T09:09:34Z

Explanation of Change

Fixed Issues

$ #92847
PROPOSAL:

Tests

Precondition:

Create two workspaces - A and B.
Workspace A is the default workspace.

Go to staging.new.expensify.com
Create two reports in workspace chat A.
Create one report in workspace chat B.
Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, click Report.
Select report from workspace B.
Click Report.
Verify that: after changing report from another workspace and creating report, To field will show the default workspace avatar and name.

→ Workspace A is selected.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-08.at.16.05.37.mov

…ew report on confirm page

melvin-bot · 2026-06-08T09:09:50Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-06-08T09:09:58Z

@DylanDylann please review

github-actions · 2026-06-08T09:12:57Z

+ * @returns Record mapping policyID to Policy
+ */
+function useParticipantsPolicies(participants: ParticipantWithPolicyID[]): Record<string, Policy> {
+    const [participantsPolicies = getEmptyObject<Record<string, Policy>>()] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: getPoliciesSelector(participants)}, [participants]);


❌ PERF-11 (docs)

The selector on ONYXKEYS.COLLECTION.POLICY returns Record<string, Policy> containing full Policy objects. Since useOnyx runs deepEqual on selector output, it must deep-compare entire Policy objects on every Onyx update to the policy collection. Policy objects can be large, making this comparison expensive.

Consider one of these approaches:

Narrow the selector output to only the fields actually needed downstream (e.g., name, type, id), so deepEqual compares a small object per entry.

Remove the selector entirely and subscribe without one (using cheaper shallowEqual), then filter/transform inline:

function useParticipantsPolicies(participants: ParticipantWithPolicyID[]): Record<string, Policy> { const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY); // Filter inline — shallowEqual on raw references is cheaper than deepEqual on full Policy objects const participantsPolicies = participants.reduce<Record<string, Policy>>((acc, participant) => { const key = `${ONYXKEYS.COLLECTION.POLICY}${participant.policyID}`; if (allPolicies?.[key] && participant.policyID) { acc[participant.policyID] = allPolicies[key]; } return acc; }, {}); return participantsPolicies; }

Reviewed at: 12e1ee8 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

codecov · 2026-06-08T09:13:47Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...es/iou/request/step/IOURequestStepConfirmation.tsx	`64.44% <100.00%> (+0.22%)`	⬆️
src/hooks/useParticipantsPolicies.ts	`81.81% <81.81%> (ø)`
... and 13 files with indirect coverage changes

abzokhattab · 2026-06-08T23:08:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-06-09.at.01.05.36.mov

iOS: mWeb Safari

Screen.Recording.2026-06-09.at.01.06.41.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-09.at.01.03.43.mov

abzokhattab

The changes look good to me.. the issue is fixed .. the perf improvement comment makes sense, but its not a blocker

github-actions · 2026-06-08T23:24:59Z

🚧 @tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-08T23:28:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-08T23:30:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92902.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-66125d0e3f4-d5d64cb-b774447a01de9fec8375ecdfa27485762d1008bd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-66125d0-d5d64cb-ab0d7887b689a18c44c87435f1146dcaf4d0d7b4/index.html

Web 🕸️
https://92902.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Expense-To field shows correct avatar but wrong name after creating new report on confirm page (cherry picked from commit 66125d0) (cherry-picked to staging by Julesssss)

OSBotify · 2026-06-09T01:13:55Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.0-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-09T01:15:31Z

🤖 Help site review — no changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles.

Conclusion: No help site updates are needed.

Why:

This PR is a bug fix that corrects a display issue: after switching the report to a different workspace on the expense confirmation page, the To field showed the wrong workspace name/avatar. The fix (a new useParticipantsPolicies hook wired into IOURequestStepConfirmation.tsx) makes the To field render the correct policy avatar and name.
It restores the already-expected behavior described in the linked issue — it does not introduce a new feature, change a user-facing workflow, rename any UI element, or alter any documented step.
A search of the help articles found nothing documenting this specific avatar/name rendering detail of the expense confirmation To field, so there is no existing content to correct.

No draft PR was created since there is nothing to document.

Julesssss · 2026-06-09T03:50:51Z

Verified fixed: #92847 (comment)

OSBotify · 2026-06-09T04:12:57Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-06-09T04:36:15Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.1-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-10T00:38:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.1-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Expense-To field shows correct avatar but wrong name after creating n…

12e1ee8

…ew report on confirm page

melvin-bot Bot assigned dukenv0307 Jun 8, 2026

dukenv0307 marked this pull request as ready for review June 8, 2026 09:09

dukenv0307 requested review from a team as code owners June 8, 2026 09:09

melvin-bot Bot requested review from ahmedGaber93 and trjExpensify and removed request for a team June 8, 2026 09:09

melvin-bot Bot removed request for a team and trjExpensify June 8, 2026 09:09

github-actions Bot reviewed Jun 8, 2026

View reviewed changes

Julesssss requested a review from abzokhattab June 8, 2026 22:39

abzokhattab approved these changes Jun 8, 2026

View reviewed changes

melvin-bot Bot requested a review from tylerkaraszewski June 8, 2026 23:14

tylerkaraszewski approved these changes Jun 8, 2026

View reviewed changes

tylerkaraszewski merged commit 66125d0 into Expensify:main Jun 8, 2026
37 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 9, 2026

OSBotify mentioned this pull request Jun 9, 2026

Deploy Checklist: New Expensify 2026-06-05 #92792

Closed

melvin-bot Bot mentioned this pull request Jun 9, 2026

[Due for payment 2026-06-17] [Due for payment 2026-06-16] Expense-To field shows correct avatar but wrong name after creating new report on confirm page #92847

Closed

7 tasks

abzokhattab mentioned this pull request Jul 12, 2026

refactor getShareDestination and clean-up some util functions #91554

Merged

51 tasks

Conversation

dukenv0307 commented Jun 8, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 8, 2026

Uh oh!

dukenv0307 commented Jun 8, 2026

Uh oh!

github-actions Bot Jun 8, 2026

Choose a reason for hiding this comment

❌ PERF-11 (docs)

Uh oh!

codecov Bot commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

abzokhattab commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

OSBotify commented Jun 8, 2026

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

MelvinBot commented Jun 9, 2026

Uh oh!

Julesssss commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jun 8, 2026 •

edited by github-actions Bot

Loading

abzokhattab commented Jun 8, 2026 •

edited

Loading