Migrate useSearchSelector.base.ts from useOptionsList to usePersonalDetailOptions (part 3) by shubham1206agra · Pull Request #92868 · Expensify/App

shubham1206agra · 2026-06-07T02:16:37Z

Explanation of Change

Fixed Issues

$ #82191

Tests

Open App
Open any group chat
Go to members and click on invite.
Verify that all options are displayed correctly and searching and selecting works fine.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-06-07.at.7.40.59.AM.mov

Screen.Recording.2026-06-07.at.7.43.00.AM.mov

…etailOptions (part 3)

melvin-bot · 2026-06-07T02:16:43Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-07T02:16:47Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-07T02:20:05Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.79% <ø> (ø)`
src/hooks/useSearchSelector/base.ts	`80.20% <ø> (-0.41%)`	⬇️
...workspace/companyCards/assignCard/AssigneeStep.tsx	`60.24% <57.14%> (-1.30%)`	⬇️
src/pages/InviteReportParticipantsPage.tsx	`0.00% <0.00%> (ø)`
.../workspace/expensifyCard/issueNew/AssigneeStep.tsx	`0.00% <0.00%> (ø)`
... and 59 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87ab6eaabf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-07T02:27:30Z

+    const {searchTerm, debouncedSearchTerm, setSearchTerm, availableOptions, selectedOptions, toggleSelection, areOptionsInitialized} = usePersonalDetailSearchSelector({
+        selectionMode: CONST.SEARCH_SELECTOR.SELECTION_MODE_MULTI,
+        includeUserToInvite: true,
+        excludeLogins: excludedUsers,
+        includeRecentReports: true,
+        shouldInitialize: didScreenTransitionEnd,
+    });


Normalize phone searches before using the personal-detail selector

When this page is migrated to usePersonalDetailSearchSelector, phone searches are passed through as the raw typed text; that selector's matching only checks text and login, and unlike the old useSearchSelector path it does not first convert formatted phone input with getSearchValueForPhoneOrEmail. For a known user whose display name is shown, searching a formatted phone number like (555) 123-4567 no longer matches their +15551234567 login and can instead show an optimistic invite for the same person with a generated accountID. This affects phone-number invite/selection flows; please normalize the search term in the new selector path or before calling it.

Useful? React with 👍 / 👎.

hoangzinh · 2026-06-09T09:48:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-09.at.22.10.49.mov

Android: mWeb Chrome

Screen.Recording.2026-06-09.at.22.06.53.mov

iOS: HybridApp

Screen.Recording.2026-06-09.at.22.27.27.mov

iOS: mWeb Safari

Screen.Recording.2026-06-09.at.22.16.55.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-09.at.22.01.34.mov

hoangzinh · 2026-06-09T15:31:12Z

@mountiny all yours

github-actions · 2026-06-09T15:46:52Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-09T15:52:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-09T15:52:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92868.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b2b8b376249-79c0e20-6eee618cad6da24774a8c7a4d862d658bfc3f054/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b2b8b37-79c0e20-ffffd16bc5e6fe53301983f6b02d39b14d5b19b9/index.html

Web 🕸️
https://92868.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-10T01:02:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T01:04:51Z

Help site review: No changes required

I reviewed the changes in this PR against the help site files under App/docs/articles. No documentation updates are required.

Why

This is a pure internal refactor with no user-facing impact:

Migrates the member-invite/assignee flows from useSearchSelector to usePersonalDetailSearchSelector (a performance refactor — part of the effort to remove OptionListContextProvider, tracked in 82191).
Removes the internal SEARCH_CONTEXT_MEMBER_INVITE constant and its switch branch.
Updates internal type imports (OptionData, getHeaderMessage) and how header-message/section data is derived.

The affected flows — inviting members to a group chat, assigning an Expensify Card, and assigning a company card — keep the same UI, labels, options, and behavior. There are no new features, renamed tabs/settings, changed buttons, or altered user-facing copy that would need to be reflected in a help article.

Since no behavior changed, there's no draft help site PR to open.

@shubham1206agra, if you believe a specific flow's documented behavior did change, let me know which article and I'll draft the update.

OSBotify · 2026-06-10T19:55:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.4-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T19:58:11Z

Help site review — no docs changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles.

Conclusion: No help site updates are needed.

Why: This is a pure internal refactor. It migrates the member-invite search flows from the useSearchSelector hook to usePersonalDetailSearchSelector, removes the now-unused SEARCH_CONTEXT_MEMBER_INVITE constant, and updates the corresponding unit tests. The affected screens — group chat member invite, company card assignee, and Expensify Card assignee — keep the same user-facing behavior (same options, search, and selection). There are no new features, renamed UI labels, changed buttons, or altered workflows that the documentation describes.

Since nothing in the public, documented behavior changed, no draft docs PR was created and there is nothing to review on the help site side.

@shubham1206agra, if you believe a documented behavior did change here, let me know what it is and I'll draft the corresponding help site PR.

OSBotify · 2026-06-10T23:19:37Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Migrate useSearchSelector.base.ts from useOptionsList to usePersonalD…

87ab6ea

…etailOptions (part 3)

shubham1206agra requested review from a team as code owners June 7, 2026 02:16

melvin-bot Bot assigned shubham1206agra Jun 7, 2026

melvin-bot Bot requested review from flaviadefaria and hoangzinh and removed request for a team June 7, 2026 02:16

melvin-bot Bot requested review from a team and mountiny and removed request for a team June 7, 2026 02:16

melvin-bot Bot removed the request for review from a team June 7, 2026 02:16

Removed unused code

7ba22de

chatgpt-codex-connector Bot reviewed Jun 7, 2026

View reviewed changes

hoangzinh reviewed Jun 9, 2026

View reviewed changes

Comment thread src/pages/InviteReportParticipantsPage.tsx

Comment thread src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

hoangzinh approved these changes Jun 9, 2026

View reviewed changes

mountiny approved these changes Jun 9, 2026

View reviewed changes

mountiny merged commit b2b8b37 into Expensify:main Jun 9, 2026
33 of 37 checks passed

OSBotify mentioned this pull request Jun 10, 2026

Deploy Checklist: New Expensify 2026-06-10 #93122

Closed

70 tasks

melvin-bot Bot mentioned this pull request Jun 10, 2026

Migrate useSearchSelector.base.ts from useOptionsList to useFilteredOptions #82191

Closed

shubham1206agra deleted the refactor-useSearchSelector-3 branch July 7, 2026 10:56

MelvinBot mentioned this pull request Jul 30, 2026

[Due for payment 2026-07-30] [Tracking] Remove OptionListContextProvider and migrate all consumers to useFilteredOptions #82193

Closed

12 tasks

Conversation

shubham1206agra commented Jun 7, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 7, 2026

Uh oh!

melvin-bot Bot commented Jun 7, 2026

Uh oh!

codecov Bot commented Jun 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 7, 2026

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

hoangzinh commented Jun 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Help site review: No changes required

Why

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Help site review — no docs changes required

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jun 7, 2026 •

edited by github-actions Bot

Loading

hoangzinh commented Jun 9, 2026 •

edited

Loading