Skip to content

Prevent read-only workspace roles from opening write-only workspace actions #92781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 15 commits into from
Jun 8, 2026
Merged

Prevent read-only workspace roles from opening write-only workspace actions #92781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
22a263c
Hide add cards for read-only company card roles
ShridharGoel Jun 5, 2026
eae3b2d
Prettier fix
ShridharGoel Jun 5, 2026
d0be3ec
Disable accounting offer link for read-only roles
ShridharGoel Jun 5, 2026
1347269
Prettier fix
ShridharGoel Jun 5, 2026
676398c
Fix read-only category and tag header alignment
ShridharGoel Jun 5, 2026
734e678
Disable dependent tags import link for read-only users
ShridharGoel Jun 6, 2026
77ddf4e
Disable Expensify Card promotion for read-only users
ShridharGoel Jun 6, 2026
67ce2bc
Hide dependent tags import sentence for read-only users
ShridharGoel Jun 6, 2026
40296e2
Split dependent tags import subtitle
ShridharGoel Jun 6, 2026
6603b6c
Prettier fix
ShridharGoel Jun 6, 2026
4bc0177
Use parameter for dependent tags import subtitle
ShridharGoel Jun 6, 2026
8231485
Hide accounting change links for read-only categories and tags
ShridharGoel Jun 6, 2026
3044713
Prettier fix
ShridharGoel Jun 6, 2026
e2fae6b
Add card admin member filter
ShridharGoel Jun 6, 2026
81182e3
Revert "Add card admin member filter"
ShridharGoel Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/languages/de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5634,8 +5634,8 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
emptyCategories: {
title: 'Noch keine Kategorien',
subtitle: 'Füge eine Kategorie hinzu, um deine Ausgaben zu organisieren.',
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Ihre Kategorien werden derzeit über eine Buchhaltungsverbindung importiert. Gehen Sie zu <a href="${accountingPageURL}">Buchhaltung</a>, um Änderungen vorzunehmen.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Ihre Kategorien werden derzeit über eine Buchhaltungsverbindung importiert.${canManage ? ` Gehen Sie zu <a href="${accountingPageURL}">Buchhaltung</a>, um Änderungen vorzunehmen.` : ''}</centered-text></muted-text>`,
},
updateFailureMessage: 'Beim Aktualisieren der Kategorie ist ein Fehler aufgetreten, bitte versuche es erneut.',
createFailureMessage: 'Beim Erstellen der Kategorie ist ein Fehler aufgetreten, bitte versuche es erneut.',
Expand Down Expand Up @@ -5993,14 +5993,14 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
editTags: 'Tags bearbeiten',
findTag: 'Tag finden',
subtitle: 'Tags bieten detailliertere Möglichkeiten, Kosten zu klassifizieren.',
subtitleWithDependentTags: (importSpreadsheetLink: string) =>
`<muted-text>Tags bieten detailliertere Möglichkeiten, Kosten zu klassifizieren. Sie verwenden <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">abhängige Tags</a>. Sie können <a href="${importSpreadsheetLink}">eine Tabelle erneut importieren</a>, um Ihre Tags zu aktualisieren.</muted-text>`,
subtitleWithDependentTags: (importSpreadsheetLink: string, canReimport = true) =>
`<muted-text>Tags bieten detailliertere Möglichkeiten, Kosten zu klassifizieren. Sie verwenden <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">abhängige Tags</a>.${canReimport ? ` Sie können <a href="${importSpreadsheetLink}">eine Tabelle erneut importieren</a>, um Ihre Tags zu aktualisieren.` : ''}</muted-text>`,
emptyTags: {
title: 'Noch keine Tags',
subtitle: 'Füge ein Tag hinzu, um Projekte, Standorte, Abteilungen und mehr zu verfolgen.',
subtitleHTML: `<muted-text><centered-text>Fügen Sie Tags hinzu, um Projekte, Standorte, Abteilungen und mehr nachzuverfolgen. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Erfahren Sie mehr</a> über das Formatieren von Tag-Dateien für den Import.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Ihre Tags werden derzeit über eine Buchhaltungsverbindung importiert. Gehen Sie zu <a href="${accountingPageURL}">Buchhaltung</a>, um Änderungen vorzunehmen.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Ihre Tags werden derzeit über eine Buchhaltungsverbindung importiert.${canManage ? ` Gehen Sie zu <a href="${accountingPageURL}">Buchhaltung</a>, um Änderungen vorzunehmen.` : ''}</centered-text></muted-text>`,
},
deleteTag: 'Tag löschen',
deleteTags: 'Tags löschen',
Expand Down
12 changes: 6 additions & 6 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5665,8 +5665,8 @@ const translations = {
emptyCategories: {
title: 'No categories yet',
subtitle: 'Add a category to organize your spend.',
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Your categories are currently importing from an accounting connection. Head over to <a href="${accountingPageURL}">accounting</a> to make any changes.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Your categories are currently importing from an accounting connection.${canManage ? ` Head over to <a href="${accountingPageURL}">accounting</a> to make any changes.` : ''}</centered-text></muted-text>`,
},
updateFailureMessage: 'An error occurred while updating the category, please try again',
createFailureMessage: 'An error occurred while creating the category, please try again',
Expand Down Expand Up @@ -6038,15 +6038,15 @@ const translations = {
findTag: 'Find tag',
subtitle: 'Tags add more detailed ways to classify costs.',
// TODO: Add a actual link to the help article https://github.com/Expensify/App/issues/63612
subtitleWithDependentTags: (importSpreadsheetLink: string) =>
`<muted-text>Tags add more detailed ways to classify costs. You are using <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">dependent tags</a>. You can <a href="${importSpreadsheetLink}">reimport a spreadsheet</a> to update your tags.</muted-text>`,
subtitleWithDependentTags: (importSpreadsheetLink: string, canReimport = true) =>
`<muted-text>Tags add more detailed ways to classify costs. You are using <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">dependent tags</a>.${canReimport ? ` You can <a href="${importSpreadsheetLink}">reimport a spreadsheet</a> to update your tags.` : ''}</muted-text>`,
emptyTags: {
title: 'No tags yet',
// We need to remove the subtitle and use the below one when we remove the canUseMultiLevelTags beta
subtitle: 'Add a tag to track projects, locations, departments, and more.',
subtitleHTML: `<muted-text><centered-text>Add tags to track projects, locations, departments, and more. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Learn more</a> about formatting tag files for import.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Your tags are currently importing from an accounting connection. Head over to <a href="${accountingPageURL}">accounting</a> to make any changes.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Your tags are currently importing from an accounting connection.${canManage ? ` Head over to <a href="${accountingPageURL}">accounting</a> to make any changes.` : ''}</centered-text></muted-text>`,
},
deleteTag: 'Delete tag',
deleteTags: 'Delete tags',
Expand Down
12 changes: 6 additions & 6 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5464,8 +5464,8 @@ ${amount} para ${merchant} - ${date}`,
emptyCategories: {
title: 'Todavía no hay categorías',
subtitle: 'Añade una categoría para organizar tu gasto.',
subtitleWithAccounting: (accountingPageURL) =>
`<muted-text><centered-text>Tus categorías se están importando actualmente desde una conexión de contabilidad. Dirígete a <a href="${accountingPageURL}">contabilidad</a> para hacer cualquier cambio.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL, canManage = true) =>
`<muted-text><centered-text>Tus categorías se están importando actualmente desde una conexión de contabilidad.${canManage ? ` Dirígete a <a href="${accountingPageURL}">contabilidad</a> para hacer cualquier cambio.` : ''}</centered-text></muted-text>`,
},
updateFailureMessage: 'Se ha producido un error al intentar eliminar la categoría. Por favor, inténtalo más tarde.',
createFailureMessage: 'Se ha producido un error al intentar crear la categoría. Por favor, inténtalo más tarde.',
Expand Down Expand Up @@ -5831,14 +5831,14 @@ ${amount} para ${merchant} - ${date}`,
editTags: 'Editar etiquetas',
findTag: 'Encontrar etiquetas',
subtitle: 'Las etiquetas añaden formas más detalladas de clasificar los costos.',
subtitleWithDependentTags: (importSpreadsheetLink) =>
`<muted-text>Las etiquetas añaden formas más detalladas de clasificar los costos. Estás usando <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">etiquetas dependientes</a>. Puedes <a href="${importSpreadsheetLink}">reimportar una hoja de cálculo</a> para actualizar tus etiquetas.</muted-text>`,
subtitleWithDependentTags: (importSpreadsheetLink, canReimport = true) =>
`<muted-text>Las etiquetas añaden formas más detalladas de clasificar los costos. Estás usando <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">etiquetas dependientes</a>.${canReimport ? ` Puedes <a href="${importSpreadsheetLink}">reimportar una hoja de cálculo</a> para actualizar tus etiquetas.` : ''}</muted-text>`,
emptyTags: {
title: 'Aún no hay etiquetas',
subtitle: 'Añade una etiqueta para realizar el seguimiento de proyectos, ubicaciones, departamentos y otros.',
subtitleHTML: `<muted-text><centered-text>Importa una hoja de cálculo para añadir etiquetas y organizar proyectos, ubicaciones, departamentos y más. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Obtén más información</a> sobre cómo dar formato a los archivos de etiquetas.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL) =>
`<muted-text><centered-text>Tus etiquetas se están importando actualmente desde una conexión de contabilidad. Dirígete a <a href="${accountingPageURL}">contabilidad</a> para hacer cualquier cambio.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL, canManage = true) =>
`<muted-text><centered-text>Tus etiquetas se están importando actualmente desde una conexión de contabilidad.${canManage ? ` Dirígete a <a href="${accountingPageURL}">contabilidad</a> para hacer cualquier cambio.` : ''}</centered-text></muted-text>`,
},
deleteTag: 'Eliminar etiqueta',
deleteTags: 'Eliminar etiquetas',
Expand Down
12 changes: 6 additions & 6 deletions src/languages/fr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5646,8 +5646,8 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
emptyCategories: {
title: 'Aucune catégorie pour le moment',
subtitle: 'Ajoutez une catégorie pour organiser vos dépenses.',
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Vos catégories sont actuellement importées depuis une connexion comptable. Rendez-vous dans la section <a href="${accountingPageURL}">comptabilité</a> pour effectuer des modifications.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Vos catégories sont actuellement importées depuis une connexion comptable.${canManage ? ` Rendez-vous dans la section <a href="${accountingPageURL}">comptabilité</a> pour effectuer des modifications.` : ''}</centered-text></muted-text>`,
},
updateFailureMessage: 'Une erreur s’est produite lors de la mise à jour de la catégorie, veuillez réessayer.',
createFailureMessage: 'Une erreur s’est produite lors de la création de la catégorie, veuillez réessayer.',
Expand Down Expand Up @@ -6019,14 +6019,14 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
editTags: 'Modifier les tags',
findTag: 'Trouver un tag',
subtitle: 'Les tags ajoutent des moyens plus détaillés de classer les coûts.',
subtitleWithDependentTags: (importSpreadsheetLink: string) =>
`<muted-text>Les tags ajoutent des moyens plus détaillés de classer les coûts. Vous utilisez des <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">tags dépendants</a>. Vous pouvez <a href="${importSpreadsheetLink}">réimporter une feuille de calcul</a> pour mettre à jour vos tags.</muted-text>`,
subtitleWithDependentTags: (importSpreadsheetLink: string, canReimport = true) =>
`<muted-text>Les tags ajoutent des moyens plus détaillés de classer les coûts. Vous utilisez des <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">tags dépendants</a>.${canReimport ? ` Vous pouvez <a href="${importSpreadsheetLink}">réimporter une feuille de calcul</a> pour mettre à jour vos tags.` : ''}</muted-text>`,
emptyTags: {
title: 'Aucun tag pour le moment',
subtitle: 'Ajoutez un tag pour suivre les projets, les lieux, les services et plus encore.',
subtitleHTML: `<muted-text><centered-text>Ajoutez des tags pour suivre les projets, les emplacements, les services, et plus encore. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">En savoir plus</a> sur le formatage des fichiers de tags pour l’importation.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Vos tags sont actuellement importés depuis une connexion comptable. Rendez-vous dans la section <a href="${accountingPageURL}">comptabilité</a> pour effectuer des modifications.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Vos tags sont actuellement importés depuis une connexion comptable.${canManage ? ` Rendez-vous dans la section <a href="${accountingPageURL}">comptabilité</a> pour effectuer des modifications.` : ''}</centered-text></muted-text>`,
},
deleteTag: 'Supprimer le tag',
deleteTags: 'Supprimer les tags',
Expand Down
12 changes: 6 additions & 6 deletions src/languages/it.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5615,8 +5615,8 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
emptyCategories: {
title: 'Nessuna categoria ancora',
subtitle: 'Aggiungi una categoria per organizzare le tue spese.',
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>Le tue categorie sono attualmente importate da una connessione contabile. Vai alla sezione <a href="${accountingPageURL}">contabilità</a> per apportare modifiche.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>Le tue categorie sono attualmente importate da una connessione contabile.${canManage ? ` Vai alla sezione <a href="${accountingPageURL}">contabilità</a> per apportare modifiche.` : ''}</centered-text></muted-text>`,
},
updateFailureMessage: 'Si è verificato un errore durante l’aggiornamento della categoria, riprova per favore',
createFailureMessage: 'Si è verificato un errore durante la creazione della categoria, riprova per favore',
Expand Down Expand Up @@ -5983,14 +5983,14 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
editTags: 'Modifica tag',
findTag: 'Trova tag',
subtitle: 'I tag aggiungono modi più dettagliati per classificare i costi.',
subtitleWithDependentTags: (importSpreadsheetLink: string) =>
`<muted-text>I tag aggiungono modi più dettagliati per classificare i costi. Stai usando i <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">tag dipendenti</a>. Puoi <a href="${importSpreadsheetLink}">importare nuovamente un foglio di calcolo</a> per aggiornare i tuoi tag.</muted-text>`,
subtitleWithDependentTags: (importSpreadsheetLink: string, canReimport = true) =>
`<muted-text>I tag aggiungono modi più dettagliati per classificare i costi. Stai usando i <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL_DEPENDENT_TAGS}">tag dipendenti</a>.${canReimport ? ` Puoi <a href="${importSpreadsheetLink}">importare nuovamente un foglio di calcolo</a> per aggiornare i tuoi tag.` : ''}</muted-text>`,
emptyTags: {
title: 'Nessun tag ancora',
subtitle: 'Aggiungi un tag per tenere traccia di progetti, sedi, reparti e altro ancora.',
subtitleHTML: `<muted-text><centered-text>Aggiungi tag per tenere traccia di progetti, sedi, reparti e altro ancora. <a href="${CONST.IMPORT_TAGS_EXPENSIFY_URL}">Scopri di più</a> sulla formattazione dei file dei tag da importare.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string) =>
`<muted-text><centered-text>I tuoi tag vengono attualmente importati da una connessione di contabilità. Vai alla sezione <a href="${accountingPageURL}">Contabilità</a> per apportare qualsiasi modifica.</centered-text></muted-text>`,
subtitleWithAccounting: (accountingPageURL: string, canManage = true) =>
`<muted-text><centered-text>I tuoi tag vengono attualmente importati da una connessione di contabilità.${canManage ? ` Vai alla sezione <a href="${accountingPageURL}">Contabilità</a> per apportare qualsiasi modifica.` : ''}</centered-text></muted-text>`,
},
deleteTag: 'Elimina tag',
deleteTags: 'Elimina tag',
Expand Down
Loading
Loading