Fix/add descriptive sso error message - #92713
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mnshrm please use the exact same text copy in this comment and update translations. Thanks! |
|
@QichenZhu, Thanks for the review, translations have been updated as per the the comment |
|
@mnshrm please remove any redundant test steps as they will confuse testers. Thanks! |
|
@mnshrm also,
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-09.at.2.13.17.PM.movAndroid: mWeb ChromeScreen.Recording.2026-06-09.at.2.15.50.PM.moviOS: HybridAppSimulator.Screen.Recording.-.iPhone.17.-.2026-06-09.at.14.21.53.moviOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.17.-.2026-06-09.at.14.17.34.movMacOS: Chrome / SafariScreen.Recording.2026-06-09.at.1.28.21.PM.movScreen.Recording.2026-06-09.at.1.37.33.PM.mov |
There was a problem hiding this comment.
We need to increase or maintain test coverage. You can refer to tests/ui/WorkEmailOnboarding.tsx. Let me know if you need help.
|
@QichenZhu, Thanks for the detailed review
|
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.4.5-0 🚀
Bundle Size Analysis (Sentry): |
Help site review: no docs changes requiredI reviewed the changes in this PR against the help site articles under What this PR changesIt adds a single localized inline error message ( Why no docs update is needed
Because no documented behavior is affected, I did not create a draft docs PR. @mnshrm, please confirm you agree that no help site changes are needed here. If you believe a new or updated article is warranted (e.g. a troubleshooting entry for the onboarding work-email step), let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀
|
Explanation of Change
PR adds logic to render specific error message for SSO work email error, when a work email is entered during onboarding with single sign on enabled.
Fixed Issues
$ #91566
PROPOSAL: $ #91566 (comment)
Tests
PRECONDITION: Create an account with a work email with single sign on enabled in order to simulate SSO/SAML error message. (for example applausetester+vq+1104@applause.expensifail.com)
Offline tests
PRE-REQUISITE: A account with work email and SSO enabled.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari