Fix amount field setting to 0.00 by default - #92676
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@DylanDylann please hold reviewing. Requested in https://expensify.slack.com/archives/C07NMDKEFMH/p1780577764612429?thread_ts=1780331800.331249&cid=C07NMDKEFMH from project team |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-04.at.21.24.56.movAndroid: mWeb ChromeScreen.Recording.2026-06-04.at.21.13.35.moviOS: HybridAppScreen.Recording.2026-06-04.at.21.24.56.moviOS: mWeb SafariScreen.Recording.2026-06-04.at.21.12.04.movMacOS: Chrome / SafariScreen.Recording.2026-06-04.at.21.10.49.mov |
|
@MonilBhavsar can you please check the failing test? |
|
Done |
|
@MonilBhavsar Unfortunately, one test failed because of a timeout issue |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required. This PR fixes a UI default-value bug — the amount field now starts empty instead of showing Why no docs update is needed
Since no help article references this behavior, I did not create a draft help site PR. @MonilBhavsar, please confirm you agree no help site changes are needed here. If you'd like an article to explicitly call out the empty-by-default amount field, let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
Explanation of Change
Fixed Issues
$ #92005
PROPOSAL:
Tests
Precondition:
Offline tests
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
See MacOS: Chrome / Safari
Android: mWeb Chrome
See MacOS: Chrome / Safari
iOS: Native
See MacOS: Chrome / Safari
iOS: mWeb Safari
See MacOS: Chrome / Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-04.at.6.29.22.PM.mov