[No-QA] refactor: Navigation code in SelectionList component by TaduJR · Pull Request #92662 · Expensify/App

TaduJR · 2026-06-04T11:29:12Z

Explanation of Change

BaseSelectionList (flat) and BaseSelectionListWithSections (sectioned) carried near-identical, copy-pasted forks of the same focus/navigation logic, which had already started to drift. This PR consolidates that duplicated navigation/interaction logic into shared, single-source modules under src/components/SelectionList/:

useSelectionListKeyboardFocus — the navigation core: wraps useArrowKeyFocusManager and owns the scroll-suppression ref, the focus-restore-aware cursor setters (setFocusedIndexFromRowFocus / setFocusedIndexWithoutScrollOnChange), suppressNextFocusScroll, and the keyboard-navigation modality (the hasKeyBeenPressed flag + Tab listener).
useSelectionListScroll — the bounds-checked scrollToIndex and its debounced variant.
useSelectionListShortcuts — the Enter / Ctrl+Enter shortcuts and disableEnterShortcut gating.
useSelectionListTextInput — the search-input refs and key handlers.
SelectionListEmptyState — the shared loading-skeleton / empty-state rendering.

Both BaseSelectionList and BaseSelectionListWithSections now consume these instead of maintaining their own copies; the per-list differences (data source, isActive expression, section flattening) are passed in as parameters.

Fixed Issues

$ #91033
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…cuts

…tate

…vigation-code-in-SelectionList-component

melvin-bot · 2026-06-04T11:29:19Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

TaduJR · 2026-06-04T11:31:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04144e2b06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-06-04T11:38:53Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`83.66% <100.00%> (+16.33%)`	⬆️
...ListWithSections/BaseSelectionListWithSections.tsx	`92.55% <100.00%> (+6.25%)`	⬆️
...lectionList/components/SelectionListEmptyState.tsx	`100.00% <100.00%> (ø)`
...s/SelectionList/hooks/useSelectionListShortcuts.ts	`100.00% <100.00%> (ø)`
...s/SelectionList/hooks/useSelectionListTextInput.ts	`100.00% <100.00%> (ø)`
...lectionList/hooks/useSelectionListKeyboardFocus.ts	`96.29% <96.29%> (ø)`
...ents/SelectionList/hooks/useSelectionListScroll.ts	`90.00% <90.00%> (ø)`
... and 33 files with indirect coverage changes

JmillsExpensify

No product review required.

chatgpt-codex-connector · 2026-06-08T06:10:59Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-06-08T06:20:45Z

Please merge main

MelvinBot · 2026-06-08T06:24:25Z

Review

Reviewed the SelectionList navigation/focus consolidation. The extraction is faithful — the imperative ref API, props interface, arrow-key/scroll-suppression logic, Enter/Ctrl+Enter shortcuts, and focus-restore-aware setters all match the originals after substitution. No correctness regressions found.

Two minor behavioral deltas worth a look (posted inline):

useSelectionListScroll.ts:28 — the flat BaseSelectionList used to swallow the FlashList scroll error silently; the shared hook now Log.warns for both list types, adding backend-forwarded log noise during rapid filtering.
SelectionListEmptyState.tsx:29 — the sectioned-list skeleton telemetry now carries skeleton.shouldUseUserSkeletonView=undefined, a key that was absent before.

Things I checked that are fine

Lost useCallbacks (scrollToIndex, setHasKeyBeenPressed, focusTextInput): the explicit memoization was dropped, but React Compiler runs over src/ and re-memoizes these (the PR even has a commit making BaseSelectionList Compiler-compliant), so no listener-churn/identity regression in production builds.
shouldShowTextInput ?? vs destructuring default: only differs for null, and the prop is typed boolean | undefined, so TS forbids null — no behavioral change.
Imperative handle method names/signatures unchanged; all selectionListRef.current?.* call sites still resolve.
disabledArrowKeyIndexes (flat) / disabledIndexes (sections) routed correctly; row onFocus → setFocusedIndexFromRowFocus wiring preserved.

Next Steps: Reply with @MelvinBot <feedback> to refine this review.

…vigation-code-in-SelectionList-component

TaduJR · 2026-06-08T13:59:27Z

Please merge main

Done.

…vigation-code-in-SelectionList-component

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c31046bbe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

MelvinBot · 2026-06-11T17:45:39Z

Regression scan — no functional regressions found

I diffed every removed inline block against its extracted replacement across both list components. The consolidation is faithful: focus-restore scroll suppression, Enter/Ctrl+Enter gating, shouldBubble, the shouldShowTextInput default, Tab-key keyboard-nav flagging, and the empty/loading-state rendering are all logically identical to the pre-refactor code.

Two things to be aware of (neither is user-facing today):

1. The refactor leans entirely on React Compiler for memoization — make sure compliance stays green.
The originals memoized several of these values; the extracted hooks return plain (un-memoized) functions. This is fine only because React Compiler compiles these hooks. If RC ever fails to compile one of the four new hook files, two real regressions surface:

useSelectionListScroll.ts:30 passes a freshly-created scrollToIndex into useDebounce. useDebounce's own contract is that a changing func identity cancels and restarts the debounce. The flat list previously wrapped scrollToIndex in useCallback([data]), so without RC the debounced scroll would restart every render and effectively stop debouncing during fast keyboard nav.
useSelectionListKeyboardFocus.ts:71 has useEffect(..., [setHasKeyBeenPressed]) where setHasKeyBeenPressed is not memoized, so without RC the Tab-key listener re-subscribes on every render.

→ Confirm react-compiler-compliance-check passes for the 4 new hook files (it runs in CI; worth eyeballing).

2. Minor telemetry attribute change (not a bug).
For the flat list, when a caller doesn't pass shouldUseUserSkeletonView, the old code emitted shouldUseUserSkeletonView: undefined in the skeleton span attributes; the new code omits the key entirely (SelectionListEmptyState.tsx:31). The sectioned-list attribute shape is preserved exactly, per the inline comment. Telemetry-only, no UX impact.

What I verified equivalent (old → new)

Focus-restore suppression — flat list's old if (isFocusRestoreInProgress() && index !== focusedIndex) suppress; setFocusedIndex(index) is equivalent to the shared setFocusedIndexFromRowFocus → setFocusedIndexWithoutScrollOnChange path (suppresses iff restore-in-progress AND index changed).
Enter shortcut — isActive: !disableKeyboardShortcuts && isActive && focusedIndex >= 0 && !disableEnterShortcut matches both originals (AND-order reordering is harmless); shouldStopPropagation and shouldBubble preserved per-list.
Ctrl+Enter — confirmButtonOptions?.onConfirm short-circuit, getFocusedOption() evaluated at call time, and isActive gating all match; correctly omits shouldStopPropagation like both originals.
shouldShowTextInput — shouldShowTextInputProp ?? !!textInputOptions?.label is semantically identical to the old destructuring default; moved out of the default purely to avoid an RC bailout.
scrollToIndex bounds check — reordered !listRef.current guard is equivalent; only difference is the sectioned list dropping a Log.warn on the caught FlashList error (cosmetic).
Empty state — guard data.length === 0 && (loading || empty) unchanged; listEmptyContent ?? null matches old return listEmptyContent.

Note: my initial pass flagged a style-precedence flip in MultiSelectListItem.tsx and a rename in components/TextInput.tsx — those are not part of this PR (they came in via the main merge), so disregard.

Next Steps: Reply with @MelvinBot <feedback> to refine, or have a reviewer confirm RC compliance on the new hooks.

…vigation-code-in-SelectionList-component

TaduJR · 2026-06-12T17:44:23Z

@codex review

chatgpt-codex-connector · 2026-06-12T17:48:12Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: db307d93f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db307d93f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-06-14T10:00:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

…vigation-code-in-SelectionList-component

MonilBhavsar · 2026-06-22T13:59:48Z

@mkhutornyi please fix reviewer checklist when you have a moment

MelvinBot · 2026-06-22T14:14:14Z

Regression review

I diffed each consolidated module against both original forks (BaseSelectionList and BaseSelectionListWithSections) line-by-line, since the regression risk in this kind of dedup is behavioral drift — where the shared module silently adopts one fork's behavior and breaks the other.

Verdict: no functional regressions found. The per-list differences that mattered are all preserved, and all CI (test, typecheck, React Compiler Compliance, perf) is green. A few observable-but-intentional changes and residual runtime risks are noted below.

What I checked (and why each is safe)

Keyboard shortcuts — useSelectionListShortcuts.ts:31-52

Enter isActive = !disableKeyboardShortcuts && isActive && focusedIndex >= 0 && !disableEnterShortcut — matches both old forks once you substitute isActive=isFocused (flat) / isScreenFocused (sectioned).
Ctrl+Enter correctly omits both focusedIndex >= 0 and disableEnterShortcut, and omits shouldStopPropagation — exactly as both forks did. Easy thing to get wrong in consolidation; it's right here.
shouldBubble was identical between Enter and Ctrl+Enter within each old fork, so collapsing to one param is faithful.

Arrow-key focus — useSelectionListKeyboardFocus.ts:71-110

The subtle difference between forks is preserved: the sectioned list gates useArrowKeyFocusManager's isActive on itemsCount > 0 while its isFocused is not gated — both consumers still pass these separately (isActive/isFocused).
setFocusedIndexFromRowFocus adopts the sectioned fork's form, but it's provably equivalent to the flat fork's (isFocusRestoreInProgress() && index !== focusedIndex → suppress, then setFocusedIndex).
setHasKeyBeenPressed lost its useCallback wrapper (it's a plain fn now) and the Tab-listener effect depends on it — but React Compiler Compliance passing confirms it's auto-memoized, so no listener re-registration churn.

Scroll — useSelectionListScroll.ts:24-29

Bounds check + try/catch identical. Observable change: the flat list previously swallowed the scroll error silently; it now emits Log.warn like the sectioned list always did. Harmless / intentional (per the last commit), just now consistent.

Empty state — SelectionListEmptyState.tsx:29-50

Correctly forwards shouldStyleAsTable/shouldUseUserSkeletonView only for the flat list; the sectioned list passes neither, matching the old behavior.
Minor telemetry shape change: when shouldUseUserSkeletonView is undefined the key is now omitted from reasonAttributes rather than present-as-undefined. Negligible for span attributes, but worth knowing if anything queries on that key's presence.

Text input — refs/handlers move into useSelectionListTextInput; both consumers still wire ref={innerTextInputRef}, onKeyPress={textInputKeyPress}, and onFocusChange={(v) => (isTextInputFocusedRef.current = v)}, so shouldSyncFocus gating is unchanged.

Types: the removed InteractiveElementRoles export has no remaining references in src/.

Residual risk (manual QA worth doing): the unit tests cover the hooks in isolation, but the consolidated focus/scroll/highlight behavior is inherently runtime-only. Since the PR has no screenshots/videos and the test steps are just "no console errors," I'd manually verify on web: (1) keyboard arrow/Tab navigation highlights rows and scrolls correctly in a long list, (2) Enter / Ctrl+Enter selection still works (and Enter is suppressed while a button/checkbox is focused), and (3) focus-restore on back-navigation keeps the cursor without an unexpected scroll — on both a flat list (e.g. a member selector) and a sectioned list (e.g. search/mention lists).

Next Steps: Reply with @MelvinBot <feedback> to dig into any specific area.

chatgpt-codex-connector · 2026-06-22T14:16:03Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 83ccd2de4f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

MonilBhavsar

Thanks!

github-actions · 2026-06-22T14:31:05Z

🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-22T14:37:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92662.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-144038797a0-9980e46-a99965009c6649760b68c0f00f1600c0664adf43/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1440387-9980e46-3d02c91b862f76691c37320725eecb608b5bc619/index.html

Web 🕸️
https://92662.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-22T23:26:41Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-22T23:28:15Z

🤖 No help site changes required.

I reviewed the changes in this PR against Expensify's help site content under docs/articles. This is a pure internal code refactor with no user-facing impact:

All changes are confined to src/components/SelectionList/ (consolidating duplicated keyboard-focus / scroll / shortcut / text-input logic into shared hooks) and their unit tests.
No user-facing copy, labels, button text, or feature behavior changed — the diff touches no src/languages/* files and no docs/ content. The PR is correctly labeled [No-QA].

Since the help site documents product behavior (features, settings, workflows) rather than internal component architecture, no documentation updates are needed and no draft docs PR has been created.

@TaduJR, if you believe any user-facing behavior changed here that I missed, let me know and I'll re-evaluate the help site impact.

OSBotify · 2026-06-23T21:58:55Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-23T23:37:25Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

TaduJR added 8 commits June 3, 2026 21:53

refactor: extract shared useSelectionListScroll hook

e849bc3

refactor: extract useSelectionListKeyboardFocus hook

b7de6c7

refactor: extract useSelectionListTextInput and useSelectionListShort…

d440b9d

…cuts

refactor: extract SelectionListEmptyState component

d21ffc4

test: add unit tests for the extracted SelectionList hooks and EmptyS…

640b607

…tate

Merge branch 'main' of https://github.com/TaduJR/App into refactor-Na…

a844131

…vigation-code-in-SelectionList-component

chore: trim redundant comments

b082908

fix: make BaseSelectionList compile under React Compiler

04144e2

TaduJR requested review from a team as code owners June 4, 2026 11:29

melvin-bot Bot assigned TaduJR Jun 4, 2026

melvin-bot Bot requested review from JmillsExpensify and mkhutornyi and removed request for a team June 4, 2026 11:29

melvin-bot Bot removed the request for review from a team June 4, 2026 11:29

TaduJR changed the title ~~refactor: Navigation code in SelectionList component~~ [No-QA] refactor: Navigation code in SelectionList component Jun 4, 2026

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread src/components/SelectionList/hooks/useSelectionListTextInput.ts

Comment thread src/components/SelectionList/hooks/useSelectionListScroll.ts

JmillsExpensify reviewed Jun 4, 2026

View reviewed changes

MelvinBot reviewed Jun 8, 2026

View reviewed changes

Comment thread src/components/SelectionList/hooks/useSelectionListScroll.ts

MelvinBot reviewed Jun 8, 2026

View reviewed changes

Comment thread src/components/SelectionList/components/SelectionListEmptyState.tsx Outdated

TaduJR added 2 commits June 8, 2026 16:35

Merge branch 'main' of https://github.com/TaduJR/App into refactor-Na…

356a1c3

…vigation-code-in-SelectionList-component

fix: flat-list scroll silence + sectioned skeleton telemetry

084e857

Merge branch 'main' of https://github.com/TaduJR/App into refactor-Na…

4c31046

…vigation-code-in-SelectionList-component

chatgpt-codex-connector Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread src/components/SelectionList/hooks/useSelectionListScroll.ts

TaduJR added 3 commits June 12, 2026 19:45

Merge branch 'main' of https://github.com/TaduJR/App into refactor-Na…

ec6c568

…vigation-code-in-SelectionList-component

fix: resolve no-unsafe-type-assertion via interface segregation

f850745

fix: remove now-unused InteractiveElementRoles export

db307d9

chatgpt-codex-connector Bot reviewed Jun 14, 2026

View reviewed changes

Comment thread src/components/SelectionList/hooks/useSelectionListScroll.ts

mkhutornyi approved these changes Jun 14, 2026

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar June 14, 2026 10:05

MonilBhavsar reviewed Jun 19, 2026

View reviewed changes

Comment thread src/components/SelectionList/components/SelectionListEmptyState.tsx

Comment thread src/components/SelectionList/hooks/useSelectionListKeyboardFocus.ts

Comment thread src/components/SelectionList/hooks/useSelectionListScroll.ts Outdated

TaduJR added 2 commits June 21, 2026 21:58

Merge branch 'main' of https://github.com/TaduJR/App into refactor-Na…

de7c171

…vigation-code-in-SelectionList-component

fix: document SelectionListEmptyState props and restore scroll-error log

83ccd2d

TaduJR requested review from MonilBhavsar and mkhutornyi June 21, 2026 19:36

mkhutornyi approved these changes Jun 22, 2026

View reviewed changes

MonilBhavsar approved these changes Jun 22, 2026

View reviewed changes

MonilBhavsar merged commit 1440387 into Expensify:main Jun 22, 2026
34 of 36 checks passed

OSBotify mentioned this pull request Jun 22, 2026

Deploy Checklist: New Expensify 2026-06-22 #94222

Closed

melvin-bot Bot mentioned this pull request Jun 23, 2026

[Due for payment 2026-06-30] [$250] Refactor Navigation code in SelectionList component #91033

Closed

7 tasks

Uh oh!

Conversation

TaduJR commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 4, 2026

Uh oh!

TaduJR commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Jun 8, 2026

Uh oh!

mkhutornyi commented Jun 8, 2026

Uh oh!

Uh oh!

Uh oh!

MelvinBot commented Jun 8, 2026

Review

Uh oh!

TaduJR commented Jun 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

MelvinBot commented Jun 11, 2026

Regression scan — no functional regressions found

Uh oh!

TaduJR commented Jun 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mkhutornyi commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MonilBhavsar commented Jun 22, 2026

Uh oh!

MelvinBot commented Jun 22, 2026

Regression review

Uh oh!

chatgpt-codex-connector Bot commented Jun 22, 2026

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

TaduJR commented Jun 4, 2026 •

edited

Loading

codecov Bot commented Jun 4, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented Jun 14, 2026 •

edited

Loading