Pass the personal details list from useOnyx to getNewAccountIDsAndLogins by bernhardoj · Pull Request #92609 · Expensify/App

bernhardoj · 2026-06-04T04:32:32Z

Explanation of Change

Fixed Issues

$ #66391
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace, go offline

Open the workspace members page
Add a new user
Verify the new optimistic user is shown on the member list
Repeat steps 1-3 for the group chat and room

(DEV only)
Return true here

Create a track expense in self DM
Select Share with accountant
Select a new user
Select any workspace
Verify the new optimistic user is shown on the workspace member list

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

web.2.mp4

melvin-bot · 2026-06-04T04:32:39Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c423deeada

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-06-04T20:29:14Z

No product review needed

shubham1206agra · 2026-06-05T17:07:36Z

@bernhardoj Fix conflicts please

…-useonyx-6

bernhardoj · 2026-06-06T04:10:46Z

@shubham1206agra fixed

shubham1206agra · 2026-06-10T18:10:07Z

@bernhardoj Conflicts and failing tests

…-useonyx-6

codecov · 2026-06-11T03:34:03Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/PersonalDetailsUtils.ts	`81.17% <100.00%> (ø)`
src/libs/actions/IOU/TrackExpense.ts	`80.73% <100.00%> (ø)`
src/libs/actions/Policy/Member.ts	`75.98% <100.00%> (ø)`
src/pages/DynamicReportChangeWorkspacePage.tsx	`0.00% <ø> (ø)`
.../request/step/confirmation/useExpenseSubmission.ts	`68.75% <ø> (ø)`
...kspace/members/WorkspaceInviteMessageComponent.tsx	`0.00% <ø> (ø)`
src/pages/DynamicReportParticipantsInvitePage.tsx	`0.00% <0.00%> (ø)`
src/pages/DynamicRoomInvitePage.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/Report/index.ts	`70.14% <42.85%> (-0.11%)`	⬇️
... and 11 files with indirect coverage changes

bernhardoj · 2026-06-11T03:38:10Z

@shubham1206agra done

bernhardoj · 2026-06-11T03:59:09Z

Unrelated lint

…-useonyx-6

shubham1206agra · 2026-06-17T13:14:11Z

    delegateAccountID?: number | undefined;
    // TODO: Remove optional (?) once all callers are updated in follow-up PRs of https://github.com/Expensify/App/issues/66578
    reportActionsList?: OnyxCollection<OnyxTypes.ReportActions>;
+    personalDetailsList?: OnyxEntry<OnyxTypes.PersonalDetailsList>;


Suggested change

personalDetailsList?: OnyxEntry<OnyxTypes.PersonalDetailsList>;

personalDetailsList: OnyxEntry<OnyxTypes.PersonalDetailsList>;

This is intentional because personalDetailsList is only used for sharing with accountant case

@bernhardoj Please write a comment about the same here

shubham1206agra · 2026-06-17T13:14:18Z

    currentUser: CurrentUser;
    // TODO: Remove optional (?) once all callers are updated in follow-up PRs of https://github.com/Expensify/App/issues/66578
    reportActionsList?: OnyxCollection<OnyxTypes.ReportActions>;
+    personalDetailsList?: OnyxEntry<OnyxTypes.PersonalDetailsList>;


Suggested change

personalDetailsList?: OnyxEntry<OnyxTypes.PersonalDetailsList>;

personalDetailsList: OnyxEntry<OnyxTypes.PersonalDetailsList>;

This is intentional because personalDetailsList is only used for sharing with accountant case

bernhardoj · 2026-06-17T13:25:05Z

Tests failing are unrelated

shubham1206agra · 2026-06-17T13:26:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-06-17.at.6.53.21.PM.mov

shubham1206agra · 2026-06-19T17:53:34Z

@bernhardoj Merge main to fix the Jest

…-useonyx-6

bernhardoj · 2026-06-20T07:01:34Z

Done

github-actions · 2026-06-21T13:13:44Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-06-21T13:17:28Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-06-21T13:17:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-21T13:19:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92609.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9bb40f11365-aa5daf5-806f0e924e721966bc2c3bb2c57070c52ccd721a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9bb40f1-aa5daf5-aa6dcb30a31407d93b957c1ad2eeea994c7321b6/index.html

Web 🕸️
https://92609.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-22T23:26:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-22T23:27:57Z

🤖 I reviewed the changes in this PR against the help site files in App/docs/articles.

No help site updates are required.

This is an internal refactor (part of #66391): it passes the personalDetailsList from useOnyx through the function call chain (getNewAccountIDsAndLogins, buildInviteToRoomOnyxData, inviteToRoom/inviteToGroupChat, addMembersToWorkspace, changeReportPolicyAndInviteSubmitter, trackExpense/shareTrackedExpense) instead of reading the module-level allPersonalDetails global. It does not change any user-facing behavior, UI labels, feature names, flows, or settings — the optimistic-member display works exactly as before. There is nothing for the public help site to reflect, so I did not create a draft docs PR.

OSBotify · 2026-06-23T21:58:52Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-23T23:37:22Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

DylanDylann · 2026-07-13T08:27:43Z

    for (const [index, login] of logins.entries()) {
        const accountID = accountIDs.at(index) ?? -1;
-        if (isEmptyObject(allPersonalDetails?.[accountID])) {
+        if (isEmptyObject(personalDetailsList?.[accountID])) {


@bernhardoj @shubham1206agra We're passing personalDetailsList (a large object) just to check whether the account IDs exist or not. I don't think it's worth passing the entire personalDetailsList. I'm wondering if we could use a selector to compute an array of existing account IDs and pass that down instead

Here is the PR for that: #96029

cc: @shubham1206agra

mountiny · 2026-07-13T15:52:30Z

Not an emergency. You can see that the checklist has been filled out.

pass the personal details list from useOnyx

c423dee

bernhardoj requested review from a team as code owners June 4, 2026 04:32

melvin-bot Bot assigned bernhardoj Jun 4, 2026

melvin-bot Bot requested review from joekaufmanexpensify and shubham1206agra and removed request for a team June 4, 2026 04:32

melvin-bot Bot removed the request for review from a team June 4, 2026 04:32

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread src/libs/PersonalDetailsUtils.ts

pass the minimal personal details

faea81a

joekaufmanexpensify removed their request for review June 4, 2026 20:29

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

7a7ba33

…-useonyx-6

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

dd24f63

…-useonyx-6

bernhardoj added 2 commits June 11, 2026 16:53

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

4ceb97e

…-useonyx-6

merged with main

0ddba31

shubham1206agra reviewed Jun 17, 2026

View reviewed changes

prettier

768ae94

add comment

370ce87

shubham1206agra approved these changes Jun 19, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny June 19, 2026 17:53

mountiny approved these changes Jun 19, 2026

View reviewed changes

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

057d013

…-useonyx-6

mountiny approved these changes Jun 21, 2026

View reviewed changes

mountiny merged commit 9bb40f1 into Expensify:main Jun 21, 2026
32 of 33 checks passed

melvin-bot Bot added the Emergency label Jun 21, 2026

OSBotify mentioned this pull request Jun 22, 2026

Deploy Checklist: New Expensify 2026-06-22 #94222

Closed

melvin-bot Bot mentioned this pull request Jun 23, 2026

Remove Onyx.connect() for the key: ONYXKEYS.PERSONAL_DETAILS_LIST in src/libs/PersonalDetailsUtils.ts #66391

Open

DylanDylann reviewed Jul 13, 2026

View reviewed changes

mountiny removed the Emergency label Jul 13, 2026

	personalDetailsList?: OnyxEntry<OnyxTypes.PersonalDetailsList>;
	personalDetailsList: OnyxEntry<OnyxTypes.PersonalDetailsList>;

Uh oh!

Conversation

bernhardoj commented Jun 4, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify commented Jun 4, 2026

Uh oh!

shubham1206agra commented Jun 5, 2026

Uh oh!

bernhardoj commented Jun 6, 2026

Uh oh!

shubham1206agra commented Jun 10, 2026

Uh oh!

codecov Bot commented Jun 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj commented Jun 11, 2026

Uh oh!

bernhardoj commented Jun 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jun 17, 2026

Uh oh!

shubham1206agra commented Jun 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

shubham1206agra commented Jun 19, 2026

Uh oh!

bernhardoj commented Jun 20, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

melvin-bot Bot commented Jun 21, 2026

Uh oh!

OSBotify commented Jun 21, 2026

Uh oh!

github-actions Bot commented Jun 21, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

MelvinBot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny commented Jul 13, 2026

Uh oh!

Reviewers

codecov Bot commented Jun 11, 2026 •

edited by github-actions Bot

Loading